* [PATCH] Staging: sm750fb: ddk750_dvi: Fixed character limit warning
@ 2015-10-08 9:42 Shivani Bhardwaj
2015-10-08 10:25 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Shivani Bhardwaj @ 2015-10-08 9:42 UTC (permalink / raw)
To: outreachy-kernel
Fixed the warning - line over 80 characters generated by checkpatch by
breaking the line at appropriate places so that the code looks more
readable and good.
Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
---
drivers/staging/sm750fb/ddk750_dvi.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
index a7a2351..382b515 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.c
+++ b/drivers/staging/sm750fb/ddk750_dvi.c
@@ -46,9 +46,10 @@ int dviInit(
pCurrentDviCtrl = g_dcftSupportedDviController;
if (pCurrentDviCtrl->pfnInit != NULL) {
- return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect, dualEdgeClkSelect, hsyncEnable,
- vsyncEnable, deskewEnable, deskewSetting, continuousSyncEnable,
- pllFilterEnable, pllFilterValue);
+ return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect,
+ dualEdgeClkSelect, hsyncEnable, vsyncEnable,
+ deskewEnable, deskewSetting, continuousSyncEnable,
+ pllFilterEnable, pllFilterValue);
}
return -1; /* error */
}
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: sm750fb: ddk750_dvi: Fixed character limit warning
2015-10-08 9:42 [PATCH] Staging: sm750fb: ddk750_dvi: Fixed character limit warning Shivani Bhardwaj
@ 2015-10-08 10:25 ` Julia Lawall
2015-10-08 11:39 ` Shivani Bhardwaj
0 siblings, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2015-10-08 10:25 UTC (permalink / raw)
To: Shivani Bhardwaj; +Cc: outreachy-kernel
On Thu, 8 Oct 2015, Shivani Bhardwaj wrote:
> Fixed the warning - line over 80 characters generated by checkpatch by
> breaking the line at appropriate places so that the code looks more
> readable and good.
>
> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_dvi.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
> index a7a2351..382b515 100644
> --- a/drivers/staging/sm750fb/ddk750_dvi.c
> +++ b/drivers/staging/sm750fb/ddk750_dvi.c
> @@ -46,9 +46,10 @@ int dviInit(
>
> pCurrentDviCtrl = g_dcftSupportedDviController;
> if (pCurrentDviCtrl->pfnInit != NULL) {
> - return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect, dualEdgeClkSelect, hsyncEnable,
> - vsyncEnable, deskewEnable, deskewSetting, continuousSyncEnable,
> - pllFilterEnable, pllFilterValue);
> + return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect,
> + dualEdgeClkSelect, hsyncEnable, vsyncEnable,
> + deskewEnable, deskewSetting, continuousSyncEnable,
> + pllFilterEnable, pllFilterValue);
It looks like the arguments are not all lined up - the last ones are more
indented than the others. The real problem would be the ariable names...
julia
> }
> return -1; /* error */
> }
> --
> 2.1.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151008094215.GA4799%40ubuntu.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: sm750fb: ddk750_dvi: Fixed character limit warning
2015-10-08 10:25 ` [Outreachy kernel] " Julia Lawall
@ 2015-10-08 11:39 ` Shivani Bhardwaj
2015-10-08 13:42 ` Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Shivani Bhardwaj @ 2015-10-08 11:39 UTC (permalink / raw)
To: outreachy-kernel
On Thu, Oct 08, 2015 at 11:25:22AM +0100, Julia Lawall wrote:
> On Thu, 8 Oct 2015, Shivani Bhardwaj wrote:
>
> > Fixed the warning - line over 80 characters generated by checkpatch by
> > breaking the line at appropriate places so that the code looks more
> > readable and good.
> >
> > Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> > ---
> > drivers/staging/sm750fb/ddk750_dvi.c | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
> > index a7a2351..382b515 100644
> > --- a/drivers/staging/sm750fb/ddk750_dvi.c
> > +++ b/drivers/staging/sm750fb/ddk750_dvi.c
> > @@ -46,9 +46,10 @@ int dviInit(
> >
> > pCurrentDviCtrl = g_dcftSupportedDviController;
> > if (pCurrentDviCtrl->pfnInit != NULL) {
> > - return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect, dualEdgeClkSelect, hsyncEnable,
> > - vsyncEnable, deskewEnable, deskewSetting, continuousSyncEnable,
> > - pllFilterEnable, pllFilterValue);
> > + return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect,
> > + dualEdgeClkSelect, hsyncEnable, vsyncEnable,
> > + deskewEnable, deskewSetting, continuousSyncEnable,
> > + pllFilterEnable, pllFilterValue);
>
> It looks like the arguments are not all lined up - the last ones are more
> indented than the others. The real problem would be the ariable names...
>
> julia
>
So, should I indent the last line in accordance with the previous ones?
Will that work fine? I'm sorry, I do not understand what would be the
problem with variable names.
Thanks
Shivani
> > }
> > return -1; /* error */
> > }
> > --
> > 2.1.0
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151008094215.GA4799%40ubuntu.
> > For more options, visit https://groups.google.com/d/optout.
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: sm750fb: ddk750_dvi: Fixed character limit warning
2015-10-08 11:39 ` Shivani Bhardwaj
@ 2015-10-08 13:42 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2015-10-08 13:42 UTC (permalink / raw)
To: Shivani Bhardwaj; +Cc: outreachy-kernel
On Thu, 8 Oct 2015, Shivani Bhardwaj wrote:
> On Thu, Oct 08, 2015 at 11:25:22AM +0100, Julia Lawall wrote:
> > On Thu, 8 Oct 2015, Shivani Bhardwaj wrote:
> >
> > > Fixed the warning - line over 80 characters generated by checkpatch by
> > > breaking the line at appropriate places so that the code looks more
> > > readable and good.
> > >
> > > Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> > > ---
> > > drivers/staging/sm750fb/ddk750_dvi.c | 7 ++++---
> > > 1 file changed, 4 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
> > > index a7a2351..382b515 100644
> > > --- a/drivers/staging/sm750fb/ddk750_dvi.c
> > > +++ b/drivers/staging/sm750fb/ddk750_dvi.c
> > > @@ -46,9 +46,10 @@ int dviInit(
> > >
> > > pCurrentDviCtrl = g_dcftSupportedDviController;
> > > if (pCurrentDviCtrl->pfnInit != NULL) {
> > > - return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect, dualEdgeClkSelect, hsyncEnable,
> > > - vsyncEnable, deskewEnable, deskewSetting, continuousSyncEnable,
> > > - pllFilterEnable, pllFilterValue);
> > > + return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect,
> > > + dualEdgeClkSelect, hsyncEnable, vsyncEnable,
> > > + deskewEnable, deskewSetting, continuousSyncEnable,
> > > + pllFilterEnable, pllFilterValue);
> >
> > It looks like the arguments are not all lined up - the last ones are more
> > indented than the others. The real problem would be the ariable names...
> >
> > julia
> >
>
> So, should I indent the last line in accordance with the previous ones?
> Will that work fine? I'm sorry, I do not understand what would be the
> problem with variable names.
All the arguments should always be lined up in the same way.
The variable names are very long. If you look in the mainline kernel, the
variable names are not so long, and camel case is not used. It's sort of
orthogonal to the patch, except that if the variable names were not so
long, the code might not have been over the 80 character limit.
julia
>
> Thanks
> Shivani
>
> > > }
> > > return -1; /* error */
> > > }
> > > --
> > > 2.1.0
> > >
> > > --
> > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151008094215.GA4799%40ubuntu.
> > > For more options, visit https://groups.google.com/d/optout.
> > >
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20151008113944.GA5621%40ubuntu.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-08 13:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-08 9:42 [PATCH] Staging: sm750fb: ddk750_dvi: Fixed character limit warning Shivani Bhardwaj
2015-10-08 10:25 ` [Outreachy kernel] " Julia Lawall
2015-10-08 11:39 ` Shivani Bhardwaj
2015-10-08 13:42 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.