From: Greg KH <gregkh@linuxfoundation.org>
To: Shivani Bhardwaj <shivanib134@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: sm750fb: ddk750_help: Included KERN_ facility level
Date: Thu, 8 Oct 2015 21:14:02 -0700 [thread overview]
Message-ID: <20151009041402.GA31030@kroah.com> (raw)
In-Reply-To: <20151008100054.GA5215@ubuntu>
On Thu, Oct 08, 2015 at 03:30:54PM +0530, Shivani Bhardwaj wrote:
> Fixed the warning : printk() should include KERN_ facility level
> generated by checkpatch by using the function pr_info() instead of
> printk().
>
> Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_help.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
> index 9637dd3..e72a29c 100644
> --- a/drivers/staging/sm750fb/ddk750_help.c
> +++ b/drivers/staging/sm750fb/ddk750_help.c
> @@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
> devId750 = devId;
> revId750 = revId;
> if (revId == 0xfe)
> - printk("found sm750le\n");
> + pr_info("found sm750le\n");
Can you use dev_info() here instead?
next prev parent reply other threads:[~2015-10-09 4:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 10:00 [PATCH] Staging: sm750fb: ddk750_help: Included KERN_ facility level Shivani Bhardwaj
2015-10-09 4:14 ` Greg KH [this message]
2015-10-09 6:28 ` [Outreachy kernel] " Shivani Bhardwaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151009041402.GA31030@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=shivanib134@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.