Re: [Outreachy kernel] [PATCH] Staging: sm750fb: ddk750_help: Included KERN_ facility level

[Shivani Bhardwaj <shivanib134@gmail.com>]

On Thu, Oct 08, 2015 at 09:14:02PM -0700, Greg KH wrote:
> On Thu, Oct 08, 2015 at 03:30:54PM +0530, Shivani Bhardwaj wrote:
> > Fixed the warning : printk() should include KERN_ facility level
> > generated by checkpatch by using the function pr_info() instead of
> > printk().
> > 
> > Signed-off-by: Shivani Bhardwaj <shivanib134@gmail.com>
> > ---
> >  drivers/staging/sm750fb/ddk750_help.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
> > index 9637dd3..e72a29c 100644
> > --- a/drivers/staging/sm750fb/ddk750_help.c
> > +++ b/drivers/staging/sm750fb/ddk750_help.c
> > @@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
> >  	devId750 = devId;
> >  	revId750 = revId;
> >  	if (revId == 0xfe)
> > -		printk("found sm750le\n");
> > +		pr_info("found sm750le\n");
> 
> Can you use dev_info() here instead?

Yes, OK. I'm sending version 2. :)
Thank you