From: Ido Schimmel <idosch@mellanox.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: bridge@lists.linux-foundation.org,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
netdev@vger.kernel.org, roopa@cumulusnetworks.com,
shm@cumulusnetworks.com, davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next 1/4] bridge: vlan: use proper rcu for the vlgrp member
Date: Mon, 12 Oct 2015 20:29:55 +0300 [thread overview]
Message-ID: <20151012172921.GB6756@colbert.mtl.com> (raw)
In-Reply-To: <1444650069-32572-2-git-send-email-razor@blackwall.org>
Mon, Oct 12, 2015 at 02:41:06PM IDT, razor@blackwall.org wrote:
>From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
>
Hi Nik,
Small nitpick:
<snip>
>@@ -825,17 +848,19 @@ unlock:
>
> int br_vlan_init(struct net_bridge *br)
> {
>+ struct net_bridge_vlan_group *vg;
> int ret = -ENOMEM;
>
>- br->vlgrp = kzalloc(sizeof(struct net_bridge_vlan_group), GFP_KERNEL);
>- if (!br->vlgrp)
>+ vg = kzalloc(sizeof(struct net_bridge_vlan_group), GFP_KERNEL);
Maybe just do sizeof(*vg)?
>+ if (!vg)
> goto out;
>- ret = rhashtable_init(&br->vlgrp->vlan_hash, &br_vlan_rht_params);
>+ ret = rhashtable_init(&vg->vlan_hash, &br_vlan_rht_params);
> if (ret)
> goto err_rhtbl;
>- INIT_LIST_HEAD(&br->vlgrp->vlan_list);
>+ INIT_LIST_HEAD(&vg->vlan_list);
> br->vlan_proto = htons(ETH_P_8021Q);
> br->default_pvid = 1;
>+ rcu_assign_pointer(br->vlgrp, vg);
> ret = br_vlan_add(br, 1,
> BRIDGE_VLAN_INFO_PVID | BRIDGE_VLAN_INFO_UNTAGGED |
> BRIDGE_VLAN_INFO_BRENTRY);
>@@ -846,9 +871,9 @@ out:
> return ret;
</snip>
>--
>2.4.3
>
WARNING: multiple messages have this Message-ID (diff)
From: Ido Schimmel <idosch@mellanox.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: <netdev@vger.kernel.org>, <shm@cumulusnetworks.com>,
<roopa@cumulusnetworks.com>, <stephen@networkplumber.org>,
<bridge@lists.linux-foundation.org>, <davem@davemloft.net>,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Subject: Re: [PATCH net-next 1/4] bridge: vlan: use proper rcu for the vlgrp member
Date: Mon, 12 Oct 2015 20:29:55 +0300 [thread overview]
Message-ID: <20151012172921.GB6756@colbert.mtl.com> (raw)
In-Reply-To: <1444650069-32572-2-git-send-email-razor@blackwall.org>
Mon, Oct 12, 2015 at 02:41:06PM IDT, razor@blackwall.org wrote:
>From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
>
Hi Nik,
Small nitpick:
<snip>
>@@ -825,17 +848,19 @@ unlock:
>
> int br_vlan_init(struct net_bridge *br)
> {
>+ struct net_bridge_vlan_group *vg;
> int ret = -ENOMEM;
>
>- br->vlgrp = kzalloc(sizeof(struct net_bridge_vlan_group), GFP_KERNEL);
>- if (!br->vlgrp)
>+ vg = kzalloc(sizeof(struct net_bridge_vlan_group), GFP_KERNEL);
Maybe just do sizeof(*vg)?
>+ if (!vg)
> goto out;
>- ret = rhashtable_init(&br->vlgrp->vlan_hash, &br_vlan_rht_params);
>+ ret = rhashtable_init(&vg->vlan_hash, &br_vlan_rht_params);
> if (ret)
> goto err_rhtbl;
>- INIT_LIST_HEAD(&br->vlgrp->vlan_list);
>+ INIT_LIST_HEAD(&vg->vlan_list);
> br->vlan_proto = htons(ETH_P_8021Q);
> br->default_pvid = 1;
>+ rcu_assign_pointer(br->vlgrp, vg);
> ret = br_vlan_add(br, 1,
> BRIDGE_VLAN_INFO_PVID | BRIDGE_VLAN_INFO_UNTAGGED |
> BRIDGE_VLAN_INFO_BRENTRY);
>@@ -846,9 +871,9 @@ out:
> return ret;
</snip>
>--
>2.4.3
>
next prev parent reply other threads:[~2015-10-12 17:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 11:41 [Bridge] [PATCH net-next 0/4] bridge: vlan: cleanups & fixes (part 3) Nikolay Aleksandrov
2015-10-12 11:41 ` Nikolay Aleksandrov
2015-10-12 11:41 ` [Bridge] [PATCH net-next 1/4] bridge: vlan: use proper rcu for the vlgrp member Nikolay Aleksandrov
2015-10-12 11:41 ` Nikolay Aleksandrov
2015-10-12 17:29 ` Ido Schimmel [this message]
2015-10-12 17:29 ` Ido Schimmel
2015-10-12 11:41 ` [Bridge] [PATCH net-next 2/4] bridge: vlan: use rcu for vlan_list traversal in br_fill_ifinfo Nikolay Aleksandrov
2015-10-12 11:41 ` Nikolay Aleksandrov
2015-10-12 11:41 ` [Bridge] [PATCH net-next 3/4] bridge: vlan: break vlan_flush in two phases to keep old order Nikolay Aleksandrov
2015-10-12 11:41 ` Nikolay Aleksandrov
2015-10-12 17:39 ` [Bridge] " Ido Schimmel
2015-10-12 17:39 ` Ido Schimmel
2015-10-12 17:55 ` [Bridge] " Nikolay Aleksandrov
2015-10-12 17:55 ` Nikolay Aleksandrov
2015-10-12 18:15 ` [Bridge] " Ido Schimmel
2015-10-12 18:15 ` Ido Schimmel
2015-10-12 18:16 ` [Bridge] " Nikolay Aleksandrov
2015-10-12 18:16 ` Nikolay Aleksandrov
2015-10-12 11:41 ` [Bridge] [PATCH net-next 4/4] bridge: vlan: combine (br|nbp)_vlan_flush into one Nikolay Aleksandrov
2015-10-12 11:41 ` Nikolay Aleksandrov
2015-10-12 17:51 ` [Bridge] " Ido Schimmel
2015-10-12 17:51 ` Ido Schimmel
2015-10-12 18:15 ` [Bridge] " Vivien Didelot
2015-10-12 18:15 ` Vivien Didelot
2015-10-12 18:27 ` [Bridge] " Ido Schimmel
2015-10-12 18:27 ` Ido Schimmel
2015-10-12 19:49 ` [Bridge] " Vivien Didelot
2015-10-12 19:49 ` Vivien Didelot
2015-10-13 6:41 ` [Bridge] " Scott Feldman
2015-10-13 6:41 ` Scott Feldman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151012172921.GB6756@colbert.mtl.com \
--to=idosch@mellanox.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=razor@blackwall.org \
--cc=roopa@cumulusnetworks.com \
--cc=shm@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.