From: Ido Schimmel <idosch@mellanox.com>
To: Nikolay Aleksandrov <razor@blackwall.org>,
sfeldma@gmail.com, vivien.didelot@savoirfairelinux.com
Cc: bridge@lists.linux-foundation.org,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
netdev@vger.kernel.org, roopa@cumulusnetworks.com,
shm@cumulusnetworks.com, davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next 4/4] bridge: vlan: combine (br|nbp)_vlan_flush into one
Date: Mon, 12 Oct 2015 20:51:56 +0300 [thread overview]
Message-ID: <20151012175156.GA16784@colbert.mtl.com> (raw)
In-Reply-To: <1444650069-32572-5-git-send-email-razor@blackwall.org>
Mon, Oct 12, 2015 at 02:41:09PM IDT, razor@blackwall.org wrote:
>From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
>
>As Ido Schimmel pointed out the vlan_vid_del() loop in nbp_vlan_flush is
>unnecessary (and is actually a remnant of the old vlan code) so we can
>remove it and combine both br/nbp vlan_flush functions into one.
Just a small note to Scott and Vivien:
One of the side effects of Nik's recent patchsets is that when VLANs are
flushed on a port the deletion is propagated to the driver via
switchdev ops, as __vlan_vid_del is called.
Therefore there is no need to do internal bookkeeping and remove VLANs
yourself when port is removed from bridge.
>
>Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
WARNING: multiple messages have this Message-ID (diff)
From: Ido Schimmel <idosch@mellanox.com>
To: Nikolay Aleksandrov <razor@blackwall.org>, <sfeldma@gmail.com>,
<vivien.didelot@savoirfairelinux.com>
Cc: <netdev@vger.kernel.org>, <shm@cumulusnetworks.com>,
<roopa@cumulusnetworks.com>, <stephen@networkplumber.org>,
<bridge@lists.linux-foundation.org>, <davem@davemloft.net>,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Subject: Re: [PATCH net-next 4/4] bridge: vlan: combine (br|nbp)_vlan_flush into one
Date: Mon, 12 Oct 2015 20:51:56 +0300 [thread overview]
Message-ID: <20151012175156.GA16784@colbert.mtl.com> (raw)
In-Reply-To: <1444650069-32572-5-git-send-email-razor@blackwall.org>
Mon, Oct 12, 2015 at 02:41:09PM IDT, razor@blackwall.org wrote:
>From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
>
>As Ido Schimmel pointed out the vlan_vid_del() loop in nbp_vlan_flush is
>unnecessary (and is actually a remnant of the old vlan code) so we can
>remove it and combine both br/nbp vlan_flush functions into one.
Just a small note to Scott and Vivien:
One of the side effects of Nik's recent patchsets is that when VLANs are
flushed on a port the deletion is propagated to the driver via
switchdev ops, as __vlan_vid_del is called.
Therefore there is no need to do internal bookkeeping and remove VLANs
yourself when port is removed from bridge.
>
>Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
next prev parent reply other threads:[~2015-10-12 17:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 11:41 [Bridge] [PATCH net-next 0/4] bridge: vlan: cleanups & fixes (part 3) Nikolay Aleksandrov
2015-10-12 11:41 ` Nikolay Aleksandrov
2015-10-12 11:41 ` [Bridge] [PATCH net-next 1/4] bridge: vlan: use proper rcu for the vlgrp member Nikolay Aleksandrov
2015-10-12 11:41 ` Nikolay Aleksandrov
2015-10-12 17:29 ` [Bridge] " Ido Schimmel
2015-10-12 17:29 ` Ido Schimmel
2015-10-12 11:41 ` [Bridge] [PATCH net-next 2/4] bridge: vlan: use rcu for vlan_list traversal in br_fill_ifinfo Nikolay Aleksandrov
2015-10-12 11:41 ` Nikolay Aleksandrov
2015-10-12 11:41 ` [Bridge] [PATCH net-next 3/4] bridge: vlan: break vlan_flush in two phases to keep old order Nikolay Aleksandrov
2015-10-12 11:41 ` Nikolay Aleksandrov
2015-10-12 17:39 ` [Bridge] " Ido Schimmel
2015-10-12 17:39 ` Ido Schimmel
2015-10-12 17:55 ` [Bridge] " Nikolay Aleksandrov
2015-10-12 17:55 ` Nikolay Aleksandrov
2015-10-12 18:15 ` [Bridge] " Ido Schimmel
2015-10-12 18:15 ` Ido Schimmel
2015-10-12 18:16 ` [Bridge] " Nikolay Aleksandrov
2015-10-12 18:16 ` Nikolay Aleksandrov
2015-10-12 11:41 ` [Bridge] [PATCH net-next 4/4] bridge: vlan: combine (br|nbp)_vlan_flush into one Nikolay Aleksandrov
2015-10-12 11:41 ` Nikolay Aleksandrov
2015-10-12 17:51 ` Ido Schimmel [this message]
2015-10-12 17:51 ` Ido Schimmel
2015-10-12 18:15 ` [Bridge] " Vivien Didelot
2015-10-12 18:15 ` Vivien Didelot
2015-10-12 18:27 ` [Bridge] " Ido Schimmel
2015-10-12 18:27 ` Ido Schimmel
2015-10-12 19:49 ` [Bridge] " Vivien Didelot
2015-10-12 19:49 ` Vivien Didelot
2015-10-13 6:41 ` [Bridge] " Scott Feldman
2015-10-13 6:41 ` Scott Feldman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151012175156.GA16784@colbert.mtl.com \
--to=idosch@mellanox.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=razor@blackwall.org \
--cc=roopa@cumulusnetworks.com \
--cc=sfeldma@gmail.com \
--cc=shm@cumulusnetworks.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.