From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] arm: perf: Add event descriptions
Date: Tue, 13 Oct 2015 15:15:52 +0100 [thread overview]
Message-ID: <20151013141551.GK21550@arm.com> (raw)
In-Reply-To: <20151012181037.GA16013@dreric01-gentoo.localdomain>
On Mon, Oct 12, 2015 at 11:10:38AM -0700, Drew Richardson wrote:
> On Mon, Oct 12, 2015 at 03:30:25PM +0100, Will Deacon wrote:
> > I think this looks much better, thanks. The only thing left to do is
> > re-use some of the existing event descriptions from the enum
> > armv7_perf_types that we have at the top of the file, rather than
> > duplicate the event -> ID mapping. Feel free to extend the enumeration
> > if you need to (it's intended to cover all of the architected events).
>
> OK, here you go. I agree that duplicating the event -> ID mapping is
> undesirable, but some rather ugly preprocessor stuff is required to
> convert the enum into it's hex value (is there a better way to do
> this?). I think it may be less ugly if we build the string at runtime
> instead of at compile time (ie, going back to using PMU_EVENT_ATTR
> instead of PMU_EVENT_ATTR_STRING).
Yeah, I see what you mean. However, I don't think we actually need these
as an enum, do we? So maybe just replace the whole lot with a bunch of
#defines (mechanical change since they're already namespaced, separate
patch before this one) and then have this patch use those #defines for
the sysfs stuff.
Sorry for the to-and-fro-ing on this.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Drew Richardson <drew.richardson@arm.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Russell King <linux@arm.linux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Wade Cherry <Wade.Cherry@arm.com>,
Pawel Moll <Pawel.Moll@arm.com>
Subject: Re: [PATCHv2] arm: perf: Add event descriptions
Date: Tue, 13 Oct 2015 15:15:52 +0100 [thread overview]
Message-ID: <20151013141551.GK21550@arm.com> (raw)
In-Reply-To: <20151012181037.GA16013@dreric01-gentoo.localdomain>
On Mon, Oct 12, 2015 at 11:10:38AM -0700, Drew Richardson wrote:
> On Mon, Oct 12, 2015 at 03:30:25PM +0100, Will Deacon wrote:
> > I think this looks much better, thanks. The only thing left to do is
> > re-use some of the existing event descriptions from the enum
> > armv7_perf_types that we have at the top of the file, rather than
> > duplicate the event -> ID mapping. Feel free to extend the enumeration
> > if you need to (it's intended to cover all of the architected events).
>
> OK, here you go. I agree that duplicating the event -> ID mapping is
> undesirable, but some rather ugly preprocessor stuff is required to
> convert the enum into it's hex value (is there a better way to do
> this?). I think it may be less ugly if we build the string at runtime
> instead of at compile time (ie, going back to using PMU_EVENT_ATTR
> instead of PMU_EVENT_ATTR_STRING).
Yeah, I see what you mean. However, I don't think we actually need these
as an enum, do we? So maybe just replace the whole lot with a bunch of
#defines (mechanical change since they're already namespaced, separate
patch before this one) and then have this patch use those #defines for
the sysfs stuff.
Sorry for the to-and-fro-ing on this.
Will
next prev parent reply other threads:[~2015-10-13 14:15 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 18:28 [PATCHv2] arm: perf: Add event descriptions Drew Richardson
2015-10-07 18:28 ` Drew Richardson
2015-10-09 10:13 ` Will Deacon
2015-10-09 10:13 ` Will Deacon
2015-10-09 16:53 ` Drew Richardson
2015-10-09 16:53 ` Drew Richardson
2015-10-12 14:30 ` Will Deacon
2015-10-12 14:30 ` Will Deacon
2015-10-12 18:10 ` Drew Richardson
2015-10-12 18:10 ` Drew Richardson
2015-10-13 14:15 ` Will Deacon [this message]
2015-10-13 14:15 ` Will Deacon
2015-10-13 15:34 ` [PATCH v5 0/2] " Drew Richardson
2015-10-13 15:34 ` Drew Richardson
2015-10-13 15:35 ` [PATCH v5 1/2] arm: perf: Convert event enums to #defines Drew Richardson
2015-10-13 15:35 ` Drew Richardson
2015-10-13 15:36 ` [PATCH v5 2/2] arm: perf: Add event descriptions Drew Richardson
2015-10-13 15:36 ` Drew Richardson
2015-10-15 13:21 ` Will Deacon
2015-10-15 13:21 ` Will Deacon
2015-10-15 15:15 ` Drew Richardson
2015-10-15 15:15 ` Drew Richardson
2015-10-15 15:20 ` Pawel Moll
2015-10-15 15:20 ` Pawel Moll
2015-10-15 15:42 ` Mark Rutland
2015-10-15 15:42 ` Mark Rutland
2015-10-15 15:49 ` Pawel Moll
2015-10-15 15:49 ` Pawel Moll
2015-10-15 15:29 ` Will Deacon
2015-10-15 15:29 ` Will Deacon
2015-10-15 15:41 ` Mark Rutland
2015-10-15 15:41 ` Mark Rutland
2015-10-15 16:31 ` Drew Richardson
2015-10-15 16:31 ` Drew Richardson
2015-10-15 16:44 ` Mark Rutland
2015-10-15 16:44 ` Mark Rutland
2015-10-22 14:05 ` [PATCHv2] " Drew Richardson
2015-10-22 14:05 ` Drew Richardson
2015-10-22 14:07 ` [PATCH 1/2] arm64: perf: Convert event enums to #defines Drew Richardson
2015-10-22 14:07 ` Drew Richardson
2015-10-22 14:07 ` [PATCH 2/2] arm64: perf: Add event descriptions Drew Richardson
2015-10-22 14:07 ` Drew Richardson
2015-10-27 17:32 ` [PATCHv2] arm: " Will Deacon
2015-10-27 17:32 ` Will Deacon
2015-10-28 12:33 ` Mark Rutland
2015-10-28 12:33 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151013141551.GK21550@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.