From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/2] arm: perf: Add event descriptions
Date: Thu, 15 Oct 2015 14:21:12 +0100 [thread overview]
Message-ID: <20151015132111.GD29301@arm.com> (raw)
In-Reply-To: <20151013153644.GC18121@dreric01-gentoo.localdomain>
On Tue, Oct 13, 2015 at 08:36:45AM -0700, Drew Richardson wrote:
> Add additional information about the ARM architected hardware events
> to make counters self describing. This makes the hardware PMUs easier
> to use as perf list contains possible events instead of users having
> to refer to documentation like the ARM TRMs.
>
> Signed-off-by: Drew Richardson <drew.richardson@arm.com>
> ---
> arch/arm/kernel/perf_event_v7.c | 121 ++++++++++++++++++++++++++++++++++++++++
> drivers/perf/arm_pmu.c | 1 +
> 2 files changed, 122 insertions(+)
[...]
> diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
> index 2365a32a595e..e933d2dd71c0 100644
> --- a/drivers/perf/arm_pmu.c
> +++ b/drivers/perf/arm_pmu.c
> @@ -548,6 +548,7 @@ static void armpmu_init(struct arm_pmu *armpmu)
> .stop = armpmu_stop,
> .read = armpmu_read,
> .filter_match = armpmu_filter_match,
> + .attr_groups = armpmu->pmu.attr_groups,
I don't understand this hunk. What's it doing?
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Drew Richardson <drew.richardson@arm.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Russell King <linux@arm.linux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Wade Cherry <Wade.Cherry@arm.com>,
Pawel Moll <Pawel.Moll@arm.com>
Subject: Re: [PATCH v5 2/2] arm: perf: Add event descriptions
Date: Thu, 15 Oct 2015 14:21:12 +0100 [thread overview]
Message-ID: <20151015132111.GD29301@arm.com> (raw)
In-Reply-To: <20151013153644.GC18121@dreric01-gentoo.localdomain>
On Tue, Oct 13, 2015 at 08:36:45AM -0700, Drew Richardson wrote:
> Add additional information about the ARM architected hardware events
> to make counters self describing. This makes the hardware PMUs easier
> to use as perf list contains possible events instead of users having
> to refer to documentation like the ARM TRMs.
>
> Signed-off-by: Drew Richardson <drew.richardson@arm.com>
> ---
> arch/arm/kernel/perf_event_v7.c | 121 ++++++++++++++++++++++++++++++++++++++++
> drivers/perf/arm_pmu.c | 1 +
> 2 files changed, 122 insertions(+)
[...]
> diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
> index 2365a32a595e..e933d2dd71c0 100644
> --- a/drivers/perf/arm_pmu.c
> +++ b/drivers/perf/arm_pmu.c
> @@ -548,6 +548,7 @@ static void armpmu_init(struct arm_pmu *armpmu)
> .stop = armpmu_stop,
> .read = armpmu_read,
> .filter_match = armpmu_filter_match,
> + .attr_groups = armpmu->pmu.attr_groups,
I don't understand this hunk. What's it doing?
Will
next prev parent reply other threads:[~2015-10-15 13:21 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 18:28 [PATCHv2] arm: perf: Add event descriptions Drew Richardson
2015-10-07 18:28 ` Drew Richardson
2015-10-09 10:13 ` Will Deacon
2015-10-09 10:13 ` Will Deacon
2015-10-09 16:53 ` Drew Richardson
2015-10-09 16:53 ` Drew Richardson
2015-10-12 14:30 ` Will Deacon
2015-10-12 14:30 ` Will Deacon
2015-10-12 18:10 ` Drew Richardson
2015-10-12 18:10 ` Drew Richardson
2015-10-13 14:15 ` Will Deacon
2015-10-13 14:15 ` Will Deacon
2015-10-13 15:34 ` [PATCH v5 0/2] " Drew Richardson
2015-10-13 15:34 ` Drew Richardson
2015-10-13 15:35 ` [PATCH v5 1/2] arm: perf: Convert event enums to #defines Drew Richardson
2015-10-13 15:35 ` Drew Richardson
2015-10-13 15:36 ` [PATCH v5 2/2] arm: perf: Add event descriptions Drew Richardson
2015-10-13 15:36 ` Drew Richardson
2015-10-15 13:21 ` Will Deacon [this message]
2015-10-15 13:21 ` Will Deacon
2015-10-15 15:15 ` Drew Richardson
2015-10-15 15:15 ` Drew Richardson
2015-10-15 15:20 ` Pawel Moll
2015-10-15 15:20 ` Pawel Moll
2015-10-15 15:42 ` Mark Rutland
2015-10-15 15:42 ` Mark Rutland
2015-10-15 15:49 ` Pawel Moll
2015-10-15 15:49 ` Pawel Moll
2015-10-15 15:29 ` Will Deacon
2015-10-15 15:29 ` Will Deacon
2015-10-15 15:41 ` Mark Rutland
2015-10-15 15:41 ` Mark Rutland
2015-10-15 16:31 ` Drew Richardson
2015-10-15 16:31 ` Drew Richardson
2015-10-15 16:44 ` Mark Rutland
2015-10-15 16:44 ` Mark Rutland
2015-10-22 14:05 ` [PATCHv2] " Drew Richardson
2015-10-22 14:05 ` Drew Richardson
2015-10-22 14:07 ` [PATCH 1/2] arm64: perf: Convert event enums to #defines Drew Richardson
2015-10-22 14:07 ` Drew Richardson
2015-10-22 14:07 ` [PATCH 2/2] arm64: perf: Add event descriptions Drew Richardson
2015-10-22 14:07 ` Drew Richardson
2015-10-27 17:32 ` [PATCHv2] arm: " Will Deacon
2015-10-27 17:32 ` Will Deacon
2015-10-28 12:33 ` Mark Rutland
2015-10-28 12:33 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151015132111.GD29301@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.