All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>, arnd@arndb.de
Cc: linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
	Will Deacon <will.deacon@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Russell King <linux@arm.linux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Jisheng Zhang <jszhang@marvell.com>,
	Lina Iyer <lina.iyer@linaro.org>
Subject: Re: [PATCH v2 0/2] Enabling PSCI based idle on ARM 32-bit platforms
Date: Wed, 14 Oct 2015 09:39:00 +0100	[thread overview]
Message-ID: <20151014083900.GA14523@red-moon> (raw)
In-Reply-To: <561CE865.2000509@linaro.org>

Hi Daniel, Arnd,

On Tue, Oct 13, 2015 at 01:17:57PM +0200, Daniel Lezcano wrote:
> On 10/13/2015 12:44 PM, Lorenzo Pieralisi wrote:
> >Hi Daniel,
> >
> >On Tue, Oct 13, 2015 at 10:32:05AM +0200, Daniel Lezcano wrote:
> >>
> >>Hi Lorenzo,
> >>
> >>I would like to take this patch through my tree but it does not apply.
> >
> >That's because as I mentioned in the cover letter the series is built
> >on top of:
> >
> >git://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/linux.git tags/firmware/psci-1.0
> >
> >Hopefully this tag will soon get pulled in arm-soc, I will respin a v3
> >anyway to add tags and fold psci_cpuops.c in psci.c, how do you want to
> >merge this then ?
> 
> May be you can create a branch with your modifications to be shared
> with arm-soc and me ?

I asked Arnd to create an immutable branch containing the patches
in my pull request below in arm-soc:

http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/374547.html

I can then resend v3 of this series on top of it, or if you prefer I
will send you a pull request (to a branch based on the arm-soc one with
my patches on top) just let me know.

Thanks !
Lorenzo

> >>Mind to refresh it against linux-pm or v4.3-rc5 ?
> >>
> >>   -- Daniel
> >>
> >>
> >>On 10/12/2015 01:17 PM, Lorenzo Pieralisi wrote:
> >>>This patch series is v2 of a previous posting:
> >>>
> >>>http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/373756.html
> >>>
> >>>v1->v2:
> >>>
> >>>- Refactored patch 1 to remove cpu parameter from cpuidle_ops
> >>>   suspend hook
> >>>- Refactored psci_cpu_init_idle to stub out dt parsing function and
> >>>   make it usable on both ARM/ARM64 with no additional changes
> >>>- Updated ARM cpuidle_ops to new interfaces
> >>>- Fixed PSCI enable method string in ARM cpuidle_ops struct
> >>>
> >>>PSCI firmware provides a kernel API that, through a standard interface,
> >>>allows to manage power states transitions in a seamless manner for
> >>>ARM and ARM64 systems.
> >>>
> >>>Current PSCI code that initializes CPUidle states on PSCI based
> >>>systems lives in arch/arm64 directory but it is not ARM64 specific
> >>>and can be shared with ARM 32-bit systems so that the generic
> >>>ARM CPUidle driver can leverage the common PSCI interface.
> >>>
> >>>This patch series moves PSCI CPUidle management code to
> >>>drivers/firmware directory so that ARM and ARM64 architecture
> >>>can actually share the code.
> >>>
> >>>It is made up of two patches:
> >>>
> >>>Patch 1 refactors ARM 32-bit generic idle implementation to remove
> >>>the cpu parameter from the cpuidle_ops suspend hook, in preparation
> >>>for a common PSCI implementation for ARM/ARM64 PSCI idle.
> >>>
> >>>Patch 2 moves ARM64 PSCI CPUidle functions implementation to
> >>>drivers/firmware so that it can be shared with ARM 32-bit platforms
> >>>code. This patch also adds a PSCI entry section on ARM 32-bit systems
> >>>so that the PSCI CPUidle back-end can be enabled when the enable-method
> >>>corresponds to PSCI.
> >>>
> >>>Patches apply on top of current patch stack to enable PSCI 1.0:
> >>>
> >>>git://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/linux.git tags/firmware/psci-1.0
> >>>
> >>>Tested on Juno board (ARM64), compile tested only on ARM 32-bit systems.
> >>>
> >>>Lorenzo Pieralisi (2):
> >>>   ARM: cpuidle: remove cpu parameter from the cpuidle_ops suspend hook
> >>>   ARM64: kernel: PSCI: move PSCI idle management code to
> >>>     drivers/firmware
> >>>
> >>>  arch/arm/include/asm/cpuidle.h |   2 +-
> >>>  arch/arm/kernel/cpuidle.c      |   2 +-
> >>>  arch/arm64/kernel/psci.c       |  99 +-----------------------------
> >>>  drivers/firmware/Makefile      |   2 +-
> >>>  drivers/firmware/psci_cpuops.c | 133 +++++++++++++++++++++++++++++++++++++++++
> >>>  drivers/soc/qcom/spm.c         |  10 ++--
> >>>  include/linux/psci.h           |   3 +
> >>>  7 files changed, 146 insertions(+), 105 deletions(-)
> >>>  create mode 100644 drivers/firmware/psci_cpuops.c
> >>>
> >>
> >>
> >>--
> >>  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
> >>
> >>Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> >><http://twitter.com/#!/linaroorg> Twitter |
> >><http://www.linaro.org/linaro-blog/> Blog
> >>
> 
> 
> -- 
>  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
> 
> Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
> 

WARNING: multiple messages have this Message-ID (diff)
From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/2] Enabling PSCI based idle on ARM 32-bit platforms
Date: Wed, 14 Oct 2015 09:39:00 +0100	[thread overview]
Message-ID: <20151014083900.GA14523@red-moon> (raw)
In-Reply-To: <561CE865.2000509@linaro.org>

Hi Daniel, Arnd,

On Tue, Oct 13, 2015 at 01:17:57PM +0200, Daniel Lezcano wrote:
> On 10/13/2015 12:44 PM, Lorenzo Pieralisi wrote:
> >Hi Daniel,
> >
> >On Tue, Oct 13, 2015 at 10:32:05AM +0200, Daniel Lezcano wrote:
> >>
> >>Hi Lorenzo,
> >>
> >>I would like to take this patch through my tree but it does not apply.
> >
> >That's because as I mentioned in the cover letter the series is built
> >on top of:
> >
> >git://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/linux.git tags/firmware/psci-1.0
> >
> >Hopefully this tag will soon get pulled in arm-soc, I will respin a v3
> >anyway to add tags and fold psci_cpuops.c in psci.c, how do you want to
> >merge this then ?
> 
> May be you can create a branch with your modifications to be shared
> with arm-soc and me ?

I asked Arnd to create an immutable branch containing the patches
in my pull request below in arm-soc:

http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/374547.html

I can then resend v3 of this series on top of it, or if you prefer I
will send you a pull request (to a branch based on the arm-soc one with
my patches on top) just let me know.

Thanks !
Lorenzo

> >>Mind to refresh it against linux-pm or v4.3-rc5 ?
> >>
> >>   -- Daniel
> >>
> >>
> >>On 10/12/2015 01:17 PM, Lorenzo Pieralisi wrote:
> >>>This patch series is v2 of a previous posting:
> >>>
> >>>http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/373756.html
> >>>
> >>>v1->v2:
> >>>
> >>>- Refactored patch 1 to remove cpu parameter from cpuidle_ops
> >>>   suspend hook
> >>>- Refactored psci_cpu_init_idle to stub out dt parsing function and
> >>>   make it usable on both ARM/ARM64 with no additional changes
> >>>- Updated ARM cpuidle_ops to new interfaces
> >>>- Fixed PSCI enable method string in ARM cpuidle_ops struct
> >>>
> >>>PSCI firmware provides a kernel API that, through a standard interface,
> >>>allows to manage power states transitions in a seamless manner for
> >>>ARM and ARM64 systems.
> >>>
> >>>Current PSCI code that initializes CPUidle states on PSCI based
> >>>systems lives in arch/arm64 directory but it is not ARM64 specific
> >>>and can be shared with ARM 32-bit systems so that the generic
> >>>ARM CPUidle driver can leverage the common PSCI interface.
> >>>
> >>>This patch series moves PSCI CPUidle management code to
> >>>drivers/firmware directory so that ARM and ARM64 architecture
> >>>can actually share the code.
> >>>
> >>>It is made up of two patches:
> >>>
> >>>Patch 1 refactors ARM 32-bit generic idle implementation to remove
> >>>the cpu parameter from the cpuidle_ops suspend hook, in preparation
> >>>for a common PSCI implementation for ARM/ARM64 PSCI idle.
> >>>
> >>>Patch 2 moves ARM64 PSCI CPUidle functions implementation to
> >>>drivers/firmware so that it can be shared with ARM 32-bit platforms
> >>>code. This patch also adds a PSCI entry section on ARM 32-bit systems
> >>>so that the PSCI CPUidle back-end can be enabled when the enable-method
> >>>corresponds to PSCI.
> >>>
> >>>Patches apply on top of current patch stack to enable PSCI 1.0:
> >>>
> >>>git://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/linux.git tags/firmware/psci-1.0
> >>>
> >>>Tested on Juno board (ARM64), compile tested only on ARM 32-bit systems.
> >>>
> >>>Lorenzo Pieralisi (2):
> >>>   ARM: cpuidle: remove cpu parameter from the cpuidle_ops suspend hook
> >>>   ARM64: kernel: PSCI: move PSCI idle management code to
> >>>     drivers/firmware
> >>>
> >>>  arch/arm/include/asm/cpuidle.h |   2 +-
> >>>  arch/arm/kernel/cpuidle.c      |   2 +-
> >>>  arch/arm64/kernel/psci.c       |  99 +-----------------------------
> >>>  drivers/firmware/Makefile      |   2 +-
> >>>  drivers/firmware/psci_cpuops.c | 133 +++++++++++++++++++++++++++++++++++++++++
> >>>  drivers/soc/qcom/spm.c         |  10 ++--
> >>>  include/linux/psci.h           |   3 +
> >>>  7 files changed, 146 insertions(+), 105 deletions(-)
> >>>  create mode 100644 drivers/firmware/psci_cpuops.c
> >>>
> >>
> >>
> >>--
> >>  <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
> >>
> >>Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> >><http://twitter.com/#!/linaroorg> Twitter |
> >><http://www.linaro.org/linaro-blog/> Blog
> >>
> 
> 
> -- 
>  <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
> 
> Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
> 

  reply	other threads:[~2015-10-14  8:38 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-12 11:17 [PATCH v2 0/2] Enabling PSCI based idle on ARM 32-bit platforms Lorenzo Pieralisi
2015-10-12 11:17 ` Lorenzo Pieralisi
2015-10-12 11:17 ` [PATCH v2 1/2] ARM: cpuidle: remove cpu parameter from the cpuidle_ops suspend hook Lorenzo Pieralisi
2015-10-12 11:17   ` Lorenzo Pieralisi
2015-10-12 14:56   ` Lina Iyer
2015-10-12 14:56     ` Lina Iyer
2015-10-12 15:40     ` Lorenzo Pieralisi
2015-10-12 15:40       ` Lorenzo Pieralisi
2015-10-14 13:42       ` Lina Iyer
2015-10-14 13:42         ` Lina Iyer
2015-10-12 11:17 ` [PATCH v2 2/2] ARM64: kernel: PSCI: move PSCI idle management code to drivers/firmware Lorenzo Pieralisi
2015-10-12 11:17   ` Lorenzo Pieralisi
2015-10-12 14:29   ` Mark Rutland
2015-10-12 14:29     ` Mark Rutland
2015-10-12 15:12     ` Lorenzo Pieralisi
2015-10-12 15:12       ` Lorenzo Pieralisi
2015-10-12 15:35       ` Mark Rutland
2015-10-12 15:35         ` Mark Rutland
2015-10-12 15:37   ` Catalin Marinas
2015-10-12 15:37     ` Catalin Marinas
2015-10-13  8:32 ` [PATCH v2 0/2] Enabling PSCI based idle on ARM 32-bit platforms Daniel Lezcano
2015-10-13  8:32   ` Daniel Lezcano
2015-10-13 10:44   ` Lorenzo Pieralisi
2015-10-13 10:44     ` Lorenzo Pieralisi
2015-10-13 11:17     ` Daniel Lezcano
2015-10-13 11:17       ` Daniel Lezcano
2015-10-14  8:39       ` Lorenzo Pieralisi [this message]
2015-10-14  8:39         ` Lorenzo Pieralisi
2015-10-13 11:34 ` Jisheng Zhang
2015-10-13 11:34   ` Jisheng Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151014083900.GA14523@red-moon \
    --to=lorenzo.pieralisi@arm.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=jszhang@marvell.com \
    --cc=lina.iyer@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=sudeep.holla@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.