From: Lina Iyer <lina.iyer@linaro.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Will Deacon <will.deacon@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Jisheng Zhang <jszhang@marvell.com>
Subject: Re: [PATCH v2 1/2] ARM: cpuidle: remove cpu parameter from the cpuidle_ops suspend hook
Date: Wed, 14 Oct 2015 07:42:59 -0600 [thread overview]
Message-ID: <20151014134259.GG921@linaro.org> (raw)
In-Reply-To: <20151012154054.GA23364@red-moon>
On Mon, Oct 12 2015 at 09:40 -0600, Lorenzo Pieralisi wrote:
>Hi Lina,
>
>On Mon, Oct 12, 2015 at 08:56:40AM -0600, Lina Iyer wrote:
>> On Mon, Oct 12 2015 at 05:16 -0600, Lorenzo Pieralisi wrote:
>> >The suspend() hook in the cpuidle_ops struct is always called on
>> >the cpu entering idle, which means that the cpu parameter passed
>> >to the suspend hook always corresponds to the local cpu, making
>> >it somewhat redundant.
>> >
>> >This patch removes the logical cpu parameter from the ARM
>> >cpuidle_ops.suspend hook and updates all the existing kernel
>> >implementations to reflect this change.
>> >
>> >Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>> >Cc: Lina Iyer <lina.iyer@linaro.org>
>> >Cc: Russell King <linux@arm.linux.org.uk>
>> >Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
>>
>> Reviewed-by: Lina Iyer <lina.iyer@linaro.org>
>
>Thank you very much. May I also ask you to test it please, a Tested-by
>is needed since it affects QCOM platforms I can't test on at present.
>
Tested-by: Lina Iyer <lina.iyer@linaro.org>
Thanks,
Lina
WARNING: multiple messages have this Message-ID (diff)
From: lina.iyer@linaro.org (Lina Iyer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] ARM: cpuidle: remove cpu parameter from the cpuidle_ops suspend hook
Date: Wed, 14 Oct 2015 07:42:59 -0600 [thread overview]
Message-ID: <20151014134259.GG921@linaro.org> (raw)
In-Reply-To: <20151012154054.GA23364@red-moon>
On Mon, Oct 12 2015 at 09:40 -0600, Lorenzo Pieralisi wrote:
>Hi Lina,
>
>On Mon, Oct 12, 2015 at 08:56:40AM -0600, Lina Iyer wrote:
>> On Mon, Oct 12 2015 at 05:16 -0600, Lorenzo Pieralisi wrote:
>> >The suspend() hook in the cpuidle_ops struct is always called on
>> >the cpu entering idle, which means that the cpu parameter passed
>> >to the suspend hook always corresponds to the local cpu, making
>> >it somewhat redundant.
>> >
>> >This patch removes the logical cpu parameter from the ARM
>> >cpuidle_ops.suspend hook and updates all the existing kernel
>> >implementations to reflect this change.
>> >
>> >Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>> >Cc: Lina Iyer <lina.iyer@linaro.org>
>> >Cc: Russell King <linux@arm.linux.org.uk>
>> >Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
>>
>> Reviewed-by: Lina Iyer <lina.iyer@linaro.org>
>
>Thank you very much. May I also ask you to test it please, a Tested-by
>is needed since it affects QCOM platforms I can't test on at present.
>
Tested-by: Lina Iyer <lina.iyer@linaro.org>
Thanks,
Lina
next prev parent reply other threads:[~2015-10-14 13:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 11:17 [PATCH v2 0/2] Enabling PSCI based idle on ARM 32-bit platforms Lorenzo Pieralisi
2015-10-12 11:17 ` Lorenzo Pieralisi
2015-10-12 11:17 ` [PATCH v2 1/2] ARM: cpuidle: remove cpu parameter from the cpuidle_ops suspend hook Lorenzo Pieralisi
2015-10-12 11:17 ` Lorenzo Pieralisi
2015-10-12 14:56 ` Lina Iyer
2015-10-12 14:56 ` Lina Iyer
2015-10-12 15:40 ` Lorenzo Pieralisi
2015-10-12 15:40 ` Lorenzo Pieralisi
2015-10-14 13:42 ` Lina Iyer [this message]
2015-10-14 13:42 ` Lina Iyer
2015-10-12 11:17 ` [PATCH v2 2/2] ARM64: kernel: PSCI: move PSCI idle management code to drivers/firmware Lorenzo Pieralisi
2015-10-12 11:17 ` Lorenzo Pieralisi
2015-10-12 14:29 ` Mark Rutland
2015-10-12 14:29 ` Mark Rutland
2015-10-12 15:12 ` Lorenzo Pieralisi
2015-10-12 15:12 ` Lorenzo Pieralisi
2015-10-12 15:35 ` Mark Rutland
2015-10-12 15:35 ` Mark Rutland
2015-10-12 15:37 ` Catalin Marinas
2015-10-12 15:37 ` Catalin Marinas
2015-10-13 8:32 ` [PATCH v2 0/2] Enabling PSCI based idle on ARM 32-bit platforms Daniel Lezcano
2015-10-13 8:32 ` Daniel Lezcano
2015-10-13 10:44 ` Lorenzo Pieralisi
2015-10-13 10:44 ` Lorenzo Pieralisi
2015-10-13 11:17 ` Daniel Lezcano
2015-10-13 11:17 ` Daniel Lezcano
2015-10-14 8:39 ` Lorenzo Pieralisi
2015-10-14 8:39 ` Lorenzo Pieralisi
2015-10-13 11:34 ` Jisheng Zhang
2015-10-13 11:34 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151014134259.GG921@linaro.org \
--to=lina.iyer@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=sudeep.holla@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.