[PATCH v2 1/2] Staging: sm750fb: Include appropriate KERN_ facility level

[PATCH v2 1/2] Staging: sm750fb: Include appropriate KERN_ facility level

[Aybuke Ozdemir]

Problem found using checkpatch.pl:
"WARNING: printk() should include KERN_ facility level"

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
---
Changes since v1:
* used dev_info instead of pr_info.
---
 drivers/staging/sm750fb/ddk750_help.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
index 9637dd3..d20cd92 100644
--- a/drivers/staging/sm750fb/ddk750_help.c
+++ b/drivers/staging/sm750fb/ddk750_help.c
@@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
 	devId750 = devId;
 	revId750 = revId;
 	if (revId == 0xfe)
-		printk("found sm750le\n");
+		dev_info("found sm750le\n");
 }
 
 
-- 
1.9.1

[PATCH v2 2/2] Staging: sm750fb: Remove multiple blank lines

[Aybuke Ozdemir]

Remove multiple blank lines. Problem found using checkpatch.pl
CHECK: Please don't use multiple blank lines.

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
---
Changes since v1:
* it is part of a set, was re-versioning.
---
 drivers/staging/sm750fb/ddk750_help.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
index d20cd92..2982a7b 100644
--- a/drivers/staging/sm750fb/ddk750_help.c
+++ b/drivers/staging/sm750fb/ddk750_help.c
@@ -13,5 +13,3 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
 	if (revId == 0xfe)
 		dev_info("found sm750le\n");
 }
-
-
-- 
1.9.1

Re: [Outreachy kernel] [PATCH v2 1/2] Staging: sm750fb: Include appropriate KERN_ facility level

[Greg KH]

On Sat, Oct 17, 2015 at 01:04:32AM +0300, Aybuke Ozdemir wrote:
> Problem found using checkpatch.pl:
> "WARNING: printk() should include KERN_ facility level"
> 
> Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
> ---
> Changes since v1:
> * used dev_info instead of pr_info.
> ---
>  drivers/staging/sm750fb/ddk750_help.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
> index 9637dd3..d20cd92 100644
> --- a/drivers/staging/sm750fb/ddk750_help.c
> +++ b/drivers/staging/sm750fb/ddk750_help.c
> @@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
>  	devId750 = devId;
>  	revId750 = revId;
>  	if (revId == 0xfe)
> -		printk("found sm750le\n");
> +		dev_info("found sm750le\n");
>  }

You obviously did not try to build this patch :(

Re: [Outreachy kernel] [PATCH v2 1/2] Staging: sm750fb: Include appropriate KERN_ facility level

[Aybuke Ozdemir]

[-- Attachment #1: Type: text/plain, Size: 532 bytes --]

Hi Greg,

I used this command "make drivers/staging/sm750fb/" before applying the
patch.
I sent that I faced no problems. :( command output:

aybuke@kripton:~/git/kernels/staging$ make drivers/staging/sm750fb/
  CHK     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
  CHK     include/generated/bounds.h
  CHK     include/generated/timeconst.h
  CHK     include/generated/asm-offsets.h
  CALL    scripts/checksyscalls.sh
aybuke@kripton:~/git/kernels/staging$

[-- Attachment #2: Type: text/html, Size: 848 bytes --]

Re: [Outreachy kernel] [PATCH v2 1/2] Staging: sm750fb: Include appropriate KERN_ facility level

[Ksenija Stanojević]

Hi Aybuke

On Sat, Oct 17, 2015 at 12:33 PM, Aybuke Ozdemir <aybuke.147@gmail.com> wrote:
> Hi Greg,
>
> I used this command "make drivers/staging/sm750fb/" before applying the

I'm not sure if that command is correct, try :
make  drivers/staging/sm750fb/ddk750_help.o

> patch.
> I sent that I faced no problems. :( command output:
>
> aybuke@kripton:~/git/kernels/staging$ make drivers/staging/sm750fb/
>   CHK     include/config/kernel.release
>   CHK     include/generated/uapi/linux/version.h
>   CHK     include/generated/utsrelease.h
>   CHK     include/generated/bounds.h
>   CHK     include/generated/timeconst.h
>   CHK     include/generated/asm-offsets.h
>   CALL    scripts/checksyscalls.sh
> aybuke@kripton:~/git/kernels/staging$
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/CAEAX3JrU%3D56tg94bo1w6gHNBr9nEtcgRauXfa%2BGFxa8r477hmw%40mail.gmail.com.
>
> For more options, visit https://groups.google.com/d/optout.

Re: [Outreachy kernel] [PATCH v2 1/2] Staging: sm750fb: Include appropriate KERN_ facility level

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1346 bytes --]

On Sat, 17 Oct 2015, Aybuke Ozdemir wrote:

> Hi Greg,
> 
> I used this command "make drivers/staging/sm750fb/" before applying the
> patch.
> I sent that I faced no problems. :( command output:
> 
> aybuke@kripton:~/git/kernels/staging$ make drivers/staging/sm750fb/
>   CHK     include/config/kernel.release
>   CHK     include/generated/uapi/linux/version.h
>   CHK     include/generated/utsrelease.h
>   CHK     include/generated/bounds.h
>   CHK     include/generated/timeconst.h
>   CHK     include/generated/asm-offsets.h
>   CALL    scripts/checksyscalls.sh
> aybuke@kripton:~/git/kernels/staging$

It doesn't look like it compiled anything.  You would have a CC command if 
it had. Do you have a .o file for the .c file that you changed?

julia

> 
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAEAX3JrU%3D56tg94bo1w6g
> HNBr9nEtcgRauXfa%2BGFxa8r477hmw%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
> 
> 

Re: [Outreachy kernel] [PATCH v2 1/2] Staging: sm750fb: Include appropriate KERN_ facility level

[Aybuke Ozdemir]

[-- Attachment #1: Type: text/plain, Size: 1633 bytes --]

Yes, it really does not compile, I'm sorry for mail traffic. Very thanks
for helps :)

2015-10-17 13:44 GMT+03:00 Julia Lawall <julia.lawall@lip6.fr>:

> On Sat, 17 Oct 2015, Aybuke Ozdemir wrote:
>
> > Hi Greg,
> >
> > I used this command "make drivers/staging/sm750fb/" before applying the
> > patch.
> > I sent that I faced no problems. :( command output:
> >
> > aybuke@kripton:~/git/kernels/staging$ make drivers/staging/sm750fb/
> >   CHK     include/config/kernel.release
> >   CHK     include/generated/uapi/linux/version.h
> >   CHK     include/generated/utsrelease.h
> >   CHK     include/generated/bounds.h
> >   CHK     include/generated/timeconst.h
> >   CHK     include/generated/asm-offsets.h
> >   CALL    scripts/checksyscalls.sh
> > aybuke@kripton:~/git/kernels/staging$
>
> It doesn't look like it compiled anything.  You would have a CC command if
> it had. Do you have a .o file for the .c file that you changed?
>
> julia
>
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visithttps://
> groups.google.com/d/msgid/outreachy-kernel/CAEAX3JrU%3D56tg94bo1w6g
> > HNBr9nEtcgRauXfa%2BGFxa8r477hmw%40mail.gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
> >
>



-- 
Aybüke Özdemir
https://about.me/aybukeozdemir

[-- Attachment #2: Type: text/html, Size: 3118 bytes --]