From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/5] Fix regression introduced by set_irq_flags() removal
Date: Wed, 21 Oct 2015 15:49:37 +0200 [thread overview]
Message-ID: <20151021154937.0684666d@free-electrons.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1510202121590.8159@nanos>
Thomas,
On Tue, 20 Oct 2015 21:23:29 +0200 (CEST), Thomas Gleixner wrote:
> On Tue, 20 Oct 2015, Thomas Petazzoni wrote:
> > As discussed on IRC, another simpler (code line wise) solution is to
> > simply clear the IRQ_NOAUTOEN flag in the irq-armada-370-xp, which
> > brings us back to what set_irq_flags() was doing, without actually
> > reverting Rob's patch.
>
> I prefer that for 4.3.
Done, I've proposed a patch as a reply to this e-mail. It's a one-liner.
> > However, relying on IRQ_NOAUTOEN being cleared doesn't seem like the
> > right long term solution, which is why I implemented what I believe is
> > a (hopefully) better long term solution.
>
> Agreed.
>
> I'll go over the proposed solution tomorrow afternoon (I'm
> traveling/conferencing...)
Sure, no problem.
I also noticed that MSI interrupts are not properly re-enabled after
resume, but it's not a regression from 4.2, as I can also reproduce the
issue on 4.2, so I'll handle that separately.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <marc.zyngier@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Tawfik Bayouk <tawfik@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Lior Amsalem <alior@marvell.com>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Gregory Clement <gregory.clement@free-electrons.com>
Subject: Re: [PATCH 0/5] Fix regression introduced by set_irq_flags() removal
Date: Wed, 21 Oct 2015 15:49:37 +0200 [thread overview]
Message-ID: <20151021154937.0684666d@free-electrons.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1510202121590.8159@nanos>
Thomas,
On Tue, 20 Oct 2015 21:23:29 +0200 (CEST), Thomas Gleixner wrote:
> On Tue, 20 Oct 2015, Thomas Petazzoni wrote:
> > As discussed on IRC, another simpler (code line wise) solution is to
> > simply clear the IRQ_NOAUTOEN flag in the irq-armada-370-xp, which
> > brings us back to what set_irq_flags() was doing, without actually
> > reverting Rob's patch.
>
> I prefer that for 4.3.
Done, I've proposed a patch as a reply to this e-mail. It's a one-liner.
> > However, relying on IRQ_NOAUTOEN being cleared doesn't seem like the
> > right long term solution, which is why I implemented what I believe is
> > a (hopefully) better long term solution.
>
> Agreed.
>
> I'll go over the proposed solution tomorrow afternoon (I'm
> traveling/conferencing...)
Sure, no problem.
I also noticed that MSI interrupts are not properly re-enabled after
resume, but it's not a regression from 4.2, as I can also reproduce the
issue on 4.2, so I'll handle that separately.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-10-21 13:49 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 13:23 [PATCH 0/5] Fix regression introduced by set_irq_flags() removal Thomas Petazzoni
2015-10-20 13:23 ` Thomas Petazzoni
2015-10-20 13:23 ` [PATCH 1/5] kernel: irq: implement is_enabled_percpu_irq() Thomas Petazzoni
2015-10-20 13:23 ` Thomas Petazzoni
2015-12-08 11:57 ` [tip:irq/core] genirq: Implement irq_percpu_is_enabled() tip-bot for Thomas Petazzoni
2015-10-20 13:23 ` [PATCH 2/5] irqchip: armada-370-xp: prepare additions to armada_xp_mpic_secondary_init() Thomas Petazzoni
2015-10-20 13:23 ` Thomas Petazzoni
2015-10-20 14:00 ` Gregory CLEMENT
2015-10-20 14:00 ` Gregory CLEMENT
2015-10-20 13:23 ` [PATCH 3/5] irqchip: armada-370-xp: re-enable per-CPU interrupts at resume time Thomas Petazzoni
2015-10-20 13:23 ` Thomas Petazzoni
2015-10-20 13:46 ` Gregory CLEMENT
2015-10-20 13:46 ` Gregory CLEMENT
2015-10-20 13:50 ` Thomas Petazzoni
2015-10-20 13:50 ` Thomas Petazzoni
2015-10-25 21:22 ` Marcin Wojtas
2015-10-25 21:22 ` Marcin Wojtas
2015-10-26 0:10 ` Thomas Petazzoni
2015-10-26 0:10 ` Thomas Petazzoni
2015-10-26 4:35 ` Marcin Wojtas
2015-10-26 4:35 ` Marcin Wojtas
2015-10-26 5:09 ` Thomas Petazzoni
2015-10-26 5:09 ` Thomas Petazzoni
2015-10-26 7:06 ` Marcin Wojtas
2015-10-26 7:06 ` Marcin Wojtas
2015-10-26 8:27 ` Thomas Petazzoni
2015-10-26 8:27 ` Thomas Petazzoni
2015-10-20 13:23 ` [PATCH 4/5] irqchip: armada-370-xp: re-order register definitions Thomas Petazzoni
2015-10-20 13:23 ` Thomas Petazzoni
2015-10-20 13:55 ` Gregory CLEMENT
2015-10-20 13:55 ` Gregory CLEMENT
2015-10-20 13:23 ` [PATCH 5/5] irqchip: armada-370-xp: document the overall driver logic Thomas Petazzoni
2015-10-20 13:23 ` Thomas Petazzoni
2015-10-20 13:59 ` Gregory CLEMENT
2015-10-20 13:59 ` Gregory CLEMENT
2015-10-20 14:00 ` Thomas Petazzoni
2015-10-20 14:00 ` Thomas Petazzoni
2015-10-20 14:07 ` Jason Cooper
2015-10-20 14:07 ` Jason Cooper
2015-10-20 14:04 ` [PATCH 0/5] Fix regression introduced by set_irq_flags() removal Jason Cooper
2015-10-20 14:04 ` Jason Cooper
2015-10-20 14:08 ` Thomas Petazzoni
2015-10-20 14:08 ` Thomas Petazzoni
2015-10-20 14:17 ` Russell King - ARM Linux
2015-10-20 14:17 ` Russell King - ARM Linux
2015-10-20 14:23 ` Thomas Petazzoni
2015-10-20 14:23 ` Thomas Petazzoni
2015-10-20 19:24 ` Thomas Gleixner
2015-10-20 19:24 ` Thomas Gleixner
2015-10-22 8:01 ` Thomas Gleixner
2015-10-22 8:01 ` Thomas Gleixner
2015-10-20 19:23 ` Thomas Gleixner
2015-10-20 19:23 ` Thomas Gleixner
2015-10-21 13:48 ` [PATCH] irqchip: irq-armada-370-xp: fix regression by clearing IRQ_NOAUTOEN Thomas Petazzoni
2015-10-21 13:48 ` Thomas Petazzoni
2015-10-21 14:41 ` Jason Cooper
2015-10-21 14:41 ` Jason Cooper
2015-10-21 13:49 ` Thomas Petazzoni [this message]
2015-10-21 13:49 ` [PATCH 0/5] Fix regression introduced by set_irq_flags() removal Thomas Petazzoni
2015-11-11 8:26 ` Thomas Petazzoni
2015-11-11 8:26 ` Thomas Petazzoni
2015-11-13 20:11 ` Thomas Gleixner
2015-11-13 20:11 ` Thomas Gleixner
2015-12-04 11:03 ` Thomas Petazzoni
2015-12-04 11:03 ` Thomas Petazzoni
2015-12-05 17:24 ` Thomas Gleixner
2015-12-05 17:24 ` Thomas Gleixner
2015-12-06 9:28 ` Thomas Gleixner
2015-12-06 9:28 ` Thomas Gleixner
2015-12-08 8:58 ` Thomas Petazzoni
2015-12-08 8:58 ` Thomas Petazzoni
2015-12-08 10:54 ` Thomas Gleixner
2015-12-08 10:54 ` Thomas Gleixner
2017-02-24 16:56 ` Thomas Petazzoni
2017-02-24 16:56 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151021154937.0684666d@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.