From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: "Andrew F. Davis" <afd-l0cyMroinI0@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v5 5/5] gpio: tps65912: Add GPIO driver for the TPS65912 PMIC
Date: Fri, 30 Oct 2015 17:10:45 +0000 [thread overview]
Message-ID: <20151030171045.GA4058@x1> (raw)
In-Reply-To: <CACRpkdb+C1M=cFKDNbJW74hUEA=87aA_weR0u22-9bDKgif6xQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Fri, 30 Oct 2015, Linus Walleij wrote:
> On Fri, Oct 30, 2015 at 12:38 AM, Andrew F. Davis <afd-l0cyMroinI0@public.gmane.org> wrote:
>
> > This patch adds support for the TPS65912 PMIC GPIOs.
> >
> > TPS65912 has five configurable GPIOs that can be used for several
> > purposes.
> >
> > Signed-off-by: Andrew F. Davis <afd-l0cyMroinI0@public.gmane.org>
>
> This looks like a fine driver, can't really see anything wrong with it so:
> Reviewed-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>
> > +#define to_tps65912_gpio(gc) container_of(gc, struct tps65912_gpio, gpio_chip)
>
> I would rewrite that to static inline however.
>
> Lee can take this into the MFD tree with my review-tag if he wants.
Please fix this, then resubmit the set with Acks/Reviewed-by's applied.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Andrew F. Davis" <afd@ti.com>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Alexandre Courbot <gnurou@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 5/5] gpio: tps65912: Add GPIO driver for the TPS65912 PMIC
Date: Fri, 30 Oct 2015 17:10:45 +0000 [thread overview]
Message-ID: <20151030171045.GA4058@x1> (raw)
In-Reply-To: <CACRpkdb+C1M=cFKDNbJW74hUEA=87aA_weR0u22-9bDKgif6xQ@mail.gmail.com>
On Fri, 30 Oct 2015, Linus Walleij wrote:
> On Fri, Oct 30, 2015 at 12:38 AM, Andrew F. Davis <afd@ti.com> wrote:
>
> > This patch adds support for the TPS65912 PMIC GPIOs.
> >
> > TPS65912 has five configurable GPIOs that can be used for several
> > purposes.
> >
> > Signed-off-by: Andrew F. Davis <afd@ti.com>
>
> This looks like a fine driver, can't really see anything wrong with it so:
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> > +#define to_tps65912_gpio(gc) container_of(gc, struct tps65912_gpio, gpio_chip)
>
> I would rewrite that to static inline however.
>
> Lee can take this into the MFD tree with my review-tag if he wants.
Please fix this, then resubmit the set with Acks/Reviewed-by's applied.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-10-30 17:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 23:38 [PATCH v5 0/5] mfd: tps65912: Driver rewrite with DT support Andrew F. Davis
2015-10-29 23:38 ` Andrew F. Davis
2015-10-29 23:38 ` [PATCH v5 1/5] Documentation: tps65912: Add DT bindings for the TPS65912 PMIC Andrew F. Davis
2015-10-29 23:38 ` Andrew F. Davis
2015-10-30 17:10 ` Lee Jones
2015-10-30 18:01 ` Andrew F. Davis
2015-10-30 18:01 ` Andrew F. Davis
2015-10-30 19:06 ` Lee Jones
2015-10-30 19:21 ` Andrew F. Davis
2015-10-30 19:21 ` Andrew F. Davis
2015-11-02 9:17 ` Lee Jones
2015-11-02 9:17 ` Lee Jones
2015-11-02 15:15 ` Andrew F. Davis
2015-11-02 15:15 ` Andrew F. Davis
2015-10-29 23:38 ` [PATCH v5 2/5] mfd: tps65912: Remove old driver in preparation for new driver Andrew F. Davis
2015-10-29 23:38 ` Andrew F. Davis
2015-10-29 23:38 ` [PATCH v5 3/5] mfd: tps65912: Add driver for the TPS65912 PMIC Andrew F. Davis
2015-10-29 23:38 ` Andrew F. Davis
2015-10-30 16:55 ` Lee Jones
2015-10-29 23:38 ` [PATCH v5 4/5] regulator: tps65912: Add regulator " Andrew F. Davis
2015-10-29 23:38 ` Andrew F. Davis
2015-10-29 23:38 ` [PATCH v5 5/5] gpio: tps65912: Add GPIO " Andrew F. Davis
2015-10-29 23:38 ` Andrew F. Davis
2015-10-30 14:13 ` Linus Walleij
[not found] ` <CACRpkdb+C1M=cFKDNbJW74hUEA=87aA_weR0u22-9bDKgif6xQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-30 17:10 ` Lee Jones [this message]
2015-10-30 17:10 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151030171045.GA4058@x1 \
--to=lee.jones-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=afd-l0cyMroinI0@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.