From: Will Deacon <will.deacon@arm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
kernel-build-reports@lists.linaro.org, olof@lixom.net,
David Miller <davem@davemloft.net>,
eric.dumazet@gmail.com, netdev@vger.kernel.org,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: next build: 235 warnings 3 failures (next/next-20151117)
Date: Tue, 17 Nov 2015 17:12:37 +0000 [thread overview]
Message-ID: <20151117171236.GJ30101@arm.com> (raw)
In-Reply-To: <6370082.rfihnaNWhf@wuerfel>
On Tue, Nov 17, 2015 at 06:03:40PM +0100, Arnd Bergmann wrote:
> On Tuesday 17 November 2015 16:44:53 Will Deacon wrote:
> > > 8<----
> > > Subject: ARM64: make smp_load_acquire() work with const arguments
> > >
> > > smp_load_acquire() uses typeof() to declare a local variable for temporarily
> > > storing the output of the memory access. This fails when the argument is
> > > constant, because the assembler complains about using a constant register
> > > as output:
> > >
> > > arch/arm64/include/asm/barrier.h:71:3: error: read-only variable '___p1'
> > > used as 'asm' output
> >
> > Do you know the usage in the kernel causing this warning?
>
> A newly introduced function in include/net/sock.h:
>
> static inline int sk_state_load(const struct sock *sk)
> {
> return smp_load_acquire(&sk->sk_state);
> }
Hmm, maybe we could play a similar trick to READ_ONCE by declaring an
anonymous union and writing through the non-const member?
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: next build: 235 warnings 3 failures (next/next-20151117)
Date: Tue, 17 Nov 2015 17:12:37 +0000 [thread overview]
Message-ID: <20151117171236.GJ30101@arm.com> (raw)
In-Reply-To: <6370082.rfihnaNWhf@wuerfel>
On Tue, Nov 17, 2015 at 06:03:40PM +0100, Arnd Bergmann wrote:
> On Tuesday 17 November 2015 16:44:53 Will Deacon wrote:
> > > 8<----
> > > Subject: ARM64: make smp_load_acquire() work with const arguments
> > >
> > > smp_load_acquire() uses typeof() to declare a local variable for temporarily
> > > storing the output of the memory access. This fails when the argument is
> > > constant, because the assembler complains about using a constant register
> > > as output:
> > >
> > > arch/arm64/include/asm/barrier.h:71:3: error: read-only variable '___p1'
> > > used as 'asm' output
> >
> > Do you know the usage in the kernel causing this warning?
>
> A newly introduced function in include/net/sock.h:
>
> static inline int sk_state_load(const struct sock *sk)
> {
> return smp_load_acquire(&sk->sk_state);
> }
Hmm, maybe we could play a similar trick to READ_ONCE by declaring an
anonymous union and writing through the non-const member?
Will
next prev parent reply other threads:[~2015-11-17 17:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <564a9961.878b420a.331b8.fffffd62@mx.google.com>
2015-11-17 8:57 ` next build: 235 warnings 3 failures (next/next-20151117) Arnd Bergmann
2015-11-17 8:57 ` Arnd Bergmann
2015-11-17 16:44 ` Will Deacon
2015-11-17 16:44 ` Will Deacon
2015-11-17 17:01 ` Eric Dumazet
2015-11-17 17:01 ` Eric Dumazet
2015-11-17 17:03 ` Arnd Bergmann
2015-11-17 17:03 ` Arnd Bergmann
2015-11-17 17:12 ` Will Deacon [this message]
2015-11-17 17:12 ` Will Deacon
2015-11-17 19:17 ` Arnd Bergmann
2015-11-17 19:17 ` Arnd Bergmann
2015-11-18 10:14 ` Will Deacon
2015-11-18 10:14 ` Will Deacon
2015-11-18 12:11 ` David Laight
2015-11-18 12:11 ` David Laight
2015-11-18 12:28 ` Will Deacon
2015-11-18 12:28 ` Will Deacon
2015-11-18 15:21 ` David Laight
2015-11-18 15:21 ` David Laight
2015-11-18 15:36 ` Will Deacon
2015-11-18 15:36 ` Will Deacon
2015-11-18 15:57 ` David Laight
2015-11-18 15:57 ` David Laight
2015-11-18 10:22 ` David Laight
2015-11-18 10:22 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151117171236.GJ30101@arm.com \
--to=will.deacon@arm.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kernel-build-reports@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.