All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Leilk Liu <leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Matthias Brugger
	<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/4] spi: mediatek: remove unrequired description
Date: Fri, 20 Nov 2015 08:20:13 -0600	[thread overview]
Message-ID: <20151120142013.GA498@rob-hp-laptop> (raw)
In-Reply-To: <1447986080-31410-2-git-send-email-leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>

On Fri, Nov 20, 2015 at 10:21:17AM +0800, Leilk Liu wrote:
> cs-gpios isn't required with patch "spi: mediatek: single
> device does not require cs_gpios", so modify the description.
> 
> Signed-off-by: Leilk Liu <leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>

This could use a better subject. Try to make subjects specific enough 
they would only ever apply to the change.

Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

> ---
>  .../devicetree/bindings/spi/spi-mt65xx.txt         |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> index fba8334..60a183c 100644
> --- a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> +++ b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> @@ -29,7 +29,7 @@ Required properties:
>    muxes clock, and "spi-clk" for the clock gate.
>  
>  Optional properties:
> --cs-gpios: see spi-bus.txt, only required for MT8173.
> +-cs-gpios: see spi-bus.txt.
>  
>  - mediatek,pad-select: specify which pins group(ck/mi/mo/cs) spi
>    controller used. This is an array, the element value should be 0~3,
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] spi: mediatek: remove unrequired description
Date: Fri, 20 Nov 2015 08:20:13 -0600	[thread overview]
Message-ID: <20151120142013.GA498@rob-hp-laptop> (raw)
In-Reply-To: <1447986080-31410-2-git-send-email-leilk.liu@mediatek.com>

On Fri, Nov 20, 2015 at 10:21:17AM +0800, Leilk Liu wrote:
> cs-gpios isn't required with patch "spi: mediatek: single
> device does not require cs_gpios", so modify the description.
> 
> Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>

This could use a better subject. Try to make subjects specific enough 
they would only ever apply to the change.

Acked-by: Rob Herring <robh@kernel.org>

> ---
>  .../devicetree/bindings/spi/spi-mt65xx.txt         |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> index fba8334..60a183c 100644
> --- a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> +++ b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> @@ -29,7 +29,7 @@ Required properties:
>    muxes clock, and "spi-clk" for the clock gate.
>  
>  Optional properties:
> --cs-gpios: see spi-bus.txt, only required for MT8173.
> +-cs-gpios: see spi-bus.txt.
>  
>  - mediatek,pad-select: specify which pins group(ck/mi/mo/cs) spi
>    controller used. This is an array, the element value should be 0~3,
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Leilk Liu <leilk.liu@mediatek.com>
Cc: Mark Brown <broonie@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 2/4] spi: mediatek: remove unrequired description
Date: Fri, 20 Nov 2015 08:20:13 -0600	[thread overview]
Message-ID: <20151120142013.GA498@rob-hp-laptop> (raw)
In-Reply-To: <1447986080-31410-2-git-send-email-leilk.liu@mediatek.com>

On Fri, Nov 20, 2015 at 10:21:17AM +0800, Leilk Liu wrote:
> cs-gpios isn't required with patch "spi: mediatek: single
> device does not require cs_gpios", so modify the description.
> 
> Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>

This could use a better subject. Try to make subjects specific enough 
they would only ever apply to the change.

Acked-by: Rob Herring <robh@kernel.org>

> ---
>  .../devicetree/bindings/spi/spi-mt65xx.txt         |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> index fba8334..60a183c 100644
> --- a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> +++ b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> @@ -29,7 +29,7 @@ Required properties:
>    muxes clock, and "spi-clk" for the clock gate.
>  
>  Optional properties:
> --cs-gpios: see spi-bus.txt, only required for MT8173.
> +-cs-gpios: see spi-bus.txt.
>  
>  - mediatek,pad-select: specify which pins group(ck/mi/mo/cs) spi
>    controller used. This is an array, the element value should be 0~3,
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-11-20 14:20 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20  2:21 [PATCH 1/4] spi: mediatek: update document devicetree bindings to fix syntax error Leilk Liu
2015-11-20  2:21 ` Leilk Liu
2015-11-20  2:21 ` Leilk Liu
2015-11-20  2:21 ` Leilk Liu
2015-11-20  2:21 ` [PATCH 3/4] spi: mediatek: remove needless pair of writel()/readl() Leilk Liu
2015-11-20  2:21   ` Leilk Liu
2015-11-20  2:21   ` Leilk Liu
2015-11-20 16:56   ` Matthias Brugger
2015-11-20 16:56     ` Matthias Brugger
     [not found]   ` <1447986080-31410-3-git-send-email-leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-11-21 14:03     ` Applied "spi: mediatek: remove needless pair of writel()/readl()" to the spi tree Mark Brown
     [not found] ` <1447986080-31410-1-git-send-email-leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-11-20  2:21   ` [PATCH 2/4] spi: mediatek: remove unrequired description Leilk Liu
2015-11-20  2:21     ` Leilk Liu
2015-11-20  2:21     ` Leilk Liu
2015-11-20  2:21     ` Leilk Liu
     [not found]     ` <1447986080-31410-2-git-send-email-leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-11-20 14:20       ` Rob Herring [this message]
2015-11-20 14:20         ` Rob Herring
2015-11-20 14:20         ` Rob Herring
2015-11-21 14:03       ` Applied "spi: mediatek: remove unrequired description" to the spi tree Mark Brown
2015-11-20  2:21   ` [PATCH 4/4] spi: mediatek: revise mtk_spi_probe() failure flow Leilk Liu
2015-11-20  2:21     ` Leilk Liu
2015-11-20  2:21     ` Leilk Liu
2015-11-20  2:21     ` Leilk Liu
     [not found]     ` <1447986080-31410-4-git-send-email-leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-11-21 13:39       ` Mark Brown
2015-11-21 13:39         ` Mark Brown
2015-11-21 13:39         ` Mark Brown
     [not found]         ` <20151121133949.GH26072-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-11-24  2:33           ` lei liu
2015-11-24  2:33             ` lei liu
2015-11-24  2:33             ` lei liu
2015-11-24  2:33             ` lei liu
2015-11-24 13:04             ` Mark Brown
2015-11-24 13:04               ` Mark Brown
2015-11-24 13:04               ` Mark Brown
     [not found]               ` <20151124130426.GL1929-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-11-25  9:17                 ` lei liu
2015-11-25  9:17                   ` lei liu
2015-11-25  9:17                   ` lei liu
2015-11-25  9:17                   ` lei liu
2015-11-25 12:11       ` Applied "spi: mediatek: revise mtk_spi_probe() failure flow" to the spi tree Mark Brown
2015-11-20 14:17   ` [PATCH 1/4] spi: mediatek: update document devicetree bindings to fix syntax error Rob Herring
2015-11-20 14:17     ` Rob Herring
2015-11-20 14:17     ` Rob Herring
2015-11-21 14:03   ` Applied "spi: mediatek: update document devicetree bindings to fix syntax error" to the spi tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151120142013.GA498@rob-hp-laptop \
    --to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.