All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: lei liu <leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Matthias Brugger
	<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 4/4] spi: mediatek: revise mtk_spi_probe() failure flow
Date: Tue, 24 Nov 2015 13:04:26 +0000	[thread overview]
Message-ID: <20151124130426.GL1929@sirena.org.uk> (raw)
In-Reply-To: <1448332404.27169.4.camel@mhfsdcap03>

[-- Attachment #1: Type: text/plain, Size: 532 bytes --]

On Tue, Nov 24, 2015 at 10:33:24AM +0800, lei liu wrote:
> On Sat, 2015-11-21 at 13:39 +0000, Mark Brown wrote:
> > On Fri, Nov 20, 2015 at 10:21:19AM +0800, Leilk Liu wrote:

> > > This patch revises failure flow while pm_runtime_enable().

> > Why?  This also doesn't apply against current code, please check and
> > resend.

> I don't know. I can git am this patch to spi/for-next. I will resend it,
> please help to apply it again, thanks.

If you don't know why we should make this change then we may as well
just not make it?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] spi: mediatek: revise mtk_spi_probe() failure flow
Date: Tue, 24 Nov 2015 13:04:26 +0000	[thread overview]
Message-ID: <20151124130426.GL1929@sirena.org.uk> (raw)
In-Reply-To: <1448332404.27169.4.camel@mhfsdcap03>

On Tue, Nov 24, 2015 at 10:33:24AM +0800, lei liu wrote:
> On Sat, 2015-11-21 at 13:39 +0000, Mark Brown wrote:
> > On Fri, Nov 20, 2015 at 10:21:19AM +0800, Leilk Liu wrote:

> > > This patch revises failure flow while pm_runtime_enable().

> > Why?  This also doesn't apply against current code, please check and
> > resend.

> I don't know. I can git am this patch to spi/for-next. I will resend it,
> please help to apply it again, thanks.

If you don't know why we should make this change then we may as well
just not make it?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151124/269831a6/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: lei liu <leilk.liu@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 4/4] spi: mediatek: revise mtk_spi_probe() failure flow
Date: Tue, 24 Nov 2015 13:04:26 +0000	[thread overview]
Message-ID: <20151124130426.GL1929@sirena.org.uk> (raw)
In-Reply-To: <1448332404.27169.4.camel@mhfsdcap03>

[-- Attachment #1: Type: text/plain, Size: 532 bytes --]

On Tue, Nov 24, 2015 at 10:33:24AM +0800, lei liu wrote:
> On Sat, 2015-11-21 at 13:39 +0000, Mark Brown wrote:
> > On Fri, Nov 20, 2015 at 10:21:19AM +0800, Leilk Liu wrote:

> > > This patch revises failure flow while pm_runtime_enable().

> > Why?  This also doesn't apply against current code, please check and
> > resend.

> I don't know. I can git am this patch to spi/for-next. I will resend it,
> please help to apply it again, thanks.

If you don't know why we should make this change then we may as well
just not make it?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2015-11-24 13:04 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20  2:21 [PATCH 1/4] spi: mediatek: update document devicetree bindings to fix syntax error Leilk Liu
2015-11-20  2:21 ` Leilk Liu
2015-11-20  2:21 ` Leilk Liu
2015-11-20  2:21 ` Leilk Liu
2015-11-20  2:21 ` [PATCH 3/4] spi: mediatek: remove needless pair of writel()/readl() Leilk Liu
2015-11-20  2:21   ` Leilk Liu
2015-11-20  2:21   ` Leilk Liu
2015-11-20 16:56   ` Matthias Brugger
2015-11-20 16:56     ` Matthias Brugger
     [not found]   ` <1447986080-31410-3-git-send-email-leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-11-21 14:03     ` Applied "spi: mediatek: remove needless pair of writel()/readl()" to the spi tree Mark Brown
     [not found] ` <1447986080-31410-1-git-send-email-leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-11-20  2:21   ` [PATCH 2/4] spi: mediatek: remove unrequired description Leilk Liu
2015-11-20  2:21     ` Leilk Liu
2015-11-20  2:21     ` Leilk Liu
2015-11-20  2:21     ` Leilk Liu
     [not found]     ` <1447986080-31410-2-git-send-email-leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-11-20 14:20       ` Rob Herring
2015-11-20 14:20         ` Rob Herring
2015-11-20 14:20         ` Rob Herring
2015-11-21 14:03       ` Applied "spi: mediatek: remove unrequired description" to the spi tree Mark Brown
2015-11-20  2:21   ` [PATCH 4/4] spi: mediatek: revise mtk_spi_probe() failure flow Leilk Liu
2015-11-20  2:21     ` Leilk Liu
2015-11-20  2:21     ` Leilk Liu
2015-11-20  2:21     ` Leilk Liu
     [not found]     ` <1447986080-31410-4-git-send-email-leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-11-21 13:39       ` Mark Brown
2015-11-21 13:39         ` Mark Brown
2015-11-21 13:39         ` Mark Brown
     [not found]         ` <20151121133949.GH26072-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-11-24  2:33           ` lei liu
2015-11-24  2:33             ` lei liu
2015-11-24  2:33             ` lei liu
2015-11-24  2:33             ` lei liu
2015-11-24 13:04             ` Mark Brown [this message]
2015-11-24 13:04               ` Mark Brown
2015-11-24 13:04               ` Mark Brown
     [not found]               ` <20151124130426.GL1929-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-11-25  9:17                 ` lei liu
2015-11-25  9:17                   ` lei liu
2015-11-25  9:17                   ` lei liu
2015-11-25  9:17                   ` lei liu
2015-11-25 12:11       ` Applied "spi: mediatek: revise mtk_spi_probe() failure flow" to the spi tree Mark Brown
2015-11-20 14:17   ` [PATCH 1/4] spi: mediatek: update document devicetree bindings to fix syntax error Rob Herring
2015-11-20 14:17     ` Rob Herring
2015-11-20 14:17     ` Rob Herring
2015-11-21 14:03   ` Applied "spi: mediatek: update document devicetree bindings to fix syntax error" to the spi tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151124130426.GL1929@sirena.org.uk \
    --to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=leilk.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.