All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] mtd: nand: sunxi: add missing of_node_put
Date: Mon, 23 Nov 2015 13:59:15 +0000	[thread overview]
Message-ID: <20151123145915.04ed6508@bbrezillon> (raw)
In-Reply-To: <1447884254-26336-3-git-send-email-Julia.Lawall@lip6.fr>

On Wed, 18 Nov 2015 23:04:12 +0100
Julia Lawall <Julia.Lawall@lip6.fr> wrote:

> for_each_child_of_node performs an of_node_get on each iteration, so
> a break out of the loop requires an of_node_put.
> 
> A simplified version of the semantic patch that fixes this problem is as
> follows (http://coccinelle.lip6.fr):
> 
> // <smpl>
> @@
> expression root,e;
> local idexpression child;
> @@
> 
>  for_each_child_of_node(root, child) {
>    ... when != of_node_put(child)
>        when != e = child
> (
>    return child;
> |
> +  of_node_put(child);
> ?  return ...;
> )
>    ...
>  }
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

Thanks,

Boris

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Jason Cooper <jason@lakedaemon.net>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Chen-Yu Tsai <wens@csie.org>,
	linux-mtd@lists.infradead.org,
	Bjorn Helgaas <bhelgaas@google.com>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Brian Norris <computersforpeace@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] mtd: nand: sunxi: add missing of_node_put
Date: Mon, 23 Nov 2015 14:59:15 +0100	[thread overview]
Message-ID: <20151123145915.04ed6508@bbrezillon> (raw)
In-Reply-To: <1447884254-26336-3-git-send-email-Julia.Lawall@lip6.fr>

On Wed, 18 Nov 2015 23:04:12 +0100
Julia Lawall <Julia.Lawall@lip6.fr> wrote:

> for_each_child_of_node performs an of_node_get on each iteration, so
> a break out of the loop requires an of_node_put.
> 
> A simplified version of the semantic patch that fixes this problem is as
> follows (http://coccinelle.lip6.fr):
> 
> // <smpl>
> @@
> expression root,e;
> local idexpression child;
> @@
> 
>  for_each_child_of_node(root, child) {
>    ... when != of_node_put(child)
>        when != e = child
> (
>    return child;
> |
> +  of_node_put(child);
> ?  return ...;
> )
>    ...
>  }
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

Thanks,

Boris

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] mtd: nand: sunxi: add missing of_node_put
Date: Mon, 23 Nov 2015 14:59:15 +0100	[thread overview]
Message-ID: <20151123145915.04ed6508@bbrezillon> (raw)
In-Reply-To: <1447884254-26336-3-git-send-email-Julia.Lawall@lip6.fr>

On Wed, 18 Nov 2015 23:04:12 +0100
Julia Lawall <Julia.Lawall@lip6.fr> wrote:

> for_each_child_of_node performs an of_node_get on each iteration, so
> a break out of the loop requires an of_node_put.
> 
> A simplified version of the semantic patch that fixes this problem is as
> follows (http://coccinelle.lip6.fr):
> 
> // <smpl>
> @@
> expression root,e;
> local idexpression child;
> @@
> 
>  for_each_child_of_node(root, child) {
>    ... when != of_node_put(child)
>        when != e = child
> (
>    return child;
> |
> +  of_node_put(child);
> ?  return ...;
> )
>    ...
>  }
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

Thanks,

Boris

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  parent reply	other threads:[~2015-11-23 13:59 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-22  9:02 [PATCH 0/4] add missing of_node_put Julia Lawall
2015-10-22  9:02 ` Julia Lawall
2015-10-22  9:02 ` [PATCH 1/4] of/overlay: " Julia Lawall
2015-10-22  9:02   ` Julia Lawall
2015-10-22  9:02 ` [PATCH 2/4] of/platform: " Julia Lawall
2015-10-22  9:02   ` Julia Lawall
     [not found] ` <1445504571-19838-1-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
2015-10-22  9:02   ` [PATCH 3/4] of/unittest: " Julia Lawall
2015-10-22  9:02     ` Julia Lawall
2015-10-22  9:02     ` Julia Lawall
2015-10-22  9:02 ` [PATCH 4/4] of/irq: " Julia Lawall
2015-10-22  9:02   ` Julia Lawall
2015-10-22 13:04 ` [PATCH 0/4] " Rob Herring
2015-10-22 13:04   ` Rob Herring
     [not found]   ` <CAL_JsqJGS+L=FZAwPs-wBSYiX8kQWqZyaLTGhadYVNT3=Qte_Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-22 13:19     ` Julia Lawall
2015-10-22 13:19       ` Julia Lawall
2015-10-22 13:19       ` Julia Lawall
2015-10-22 15:08 ` Rob Herring
2015-10-22 15:08   ` Rob Herring
2015-11-18 22:04 ` Julia Lawall
2015-11-18 22:04   ` Julia Lawall
2015-11-18 22:04   ` Julia Lawall
2015-11-18 22:04   ` Julia Lawall
2015-11-18 22:04   ` [PATCH 1/4] mtd: brcmnand: improve memory management Julia Lawall
2015-11-18 22:04     ` Julia Lawall
2015-11-18 22:44     ` Brian Norris
2015-11-18 22:44       ` Brian Norris
2015-11-19  6:13       ` Julia Lawall
2015-11-19  6:13         ` Julia Lawall
2015-11-19 19:26         ` Brian Norris
2015-11-19 19:26           ` Brian Norris
2015-11-19 21:32           ` [PATCH 1/4 v2] " Julia Lawall
2015-11-19 21:32             ` Julia Lawall
2015-12-01  1:56             ` Brian Norris
2015-12-01  1:56               ` Brian Norris
2015-11-18 22:04   ` [PATCH 2/4] mtd: nand: sunxi: add missing of_node_put Julia Lawall
2015-11-18 22:04     ` Julia Lawall
2015-11-18 22:04     ` Julia Lawall
2015-11-23  7:26     ` Chen-Yu Tsai
2015-11-23  7:26       ` Chen-Yu Tsai
2015-11-23  7:26       ` Chen-Yu Tsai
2015-11-23 13:59     ` Boris Brezillon [this message]
2015-11-23 13:59       ` Boris Brezillon
2015-11-23 13:59       ` Boris Brezillon
2015-12-01  1:56     ` Brian Norris
2015-12-01  1:56       ` Brian Norris
2015-12-01  1:56       ` Brian Norris
2015-11-18 22:04   ` [PATCH 3/4] iio: adc: spmi-vadc: " Julia Lawall
2015-11-18 22:04     ` Julia Lawall
2015-11-21 18:25     ` Jonathan Cameron
2015-11-18 22:04   ` [PATCH 4/4] power/reset: at91-reset: " Julia Lawall
2015-11-18 22:04     ` Julia Lawall
2015-12-05  0:42     ` Sebastian Reichel
2015-12-05  0:42       ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151123145915.04ed6508@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.