All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Andrew Lunn <andrew@lunn.ch>, Bjorn Helgaas <bhelgaas@google.com>,
	Jason Cooper <jason@lakedaemon.net>
Subject: Re: [PATCH 4/4] power/reset: at91-reset: add missing of_node_put
Date: Sat, 05 Dec 2015 00:42:36 +0000	[thread overview]
Message-ID: <20151205004235.GD22936@earth> (raw)
In-Reply-To: <1447884254-26336-5-git-send-email-Julia.Lawall@lip6.fr>

[-- Attachment #1: Type: text/plain, Size: 685 bytes --]

Hi,

On Wed, Nov 18, 2015 at 11:04:14PM +0100, Julia Lawall wrote:
> for_each_matching_node performs an of_node_get on each iteration, so
> a break out of the loop requires an of_node_put.
> 
> A simplified version of the semantic patch that fixes this problem is as
> follows (http://coccinelle.lip6.fr):
> 
> // <smpl>
> @@
> expression e,e1;
> local idexpression np;
> @@
> 
>  for_each_matching_node(np, e1) {
>    ... when != of_node_put(np)
>        when != e = np
> (
>    return np;
> |
> +  of_node_put(np);
> ?  return ...;
> )
>    ...
>  }
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Thanks, queued.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Reichel <sre@kernel.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Andrew Lunn <andrew@lunn.ch>, Bjorn Helgaas <bhelgaas@google.com>,
	Jason Cooper <jason@lakedaemon.net>
Subject: Re: [PATCH 4/4] power/reset: at91-reset: add missing of_node_put
Date: Sat, 5 Dec 2015 01:42:36 +0100	[thread overview]
Message-ID: <20151205004235.GD22936@earth> (raw)
In-Reply-To: <1447884254-26336-5-git-send-email-Julia.Lawall@lip6.fr>

[-- Attachment #1: Type: text/plain, Size: 685 bytes --]

Hi,

On Wed, Nov 18, 2015 at 11:04:14PM +0100, Julia Lawall wrote:
> for_each_matching_node performs an of_node_get on each iteration, so
> a break out of the loop requires an of_node_put.
> 
> A simplified version of the semantic patch that fixes this problem is as
> follows (http://coccinelle.lip6.fr):
> 
> // <smpl>
> @@
> expression e,e1;
> local idexpression np;
> @@
> 
>  for_each_matching_node(np, e1) {
>    ... when != of_node_put(np)
>        when != e = np
> (
>    return np;
> |
> +  of_node_put(np);
> ?  return ...;
> )
>    ...
>  }
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Thanks, queued.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-12-05  0:42 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-22  9:02 [PATCH 0/4] add missing of_node_put Julia Lawall
2015-10-22  9:02 ` Julia Lawall
2015-10-22  9:02 ` [PATCH 1/4] of/overlay: " Julia Lawall
2015-10-22  9:02   ` Julia Lawall
2015-10-22  9:02 ` [PATCH 2/4] of/platform: " Julia Lawall
2015-10-22  9:02   ` Julia Lawall
     [not found] ` <1445504571-19838-1-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
2015-10-22  9:02   ` [PATCH 3/4] of/unittest: " Julia Lawall
2015-10-22  9:02     ` Julia Lawall
2015-10-22  9:02     ` Julia Lawall
2015-10-22  9:02 ` [PATCH 4/4] of/irq: " Julia Lawall
2015-10-22  9:02   ` Julia Lawall
2015-10-22 13:04 ` [PATCH 0/4] " Rob Herring
2015-10-22 13:04   ` Rob Herring
     [not found]   ` <CAL_JsqJGS+L=FZAwPs-wBSYiX8kQWqZyaLTGhadYVNT3=Qte_Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-22 13:19     ` Julia Lawall
2015-10-22 13:19       ` Julia Lawall
2015-10-22 13:19       ` Julia Lawall
2015-10-22 15:08 ` Rob Herring
2015-10-22 15:08   ` Rob Herring
2015-11-18 22:04 ` Julia Lawall
2015-11-18 22:04   ` Julia Lawall
2015-11-18 22:04   ` Julia Lawall
2015-11-18 22:04   ` Julia Lawall
2015-11-18 22:04   ` [PATCH 1/4] mtd: brcmnand: improve memory management Julia Lawall
2015-11-18 22:04     ` Julia Lawall
2015-11-18 22:44     ` Brian Norris
2015-11-18 22:44       ` Brian Norris
2015-11-19  6:13       ` Julia Lawall
2015-11-19  6:13         ` Julia Lawall
2015-11-19 19:26         ` Brian Norris
2015-11-19 19:26           ` Brian Norris
2015-11-19 21:32           ` [PATCH 1/4 v2] " Julia Lawall
2015-11-19 21:32             ` Julia Lawall
2015-12-01  1:56             ` Brian Norris
2015-12-01  1:56               ` Brian Norris
2015-11-18 22:04   ` [PATCH 2/4] mtd: nand: sunxi: add missing of_node_put Julia Lawall
2015-11-18 22:04     ` Julia Lawall
2015-11-18 22:04     ` Julia Lawall
2015-11-23  7:26     ` Chen-Yu Tsai
2015-11-23  7:26       ` Chen-Yu Tsai
2015-11-23  7:26       ` Chen-Yu Tsai
2015-11-23 13:59     ` Boris Brezillon
2015-11-23 13:59       ` Boris Brezillon
2015-11-23 13:59       ` Boris Brezillon
2015-12-01  1:56     ` Brian Norris
2015-12-01  1:56       ` Brian Norris
2015-12-01  1:56       ` Brian Norris
2015-11-18 22:04   ` [PATCH 3/4] iio: adc: spmi-vadc: " Julia Lawall
2015-11-18 22:04     ` Julia Lawall
2015-11-21 18:25     ` Jonathan Cameron
2015-11-18 22:04   ` [PATCH 4/4] power/reset: at91-reset: " Julia Lawall
2015-11-18 22:04     ` Julia Lawall
2015-12-05  0:42     ` Sebastian Reichel [this message]
2015-12-05  0:42       ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151205004235.GD22936@earth \
    --to=sre@kernel.org \
    --cc=Julia.Lawall@lip6.fr \
    --cc=andrew@lunn.ch \
    --cc=bhelgaas@google.com \
    --cc=dbaryshkov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=jason@lakedaemon.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.