From: Bjorn Helgaas <helgaas@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Hauke Mehrtens <hauke@hauke-m.de>,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, Ray Jui <rjui@broadcom.com.com>,
zajec5@gmail.com
Subject: Re: [PATCH] PCI: iproc: hide CONFIG_PCIE_IPROC
Date: Tue, 24 Nov 2015 15:29:34 -0600 [thread overview]
Message-ID: <20151124212934.GD17377@localhost> (raw)
In-Reply-To: <11420214.lrdhuUq0ZO@wuerfel>
On Tue, Nov 17, 2015 at 05:08:33PM +0100, Arnd Bergmann wrote:
> PCIE_IPROC_BCMA does not require CONFIG_OF in Kconfig, but
> CONFIG_PCIE_IPROC does, so we can get a warning when building
> for an ARM platform without DT support:
>
> warning: (PCIE_IPROC_PLATFORM && PCIE_IPROC_BCMA) selects PCIE_IPROC which has unmet direct dependencies (PCI && OF && (ARM || ARM64))
>
> It turns out that CONFIG_PCIE_IPROC never needs to be enabled
> by a user anyway, we can simply rely on it being selected
> implictly through either PCIE_IPROC_PLATFORM or PCIE_IPROC_BCMA.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 4785ffbdc9b5 ("PCI: iproc: Add BCMA PCIe driver")
Applied with Hauke's ack to pci/host-iproc for v4.5, thanks!
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index f131ba947dc6..767605a5c659 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -118,13 +118,11 @@ config PCI_VERSATILE
> depends on ARCH_VERSATILE
>
> config PCIE_IPROC
> - tristate "Broadcom iProc PCIe controller"
> - depends on OF && (ARM || ARM64)
> - default n
> + tristate
> help
> This enables the iProc PCIe core controller support for Broadcom's
> - iProc family of SoCs. An appropriate bus interface driver also needs
> - to be enabled
> + iProc family of SoCs. An appropriate bus interface driver needs
> + to be enabled to select this.
>
> config PCIE_IPROC_PLATFORM
> tristate "Broadcom iProc PCIe platform bus driver"
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: helgaas@kernel.org (Bjorn Helgaas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PCI: iproc: hide CONFIG_PCIE_IPROC
Date: Tue, 24 Nov 2015 15:29:34 -0600 [thread overview]
Message-ID: <20151124212934.GD17377@localhost> (raw)
In-Reply-To: <11420214.lrdhuUq0ZO@wuerfel>
On Tue, Nov 17, 2015 at 05:08:33PM +0100, Arnd Bergmann wrote:
> PCIE_IPROC_BCMA does not require CONFIG_OF in Kconfig, but
> CONFIG_PCIE_IPROC does, so we can get a warning when building
> for an ARM platform without DT support:
>
> warning: (PCIE_IPROC_PLATFORM && PCIE_IPROC_BCMA) selects PCIE_IPROC which has unmet direct dependencies (PCI && OF && (ARM || ARM64))
>
> It turns out that CONFIG_PCIE_IPROC never needs to be enabled
> by a user anyway, we can simply rely on it being selected
> implictly through either PCIE_IPROC_PLATFORM or PCIE_IPROC_BCMA.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 4785ffbdc9b5 ("PCI: iproc: Add BCMA PCIe driver")
Applied with Hauke's ack to pci/host-iproc for v4.5, thanks!
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index f131ba947dc6..767605a5c659 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -118,13 +118,11 @@ config PCI_VERSATILE
> depends on ARCH_VERSATILE
>
> config PCIE_IPROC
> - tristate "Broadcom iProc PCIe controller"
> - depends on OF && (ARM || ARM64)
> - default n
> + tristate
> help
> This enables the iProc PCIe core controller support for Broadcom's
> - iProc family of SoCs. An appropriate bus interface driver also needs
> - to be enabled
> + iProc family of SoCs. An appropriate bus interface driver needs
> + to be enabled to select this.
>
> config PCIE_IPROC_PLATFORM
> tristate "Broadcom iProc PCIe platform bus driver"
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-11-24 21:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 16:08 [PATCH] PCI: iproc: hide CONFIG_PCIE_IPROC Arnd Bergmann
2015-11-17 16:08 ` Arnd Bergmann
2015-11-17 19:33 ` Hauke Mehrtens
2015-11-17 19:33 ` Hauke Mehrtens
2015-11-24 21:29 ` Bjorn Helgaas [this message]
2015-11-24 21:29 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151124212934.GD17377@localhost \
--to=helgaas@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=hauke@hauke-m.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjui@broadcom.com.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.