From: Hauke Mehrtens <hauke@hauke-m.de>
To: Arnd Bergmann <arnd@arndb.de>, Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, Ray Jui <rjui@broadcom.com.com>,
zajec5@gmail.com
Subject: Re: [PATCH] PCI: iproc: hide CONFIG_PCIE_IPROC
Date: Tue, 17 Nov 2015 20:33:49 +0100 [thread overview]
Message-ID: <564B811D.4000401@hauke-m.de> (raw)
In-Reply-To: <11420214.lrdhuUq0ZO@wuerfel>
On 11/17/2015 05:08 PM, Arnd Bergmann wrote:
> PCIE_IPROC_BCMA does not require CONFIG_OF in Kconfig, but
> CONFIG_PCIE_IPROC does, so we can get a warning when building
> for an ARM platform without DT support:
>
> warning: (PCIE_IPROC_PLATFORM && PCIE_IPROC_BCMA) selects PCIE_IPROC which has unmet direct dependencies (PCI && OF && (ARM || ARM64))
>
> It turns out that CONFIG_PCIE_IPROC never needs to be enabled
> by a user anyway, we can simply rely on it being selected
> implictly through either PCIE_IPROC_PLATFORM or PCIE_IPROC_BCMA.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 4785ffbdc9b5 ("PCI: iproc: Add BCMA PCIe driver")
>
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
Thanks for spotting and fixing this.
hauke
WARNING: multiple messages have this Message-ID (diff)
From: hauke@hauke-m.de (Hauke Mehrtens)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PCI: iproc: hide CONFIG_PCIE_IPROC
Date: Tue, 17 Nov 2015 20:33:49 +0100 [thread overview]
Message-ID: <564B811D.4000401@hauke-m.de> (raw)
In-Reply-To: <11420214.lrdhuUq0ZO@wuerfel>
On 11/17/2015 05:08 PM, Arnd Bergmann wrote:
> PCIE_IPROC_BCMA does not require CONFIG_OF in Kconfig, but
> CONFIG_PCIE_IPROC does, so we can get a warning when building
> for an ARM platform without DT support:
>
> warning: (PCIE_IPROC_PLATFORM && PCIE_IPROC_BCMA) selects PCIE_IPROC which has unmet direct dependencies (PCI && OF && (ARM || ARM64))
>
> It turns out that CONFIG_PCIE_IPROC never needs to be enabled
> by a user anyway, we can simply rely on it being selected
> implictly through either PCIE_IPROC_PLATFORM or PCIE_IPROC_BCMA.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 4785ffbdc9b5 ("PCI: iproc: Add BCMA PCIe driver")
>
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
Thanks for spotting and fixing this.
hauke
next prev parent reply other threads:[~2015-11-17 19:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 16:08 [PATCH] PCI: iproc: hide CONFIG_PCIE_IPROC Arnd Bergmann
2015-11-17 16:08 ` Arnd Bergmann
2015-11-17 19:33 ` Hauke Mehrtens [this message]
2015-11-17 19:33 ` Hauke Mehrtens
2015-11-24 21:29 ` Bjorn Helgaas
2015-11-24 21:29 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564B811D.4000401@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjui@broadcom.com.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.