From: Bjorn Helgaas <helgaas@kernel.org>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: Joao Pinto <Joao.Pinto@synopsys.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
Carlos Palminha <CARLOS.PALMINHA@synopsys.com>,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
arcml <linux-snps-arc@lists.infradead.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 2/2] PCI support added to ARC
Date: Wed, 25 Nov 2015 10:46:36 -0600 [thread overview]
Message-ID: <20151125164636.GB1380@localhost> (raw)
In-Reply-To: <C2D7FE5348E1B147BCA15975FBA23075F44D3B42@IN01WEMBXA.internal.synopsys.com>
On Wed, Nov 25, 2015 at 05:25:37AM +0000, Vineet Gupta wrote:
> On Tuesday 24 November 2015 08:02 PM, Joao Pinto wrote:
> > + pr_err("PCI: Device %s not available because"/
> > + " of resource collisions\n", pci_name(dev));
>
> Better not to break strings - even if they sometime exceed line sz limit of 80.
> You could anyways reduce the string content herer.
Also use dev_err() instead of pr_err().
WARNING: multiple messages have this Message-ID (diff)
From: helgaas@kernel.org (Bjorn Helgaas)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 2/2] PCI support added to ARC
Date: Wed, 25 Nov 2015 10:46:36 -0600 [thread overview]
Message-ID: <20151125164636.GB1380@localhost> (raw)
In-Reply-To: <C2D7FE5348E1B147BCA15975FBA23075F44D3B42@IN01WEMBXA.internal.synopsys.com>
On Wed, Nov 25, 2015@05:25:37AM +0000, Vineet Gupta wrote:
> On Tuesday 24 November 2015 08:02 PM, Joao Pinto wrote:
> > + pr_err("PCI: Device %s not available because"/
> > + " of resource collisions\n", pci_name(dev));
>
> Better not to break strings - even if they sometime exceed line sz limit of 80.
> You could anyways reduce the string content herer.
Also use dev_err() instead of pr_err().
next prev parent reply other threads:[~2015-11-25 16:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 14:32 [PATCH 0/2] adding PCI support to AXS10x Joao Pinto
2015-11-24 14:32 ` [PATCH 1/2] add new platform driver for PCI RC Joao Pinto
2015-12-05 0:30 ` Bjorn Helgaas
2015-12-06 0:42 ` kbuild test robot
2015-12-06 5:12 ` kbuild test robot
2015-11-24 14:32 ` [PATCH 2/2] PCI support added to ARC Joao Pinto
2015-11-25 5:25 ` Vineet Gupta
2015-11-25 5:25 ` Vineet Gupta
2015-11-25 16:46 ` Bjorn Helgaas [this message]
2015-11-25 16:46 ` Bjorn Helgaas
2015-11-26 15:41 ` Joao Pinto
2015-11-26 15:41 ` Joao Pinto
2015-11-30 1:00 ` Bjorn Helgaas
2015-11-30 1:00 ` Bjorn Helgaas
2015-11-30 6:21 ` Vineet Gupta
2015-11-30 6:21 ` Vineet Gupta
-- strict thread matches above, loose matches on Subject: below --
2015-11-24 11:44 [PATCH 0/2] adding PCI support to AXS10x Joao Pinto
2015-11-24 11:44 ` [PATCH 2/2] PCI support added to ARC Joao Pinto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151125164636.GB1380@localhost \
--to=helgaas@kernel.org \
--cc=Alexey.Brodkin@synopsys.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.