From: Pavel Machek <pavel@ucw.cz>
To: James Morse <james.morse@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
Will Deacon <will.deacon@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Kevin Kang <kkang@intrinsyc.com>,
Geoff Levand <geoff@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
AKASHI Takahiro <takahiro.akashi@linaro.org>,
wangfei <w.f@huawei.com>, Marc Zyngier <marc.zyngier@arm.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 07/10] arm64: kernel: Include _AC definition in page.h
Date: Tue, 1 Dec 2015 10:28:21 +0100 [thread overview]
Message-ID: <20151201092821.GB21222@amd> (raw)
In-Reply-To: <1448559168-8363-8-git-send-email-james.morse@arm.com>
On Thu 2015-11-26 17:32:45, James Morse wrote:
> page.h uses '_AC' in the definition of PAGE_SIZE, but doesn't include
> linux/const.h where this is defined. This produces build warnings when only
> asm/page.h is included by asm code.
>
> Signed-off-by: James Morse <james.morse@arm.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
> ---
> arch/arm64/include/asm/page.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/include/asm/page.h b/arch/arm64/include/asm/page.h
> index 9b2f5a9d019d..fbafd0ad16df 100644
> --- a/arch/arm64/include/asm/page.h
> +++ b/arch/arm64/include/asm/page.h
> @@ -19,6 +19,8 @@
> #ifndef __ASM_PAGE_H
> #define __ASM_PAGE_H
>
> +#include <linux/const.h>
> +
> /* PAGE_SHIFT determines the page size */
> /* CONT_SHIFT determines the number of pages which can be tracked together */
> #ifdef CONFIG_ARM64_64K_PAGES
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 07/10] arm64: kernel: Include _AC definition in page.h
Date: Tue, 1 Dec 2015 10:28:21 +0100 [thread overview]
Message-ID: <20151201092821.GB21222@amd> (raw)
In-Reply-To: <1448559168-8363-8-git-send-email-james.morse@arm.com>
On Thu 2015-11-26 17:32:45, James Morse wrote:
> page.h uses '_AC' in the definition of PAGE_SIZE, but doesn't include
> linux/const.h where this is defined. This produces build warnings when only
> asm/page.h is included by asm code.
>
> Signed-off-by: James Morse <james.morse@arm.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
> ---
> arch/arm64/include/asm/page.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/include/asm/page.h b/arch/arm64/include/asm/page.h
> index 9b2f5a9d019d..fbafd0ad16df 100644
> --- a/arch/arm64/include/asm/page.h
> +++ b/arch/arm64/include/asm/page.h
> @@ -19,6 +19,8 @@
> #ifndef __ASM_PAGE_H
> #define __ASM_PAGE_H
>
> +#include <linux/const.h>
> +
> /* PAGE_SHIFT determines the page size */
> /* CONT_SHIFT determines the number of pages which can be tracked together */
> #ifdef CONFIG_ARM64_64K_PAGES
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-12-01 9:28 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 17:32 [PATCH v3 00/10] arm64: kernel: Add support for hibernate/suspend-to-disk James Morse
2015-11-26 17:32 ` James Morse
2015-11-26 17:32 ` [PATCH v3 01/10] arm64: Fold proc-macros.S into assembler.h James Morse
2015-11-26 17:32 ` James Morse
2015-12-01 9:18 ` Pavel Machek
2015-12-01 9:18 ` Pavel Machek
2015-11-26 17:32 ` [PATCH v3 02/10] arm64: Convert hcalls to use HVC immediate value James Morse
2015-11-26 17:32 ` James Morse
2015-11-26 17:32 ` [PATCH v3 03/10] arm64: Add new hcall HVC_CALL_FUNC James Morse
2015-11-26 17:32 ` James Morse
2015-11-26 17:32 ` [PATCH v3 04/10] arm64: kvm: allows kvm cpu hotplug James Morse
2015-11-26 17:32 ` James Morse
2015-11-26 17:32 ` [PATCH v3 05/10] arm64: kernel: Rework finisher callback out of __cpu_suspend_enter() James Morse
2015-11-26 17:32 ` James Morse
2015-11-26 17:32 ` [PATCH v3 06/10] arm64: Change cpu_resume() to enable mmu early then access sleep_sp by va James Morse
2015-11-26 17:32 ` James Morse
2015-11-26 17:32 ` [PATCH v3 07/10] arm64: kernel: Include _AC definition in page.h James Morse
2015-11-26 17:32 ` James Morse
2015-12-01 9:28 ` Pavel Machek [this message]
2015-12-01 9:28 ` Pavel Machek
2015-11-26 17:32 ` [PATCH v3 08/10] arm64: Promote KERNEL_START/KERNEL_END definitions to a header file James Morse
2015-11-26 17:32 ` James Morse
2015-12-01 9:28 ` Pavel Machek
2015-12-01 9:28 ` Pavel Machek
2015-11-26 17:32 ` [PATCH v3 09/10] PM / Hibernate: Publish pages restored in-place to arch code James Morse
2015-11-26 17:32 ` James Morse
2015-12-03 12:09 ` Lorenzo Pieralisi
2015-12-03 12:09 ` Lorenzo Pieralisi
2015-12-04 16:26 ` James Morse
2015-12-04 16:26 ` James Morse
2015-12-05 9:35 ` Pavel Machek
2015-12-05 9:35 ` Pavel Machek
2015-12-07 11:28 ` James Morse
2015-12-07 11:28 ` James Morse
2015-12-08 8:19 ` Pavel Machek
2015-12-08 8:19 ` Pavel Machek
2015-12-16 9:55 ` James Morse
2015-12-16 9:55 ` James Morse
2015-11-26 17:32 ` [PATCH v3 10/10] arm64: kernel: Add support for hibernate/suspend-to-disk James Morse
2015-11-26 17:32 ` James Morse
2015-12-01 9:31 ` Pavel Machek
2015-12-01 9:31 ` Pavel Machek
2015-12-08 10:39 ` James Morse
2015-12-08 10:39 ` James Morse
2015-12-08 11:48 ` [PATCH] fixup! " James Morse
2015-12-08 11:48 ` James Morse
2015-12-15 17:42 ` [PATCH v3 10/10] " Catalin Marinas
2015-12-15 17:42 ` Catalin Marinas
2015-12-18 11:37 ` [ALT-PATCH v3 9/10] PM / Hibernate: Call flush_icache_range() on pages restored in-place James Morse
2015-12-18 11:37 ` James Morse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151201092821.GB21222@amd \
--to=pavel@ucw.cz \
--cc=catalin.marinas@arm.com \
--cc=geoff@infradead.org \
--cc=james.morse@arm.com \
--cc=kkang@intrinsyc.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
--cc=takahiro.akashi@linaro.org \
--cc=w.f@huawei.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.