From: jszhang@marvell.com (Jisheng Zhang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] usb: xhci: plat: Fix suspend/resume when the optional usb_phy exists
Date: Fri, 4 Dec 2015 22:15:16 +0800 [thread overview]
Message-ID: <20151204221516.1618d4ee@xhacker> (raw)
In-Reply-To: <1449238252-5630-4-git-send-email-jszhang@marvell.com>
cc linux-usb at vger.kernel.org
On Fri, 4 Dec 2015 22:10:48 +0800
Jisheng Zhang wrote:
> Commit 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support") adds the
> usb_phy for usb3, but it forgets to shutdown/init the usb_phy in the
> suspend/resume path. This patch fixes this issue by adding missing
> usb_phy related calls.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> drivers/usb/host/xhci-plat.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index a8c465a..cd49ae5 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -244,6 +244,7 @@ static int xhci_plat_suspend(struct device *dev)
> if (ret)
> return ret;
>
> + usb_phy_shutdown(xhci->shared_hcd->usb_phy);
> clk_disable_unprepare(xhci->clk);
>
> return ret;
> @@ -259,6 +260,10 @@ static int xhci_plat_resume(struct device *dev)
> if (ret)
> return ret;
>
> + ret = usb_phy_init(xhci->shared_hcd->usb_phy);
> + if (ret)
> + return ret;
> +
> return xhci_resume(xhci, 0);
> }
>
WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <jszhang@marvell.com>
To: <mathias.nyman@intel.com>, <gregkh@linuxfoundation.org>
Cc: <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-usb@vger.kernel.org>
Subject: Re: [PATCH 3/7] usb: xhci: plat: Fix suspend/resume when the optional usb_phy exists
Date: Fri, 4 Dec 2015 22:15:16 +0800 [thread overview]
Message-ID: <20151204221516.1618d4ee@xhacker> (raw)
In-Reply-To: <1449238252-5630-4-git-send-email-jszhang@marvell.com>
cc linux-usb@vger.kernel.org
On Fri, 4 Dec 2015 22:10:48 +0800
Jisheng Zhang wrote:
> Commit 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support") adds the
> usb_phy for usb3, but it forgets to shutdown/init the usb_phy in the
> suspend/resume path. This patch fixes this issue by adding missing
> usb_phy related calls.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> drivers/usb/host/xhci-plat.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index a8c465a..cd49ae5 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -244,6 +244,7 @@ static int xhci_plat_suspend(struct device *dev)
> if (ret)
> return ret;
>
> + usb_phy_shutdown(xhci->shared_hcd->usb_phy);
> clk_disable_unprepare(xhci->clk);
>
> return ret;
> @@ -259,6 +260,10 @@ static int xhci_plat_resume(struct device *dev)
> if (ret)
> return ret;
>
> + ret = usb_phy_init(xhci->shared_hcd->usb_phy);
> + if (ret)
> + return ret;
> +
> return xhci_resume(xhci, 0);
> }
>
next prev parent reply other threads:[~2015-12-04 14:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 14:10 [PATCH 0/7] usb: xhci-plat: support generic PHY and vbus regulator Jisheng Zhang
2015-12-04 14:10 ` Jisheng Zhang
2015-12-04 14:10 ` [PATCH 1/7] usb: xhci: plat: Fix suspend/resume when the optional clk exists Jisheng Zhang
2015-12-04 14:10 ` Jisheng Zhang
2015-12-04 14:13 ` Jisheng Zhang
2015-12-04 14:13 ` Jisheng Zhang
2015-12-04 14:10 ` [PATCH 2/7] usb: xhci: plat: attach the usb_phy to the correct hcd Jisheng Zhang
2015-12-04 14:10 ` Jisheng Zhang
2015-12-04 14:14 ` Jisheng Zhang
2015-12-04 14:14 ` Jisheng Zhang
2015-12-04 14:10 ` [PATCH 3/7] usb: xhci: plat: Fix suspend/resume when the optional usb_phy exists Jisheng Zhang
2015-12-04 14:10 ` Jisheng Zhang
2015-12-04 14:15 ` Jisheng Zhang [this message]
2015-12-04 14:15 ` Jisheng Zhang
2015-12-04 14:10 ` [PATCH 4/7] usb: xhci: plat: sort the headers in alphabetic order Jisheng Zhang
2015-12-04 14:10 ` Jisheng Zhang
2015-12-04 14:18 ` Jisheng Zhang
2015-12-04 14:18 ` Jisheng Zhang
2015-12-04 14:10 ` [PATCH 5/7] usb: xhci: plat: Remove checks for optional clock in error/remove path Jisheng Zhang
2015-12-04 14:10 ` Jisheng Zhang
2015-12-04 14:19 ` Jisheng Zhang
2015-12-04 14:19 ` Jisheng Zhang
2015-12-04 14:10 ` [PATCH 6/7] usb: xhci: plat: add generic PHY support Jisheng Zhang
2015-12-04 14:10 ` Jisheng Zhang
2015-12-04 14:20 ` Jisheng Zhang
2015-12-04 14:20 ` Jisheng Zhang
2015-12-04 14:10 ` [PATCH 7/7] usb: xhci: plat: add vbus regulator control Jisheng Zhang
2015-12-04 14:10 ` Jisheng Zhang
2015-12-04 14:20 ` Jisheng Zhang
2015-12-04 14:20 ` Jisheng Zhang
2015-12-04 14:13 ` [PATCH 0/7] usb: xhci-plat: support generic PHY and vbus regulator Jisheng Zhang
2015-12-04 14:13 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204221516.1618d4ee@xhacker \
--to=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.