From: jszhang@marvell.com (Jisheng Zhang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/7] usb: xhci: plat: add vbus regulator control
Date: Fri, 4 Dec 2015 22:20:39 +0800 [thread overview]
Message-ID: <20151204222039.4d93537f@xhacker> (raw)
In-Reply-To: <1449238252-5630-8-git-send-email-jszhang@marvell.com>
cc linux-usb at vger.kernel.org
On Fri, 4 Dec 2015 22:10:52 +0800
Jisheng Zhang wrote:
> The Marvell BG4CT STB board has board level vbus control through gpio.
> This patch adds the vbus regulator control to support this board.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> drivers/usb/host/xhci-plat.c | 39 ++++++++++++++++++++++++++++++++++++++-
> drivers/usb/host/xhci.h | 2 ++
> 2 files changed, 40 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index bb972a6..9bf44569 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -18,6 +18,7 @@
> #include <linux/of.h>
> #include <linux/phy/phy.h>
> #include <linux/platform_device.h>
> +#include <linux/regulator/consumer.h>
> #include <linux/slab.h>
> #include <linux/usb/phy.h>
> #include <linux/usb/xhci_pdriver.h>
> @@ -116,6 +117,7 @@ static int xhci_plat_probe(struct platform_device *pdev)
> struct clk *clk;
> struct usb_phy *usb_phy;
> struct phy *phy;
> + struct regulator *vbus;
> int ret;
> int irq;
>
> @@ -179,14 +181,31 @@ static int xhci_plat_probe(struct platform_device *pdev)
>
> device_wakeup_enable(hcd->self.controller);
>
> + vbus = devm_regulator_get(&pdev->dev, "vbus");
> + if (PTR_ERR(vbus) == -ENODEV) {
> + vbus = NULL;
> + } else if (IS_ERR(vbus)) {
> + ret = PTR_ERR(vbus);
> + goto disable_clk;
> + } else {
> + ret = regulator_enable(vbus);
> + if (ret) {
> + dev_err(&pdev->dev,
> + "failed to enable usb vbus regulator: %d\n",
> + ret);
> + goto disable_clk;
> + }
> + }
> +
> xhci = hcd_to_xhci(hcd);
> xhci->clk = clk;
> + xhci->vbus = vbus;
> xhci->main_hcd = hcd;
> xhci->shared_hcd = usb_create_shared_hcd(driver, &pdev->dev,
> dev_name(&pdev->dev), hcd);
> if (!xhci->shared_hcd) {
> ret = -ENOMEM;
> - goto disable_clk;
> + goto disable_vbus;
> }
>
> if ((node && of_property_read_bool(node, "usb3-lpm-capable")) ||
> @@ -254,6 +273,10 @@ disable_usb2_phy:
> put_usb3_hcd:
> usb_put_hcd(xhci->shared_hcd);
>
> +disable_vbus:
> + if (!vbus)
> + regulator_disable(vbus);
> +
> disable_clk:
> clk_disable_unprepare(clk);
>
> @@ -268,6 +291,7 @@ static int xhci_plat_remove(struct platform_device *dev)
> struct usb_hcd *hcd = platform_get_drvdata(dev);
> struct xhci_hcd *xhci = hcd_to_xhci(hcd);
> struct clk *clk = xhci->clk;
> + struct regulator *vbus = xhci->vbus;
>
> usb_remove_hcd(xhci->shared_hcd);
> xhci_plat_phy_exit(xhci->shared_hcd);
> @@ -278,6 +302,9 @@ static int xhci_plat_remove(struct platform_device *dev)
> clk_disable_unprepare(clk);
> usb_put_hcd(hcd);
>
> + if (!vbus)
> + regulator_disable(vbus);
> +
> return 0;
> }
>
> @@ -287,6 +314,7 @@ static int xhci_plat_suspend(struct device *dev)
> int ret;
> struct usb_hcd *hcd = dev_get_drvdata(dev);
> struct xhci_hcd *xhci = hcd_to_xhci(hcd);
> + struct regulator *vbus = xhci->vbus;
>
> /*
> * xhci_suspend() needs `do_wakeup` to know whether host is allowed
> @@ -303,6 +331,8 @@ static int xhci_plat_suspend(struct device *dev)
> xhci_plat_phy_exit(xhci->shared_hcd);
> xhci_plat_phy_exit(hcd);
> clk_disable_unprepare(xhci->clk);
> + if (!vbus)
> + ret = regulator_disable(vbus);
>
> return ret;
> }
> @@ -312,11 +342,18 @@ static int xhci_plat_resume(struct device *dev)
> int ret;
> struct usb_hcd *hcd = dev_get_drvdata(dev);
> struct xhci_hcd *xhci = hcd_to_xhci(hcd);
> + struct regulator *vbus = xhci->vbus;
>
> ret = clk_prepare_enable(xhci->clk);
> if (ret)
> return ret;
>
> + if (!vbus) {
> + ret = regulator_enable(vbus);
> + if (ret)
> + return ret;
> + }
> +
> ret = xhci_plat_phy_init(hcd);
> if (ret)
> return ret;
> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
> index 0b94512..1355d2a 100644
> --- a/drivers/usb/host/xhci.h
> +++ b/drivers/usb/host/xhci.h
> @@ -1541,6 +1541,8 @@ struct xhci_hcd {
> struct msix_entry *msix_entries;
> /* optional clock */
> struct clk *clk;
> + /* optional regulator */
> + struct regulator *vbus;
> /* data structures */
> struct xhci_device_context_array *dcbaa;
> struct xhci_ring *cmd_ring;
WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <jszhang@marvell.com>
To: <mathias.nyman@intel.com>, <gregkh@linuxfoundation.org>
Cc: <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-usb@vger.kernel.org>
Subject: Re: [PATCH 7/7] usb: xhci: plat: add vbus regulator control
Date: Fri, 4 Dec 2015 22:20:39 +0800 [thread overview]
Message-ID: <20151204222039.4d93537f@xhacker> (raw)
In-Reply-To: <1449238252-5630-8-git-send-email-jszhang@marvell.com>
cc linux-usb@vger.kernel.org
On Fri, 4 Dec 2015 22:10:52 +0800
Jisheng Zhang wrote:
> The Marvell BG4CT STB board has board level vbus control through gpio.
> This patch adds the vbus regulator control to support this board.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> drivers/usb/host/xhci-plat.c | 39 ++++++++++++++++++++++++++++++++++++++-
> drivers/usb/host/xhci.h | 2 ++
> 2 files changed, 40 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index bb972a6..9bf44569 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -18,6 +18,7 @@
> #include <linux/of.h>
> #include <linux/phy/phy.h>
> #include <linux/platform_device.h>
> +#include <linux/regulator/consumer.h>
> #include <linux/slab.h>
> #include <linux/usb/phy.h>
> #include <linux/usb/xhci_pdriver.h>
> @@ -116,6 +117,7 @@ static int xhci_plat_probe(struct platform_device *pdev)
> struct clk *clk;
> struct usb_phy *usb_phy;
> struct phy *phy;
> + struct regulator *vbus;
> int ret;
> int irq;
>
> @@ -179,14 +181,31 @@ static int xhci_plat_probe(struct platform_device *pdev)
>
> device_wakeup_enable(hcd->self.controller);
>
> + vbus = devm_regulator_get(&pdev->dev, "vbus");
> + if (PTR_ERR(vbus) == -ENODEV) {
> + vbus = NULL;
> + } else if (IS_ERR(vbus)) {
> + ret = PTR_ERR(vbus);
> + goto disable_clk;
> + } else {
> + ret = regulator_enable(vbus);
> + if (ret) {
> + dev_err(&pdev->dev,
> + "failed to enable usb vbus regulator: %d\n",
> + ret);
> + goto disable_clk;
> + }
> + }
> +
> xhci = hcd_to_xhci(hcd);
> xhci->clk = clk;
> + xhci->vbus = vbus;
> xhci->main_hcd = hcd;
> xhci->shared_hcd = usb_create_shared_hcd(driver, &pdev->dev,
> dev_name(&pdev->dev), hcd);
> if (!xhci->shared_hcd) {
> ret = -ENOMEM;
> - goto disable_clk;
> + goto disable_vbus;
> }
>
> if ((node && of_property_read_bool(node, "usb3-lpm-capable")) ||
> @@ -254,6 +273,10 @@ disable_usb2_phy:
> put_usb3_hcd:
> usb_put_hcd(xhci->shared_hcd);
>
> +disable_vbus:
> + if (!vbus)
> + regulator_disable(vbus);
> +
> disable_clk:
> clk_disable_unprepare(clk);
>
> @@ -268,6 +291,7 @@ static int xhci_plat_remove(struct platform_device *dev)
> struct usb_hcd *hcd = platform_get_drvdata(dev);
> struct xhci_hcd *xhci = hcd_to_xhci(hcd);
> struct clk *clk = xhci->clk;
> + struct regulator *vbus = xhci->vbus;
>
> usb_remove_hcd(xhci->shared_hcd);
> xhci_plat_phy_exit(xhci->shared_hcd);
> @@ -278,6 +302,9 @@ static int xhci_plat_remove(struct platform_device *dev)
> clk_disable_unprepare(clk);
> usb_put_hcd(hcd);
>
> + if (!vbus)
> + regulator_disable(vbus);
> +
> return 0;
> }
>
> @@ -287,6 +314,7 @@ static int xhci_plat_suspend(struct device *dev)
> int ret;
> struct usb_hcd *hcd = dev_get_drvdata(dev);
> struct xhci_hcd *xhci = hcd_to_xhci(hcd);
> + struct regulator *vbus = xhci->vbus;
>
> /*
> * xhci_suspend() needs `do_wakeup` to know whether host is allowed
> @@ -303,6 +331,8 @@ static int xhci_plat_suspend(struct device *dev)
> xhci_plat_phy_exit(xhci->shared_hcd);
> xhci_plat_phy_exit(hcd);
> clk_disable_unprepare(xhci->clk);
> + if (!vbus)
> + ret = regulator_disable(vbus);
>
> return ret;
> }
> @@ -312,11 +342,18 @@ static int xhci_plat_resume(struct device *dev)
> int ret;
> struct usb_hcd *hcd = dev_get_drvdata(dev);
> struct xhci_hcd *xhci = hcd_to_xhci(hcd);
> + struct regulator *vbus = xhci->vbus;
>
> ret = clk_prepare_enable(xhci->clk);
> if (ret)
> return ret;
>
> + if (!vbus) {
> + ret = regulator_enable(vbus);
> + if (ret)
> + return ret;
> + }
> +
> ret = xhci_plat_phy_init(hcd);
> if (ret)
> return ret;
> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
> index 0b94512..1355d2a 100644
> --- a/drivers/usb/host/xhci.h
> +++ b/drivers/usb/host/xhci.h
> @@ -1541,6 +1541,8 @@ struct xhci_hcd {
> struct msix_entry *msix_entries;
> /* optional clock */
> struct clk *clk;
> + /* optional regulator */
> + struct regulator *vbus;
> /* data structures */
> struct xhci_device_context_array *dcbaa;
> struct xhci_ring *cmd_ring;
next prev parent reply other threads:[~2015-12-04 14:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 14:10 [PATCH 0/7] usb: xhci-plat: support generic PHY and vbus regulator Jisheng Zhang
2015-12-04 14:10 ` Jisheng Zhang
2015-12-04 14:10 ` [PATCH 1/7] usb: xhci: plat: Fix suspend/resume when the optional clk exists Jisheng Zhang
2015-12-04 14:10 ` Jisheng Zhang
2015-12-04 14:13 ` Jisheng Zhang
2015-12-04 14:13 ` Jisheng Zhang
2015-12-04 14:10 ` [PATCH 2/7] usb: xhci: plat: attach the usb_phy to the correct hcd Jisheng Zhang
2015-12-04 14:10 ` Jisheng Zhang
2015-12-04 14:14 ` Jisheng Zhang
2015-12-04 14:14 ` Jisheng Zhang
2015-12-04 14:10 ` [PATCH 3/7] usb: xhci: plat: Fix suspend/resume when the optional usb_phy exists Jisheng Zhang
2015-12-04 14:10 ` Jisheng Zhang
2015-12-04 14:15 ` Jisheng Zhang
2015-12-04 14:15 ` Jisheng Zhang
2015-12-04 14:10 ` [PATCH 4/7] usb: xhci: plat: sort the headers in alphabetic order Jisheng Zhang
2015-12-04 14:10 ` Jisheng Zhang
2015-12-04 14:18 ` Jisheng Zhang
2015-12-04 14:18 ` Jisheng Zhang
2015-12-04 14:10 ` [PATCH 5/7] usb: xhci: plat: Remove checks for optional clock in error/remove path Jisheng Zhang
2015-12-04 14:10 ` Jisheng Zhang
2015-12-04 14:19 ` Jisheng Zhang
2015-12-04 14:19 ` Jisheng Zhang
2015-12-04 14:10 ` [PATCH 6/7] usb: xhci: plat: add generic PHY support Jisheng Zhang
2015-12-04 14:10 ` Jisheng Zhang
2015-12-04 14:20 ` Jisheng Zhang
2015-12-04 14:20 ` Jisheng Zhang
2015-12-04 14:10 ` [PATCH 7/7] usb: xhci: plat: add vbus regulator control Jisheng Zhang
2015-12-04 14:10 ` Jisheng Zhang
2015-12-04 14:20 ` Jisheng Zhang [this message]
2015-12-04 14:20 ` Jisheng Zhang
2015-12-04 14:13 ` [PATCH 0/7] usb: xhci-plat: support generic PHY and vbus regulator Jisheng Zhang
2015-12-04 14:13 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204222039.4d93537f@xhacker \
--to=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.