From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: <linux-mtd@lists.infradead.org>,
Linus Walleij <linus.walleij@linaro.org>,
Simon Arlott <simon@fire.lp0.eu>
Subject: Re: [PATCH v2 2/6] mtd: partitions: make parsers return 'const' partition arrays
Date: Sat, 5 Dec 2015 00:58:19 +0100 [thread overview]
Message-ID: <20151205005819.69e42a5e@bbrezillon> (raw)
In-Reply-To: <1449271518-118900-3-git-send-email-computersforpeace@gmail.com>
On Fri, 4 Dec 2015 15:25:14 -0800
Brian Norris <computersforpeace@gmail.com> wrote:
> We only want to modify these arrays inside the parser "drivers", so the
> drivers should construct them however they like, then return them as
> immutable arrays.
>
> This will make other refactorings easier.
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> New in v2
>
> drivers/mtd/afs.c | 2 +-
> drivers/mtd/ar7part.c | 2 +-
> drivers/mtd/bcm47xxpart.c | 2 +-
> drivers/mtd/bcm63xxpart.c | 2 +-
> drivers/mtd/cmdlinepart.c | 2 +-
> drivers/mtd/ofpart.c | 4 ++--
> drivers/mtd/redboot.c | 2 +-
> include/linux/mtd/partitions.h | 2 +-
> 8 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/mtd/afs.c b/drivers/mtd/afs.c
> index e02dae3b739b..d61b7edfc938 100644
> --- a/drivers/mtd/afs.c
> +++ b/drivers/mtd/afs.c
> @@ -162,7 +162,7 @@ afs_read_iis_v1(struct mtd_info *mtd, struct image_info_v1 *iis, u_int ptr)
> }
>
> static int parse_afs_partitions(struct mtd_info *mtd,
> - struct mtd_partition **pparts,
> + const struct mtd_partition **pparts,
> struct mtd_part_parser_data *data)
> {
> struct mtd_partition *parts;
> diff --git a/drivers/mtd/ar7part.c b/drivers/mtd/ar7part.c
> index 9203b96fd789..90575deff0ae 100644
> --- a/drivers/mtd/ar7part.c
> +++ b/drivers/mtd/ar7part.c
> @@ -43,7 +43,7 @@ struct ar7_bin_rec {
> };
>
> static int create_mtd_partitions(struct mtd_info *master,
> - struct mtd_partition **pparts,
> + const struct mtd_partition **pparts,
> struct mtd_part_parser_data *data)
> {
> struct ar7_bin_rec header;
> diff --git a/drivers/mtd/bcm47xxpart.c b/drivers/mtd/bcm47xxpart.c
> index 92a6dd18198b..8282f47bcf5d 100644
> --- a/drivers/mtd/bcm47xxpart.c
> +++ b/drivers/mtd/bcm47xxpart.c
> @@ -82,7 +82,7 @@ out_default:
> }
>
> static int bcm47xxpart_parse(struct mtd_info *master,
> - struct mtd_partition **pparts,
> + const struct mtd_partition **pparts,
> struct mtd_part_parser_data *data)
> {
> struct mtd_partition *parts;
> diff --git a/drivers/mtd/bcm63xxpart.c b/drivers/mtd/bcm63xxpart.c
> index cf02135320bc..440936998593 100644
> --- a/drivers/mtd/bcm63xxpart.c
> +++ b/drivers/mtd/bcm63xxpart.c
> @@ -68,7 +68,7 @@ static int bcm63xx_detect_cfe(struct mtd_info *master)
> }
>
> static int bcm63xx_parse_cfe_partitions(struct mtd_info *master,
> - struct mtd_partition **pparts,
> + const struct mtd_partition **pparts,
> struct mtd_part_parser_data *data)
> {
> /* CFE, NVRAM and global Linux are always present */
> diff --git a/drivers/mtd/cmdlinepart.c b/drivers/mtd/cmdlinepart.c
> index 420489864bc2..fbd5affc0acf 100644
> --- a/drivers/mtd/cmdlinepart.c
> +++ b/drivers/mtd/cmdlinepart.c
> @@ -304,7 +304,7 @@ static int mtdpart_setup_real(char *s)
> * the first one in the chain if a NULL mtd_id is passed in.
> */
> static int parse_cmdline_partitions(struct mtd_info *master,
> - struct mtd_partition **pparts,
> + const struct mtd_partition **pparts,
> struct mtd_part_parser_data *data)
> {
> unsigned long long offset;
> diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c
> index 4800fecaf8cf..8a027a71e662 100644
> --- a/drivers/mtd/ofpart.c
> +++ b/drivers/mtd/ofpart.c
> @@ -26,7 +26,7 @@ static bool node_has_compatible(struct device_node *pp)
> }
>
> static int parse_ofpart_partitions(struct mtd_info *master,
> - struct mtd_partition **pparts,
> + const struct mtd_partition **pparts,
> struct mtd_part_parser_data *data)
> {
> struct mtd_partition *parts;
> @@ -137,7 +137,7 @@ static struct mtd_part_parser ofpart_parser = {
> };
>
> static int parse_ofoldpart_partitions(struct mtd_info *master,
> - struct mtd_partition **pparts,
> + const struct mtd_partition **pparts,
> struct mtd_part_parser_data *data)
> {
> struct mtd_partition *parts;
> diff --git a/drivers/mtd/redboot.c b/drivers/mtd/redboot.c
> index 11c3447eb8ff..7623ac5fc586 100644
> --- a/drivers/mtd/redboot.c
> +++ b/drivers/mtd/redboot.c
> @@ -57,7 +57,7 @@ static inline int redboot_checksum(struct fis_image_desc *img)
> }
>
> static int parse_redboot_partitions(struct mtd_info *master,
> - struct mtd_partition **pparts,
> + const struct mtd_partition **pparts,
> struct mtd_part_parser_data *data)
> {
> int nrparts = 0;
> diff --git a/include/linux/mtd/partitions.h b/include/linux/mtd/partitions.h
> index d002d9b5d797..6185536daacc 100644
> --- a/include/linux/mtd/partitions.h
> +++ b/include/linux/mtd/partitions.h
> @@ -69,7 +69,7 @@ struct mtd_part_parser {
> struct list_head list;
> struct module *owner;
> const char *name;
> - int (*parse_fn)(struct mtd_info *, struct mtd_partition **,
> + int (*parse_fn)(struct mtd_info *, const struct mtd_partition **,
> struct mtd_part_parser_data *);
> };
>
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-12-04 23:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 23:25 [PATCH v2 0/6] mtd: partitions: support cleanup callback for parsers Brian Norris
2015-12-04 23:25 ` [PATCH v2 1/6] mtd: ofpart: assign return argument exactly once Brian Norris
2015-12-04 23:57 ` Boris Brezillon
2015-12-04 23:25 ` [PATCH v2 2/6] mtd: partitions: make parsers return 'const' partition arrays Brian Norris
2015-12-04 23:58 ` Boris Brezillon [this message]
2015-12-04 23:25 ` [PATCH v2 3/6] mtd: partitions: rename MTD parser get/put Brian Norris
2015-12-05 0:00 ` Boris Brezillon
2015-12-05 0:02 ` Brian Norris
2015-12-04 23:25 ` [PATCH v2 4/6] mtd: partitions: remove kmemdup() Brian Norris
2015-12-05 0:00 ` Boris Brezillon
2015-12-04 23:25 ` [PATCH v2 5/6] mtd: partitions: pass around 'mtd_partitions' wrapper struct Brian Norris
2015-12-05 0:30 ` Boris Brezillon
2015-12-05 0:41 ` Boris Brezillon
2015-12-05 1:45 ` Brian Norris
2015-12-05 4:18 ` Brian Norris
2015-12-05 8:18 ` Boris Brezillon
2015-12-05 8:27 ` Boris Brezillon
2015-12-04 23:25 ` [PATCH v2 6/6] mtd: partitions: support a cleanup callback for parsers Brian Norris
2015-12-05 0:33 ` Boris Brezillon
2015-12-09 18:24 ` [PATCH v3 " Brian Norris
2015-12-09 21:46 ` Boris Brezillon
2015-12-09 23:00 ` Brian Norris
2015-12-09 18:25 ` [PATCH v2 0/6] mtd: partitions: support " Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151205005819.69e42a5e@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-mtd@lists.infradead.org \
--cc=simon@fire.lp0.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.