From: Brian Norris <computersforpeace@gmail.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: linux-mtd@lists.infradead.org,
Linus Walleij <linus.walleij@linaro.org>,
Simon Arlott <simon@fire.lp0.eu>
Subject: Re: [PATCH v3 6/6] mtd: partitions: support a cleanup callback for parsers
Date: Wed, 9 Dec 2015 15:00:55 -0800 [thread overview]
Message-ID: <20151209230055.GC144338@google.com> (raw)
In-Reply-To: <20151209224650.47d644d8@bbrezillon>
On Wed, Dec 09, 2015 at 10:46:50PM +0100, Boris Brezillon wrote:
> On Wed, 9 Dec 2015 10:24:03 -0800
> Brian Norris <computersforpeace@gmail.com> wrote:
>
> > If partition parsers need to clean up their resources, we shouldn't
> > assume that all memory will fit in a single kmalloc() that the caller
> > can kfree(). We should allow the parser to provide a proper cleanup
> > routine.
> >
> > Note that this means we need to keep a hold on the parser's module for a
> > bit longer, and release it later with mtd_part_parser_put().
> >
> > Alongside this, define a default callback that we'll automatically use
> > if the parser doesn't provide one, so we can still retain the old
> > behavior.
> >
> > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
>
> Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Applied, thanks!
next prev parent reply other threads:[~2015-12-09 23:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 23:25 [PATCH v2 0/6] mtd: partitions: support cleanup callback for parsers Brian Norris
2015-12-04 23:25 ` [PATCH v2 1/6] mtd: ofpart: assign return argument exactly once Brian Norris
2015-12-04 23:57 ` Boris Brezillon
2015-12-04 23:25 ` [PATCH v2 2/6] mtd: partitions: make parsers return 'const' partition arrays Brian Norris
2015-12-04 23:58 ` Boris Brezillon
2015-12-04 23:25 ` [PATCH v2 3/6] mtd: partitions: rename MTD parser get/put Brian Norris
2015-12-05 0:00 ` Boris Brezillon
2015-12-05 0:02 ` Brian Norris
2015-12-04 23:25 ` [PATCH v2 4/6] mtd: partitions: remove kmemdup() Brian Norris
2015-12-05 0:00 ` Boris Brezillon
2015-12-04 23:25 ` [PATCH v2 5/6] mtd: partitions: pass around 'mtd_partitions' wrapper struct Brian Norris
2015-12-05 0:30 ` Boris Brezillon
2015-12-05 0:41 ` Boris Brezillon
2015-12-05 1:45 ` Brian Norris
2015-12-05 4:18 ` Brian Norris
2015-12-05 8:18 ` Boris Brezillon
2015-12-05 8:27 ` Boris Brezillon
2015-12-04 23:25 ` [PATCH v2 6/6] mtd: partitions: support a cleanup callback for parsers Brian Norris
2015-12-05 0:33 ` Boris Brezillon
2015-12-09 18:24 ` [PATCH v3 " Brian Norris
2015-12-09 21:46 ` Boris Brezillon
2015-12-09 23:00 ` Brian Norris [this message]
2015-12-09 18:25 ` [PATCH v2 0/6] mtd: partitions: support " Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209230055.GC144338@google.com \
--to=computersforpeace@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=linus.walleij@linaro.org \
--cc=linux-mtd@lists.infradead.org \
--cc=simon@fire.lp0.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.