Re: [PATCH v2 0/6] mtd: partitions: support cleanup callback for parsers

[Brian Norris <computersforpeace@gmail.com>]

On Fri, Dec 04, 2015 at 03:25:12PM -0800, Brian Norris wrote:
> Hi,
> 
> Here's v2, which should address the comments made on v1.
> 
> Currently, we assume that all of the resources used by partition parsers can be
> cleaned up with a single kfree(), but that can be burdensome to work around.
> This series (particularly, patch 6) supports a cleanup() callback for parsers.
> 
> v1 -> v2:
>  * add "mtd_partitions" struct to hold info about the array of parsed partitions
>  * const-ify some arguments, which requires some small refactoring of the
>    existing partitions parsers
>  * remove the kmemdup() in mtd_device_parse_register()
>  * provide default cleanup routine for parsers that don't have one (all
>    parsers, ATM)
>  * put more common logic in mtd_part_parser_cleanup(), to avoid making the
>    caller worry about some of the reference counting
>  * (hopefully) less convoluted error handling in mtd_device_parse_register()
> 
> Brian
> 
> Brian Norris (6):
>   mtd: ofpart: assign return argument exactly once
>   mtd: partitions: make parsers return 'const' partition arrays
>   mtd: partitions: rename MTD parser get/put
>   mtd: partitions: remove kmemdup()
>   mtd: partitions: pass around 'mtd_partitions' wrapper struct

Pushed patch 1-5 to l2-mtd.git.

>   mtd: partitions: support a cleanup callback for parsers

Sent v3 of patch 6, with a small change.

Brian

> 
>  drivers/mtd/afs.c              |  2 +-
>  drivers/mtd/ar7part.c          |  2 +-
>  drivers/mtd/bcm47xxpart.c      |  2 +-
>  drivers/mtd/bcm63xxpart.c      |  2 +-
>  drivers/mtd/cmdlinepart.c      |  2 +-
>  drivers/mtd/mtdcore.c          | 39 +++++++++++++++-------------
>  drivers/mtd/mtdcore.h          |  7 ++++-
>  drivers/mtd/mtdpart.c          | 59 +++++++++++++++++++++++++++++++++---------
>  drivers/mtd/ofpart.c           | 39 +++++++++++++++-------------
>  drivers/mtd/redboot.c          |  2 +-
>  include/linux/mtd/partitions.h | 10 ++++++-
>  11 files changed, 110 insertions(+), 56 deletions(-)
> 
> -- 
> 2.6.0.rc2.230.g3dd15c0
>