All of lore.kernel.org
 help / color / mirror / Atom feed
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/8] ARM: dts: imx7d: cl-som-imx7: add basic module support
Date: Tue, 8 Dec 2015 09:14:01 -0600	[thread overview]
Message-ID: <20151208151401.GA20042@rob-hp-laptop> (raw)
In-Reply-To: <1449472479-2521-2-git-send-email-ilya@compulab.co.il>

On Mon, Dec 07, 2015 at 09:14:32AM +0200, Ilya Ledvich wrote:
> CL-SOM-iMX7 is a miniature System-on-Module (SoM) based on
> Freescale i.MX7 System-on-Chip family.
> 
> http://www.compulab.co.il/products/computer-on-modules/cl-som-imx7-freescale-i-mx-7-system-on-module/
> 
> Add basic DT support for standalone module (without a carrier board):
> 
> * Memory configuration
> * I2C2 bus
> * PMIC
> * UART1
> 
> Signed-off-by: Ilya Ledvich <ilya@compulab.co.il>
> Acked-by: Igor Grinberg <grinberg@compulab.co.il>

One nit, otherwise:

Acked-by: Rob Herring <robh@kernel.org>

> +&i2c2 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_i2c2>;
> +	status = "okay";
> +
> +	pmic: pfuze3000 at 08 {

Use generic node names: "pmic at 8"

> +		compatible = "fsl,pfuze3000";
> +		reg = <0x08>;

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Ilya Ledvich <ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
Cc: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Igor Grinberg <grinberg-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
Subject: Re: [PATCH 1/8] ARM: dts: imx7d: cl-som-imx7: add basic module support
Date: Tue, 8 Dec 2015 09:14:01 -0600	[thread overview]
Message-ID: <20151208151401.GA20042@rob-hp-laptop> (raw)
In-Reply-To: <1449472479-2521-2-git-send-email-ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>

On Mon, Dec 07, 2015 at 09:14:32AM +0200, Ilya Ledvich wrote:
> CL-SOM-iMX7 is a miniature System-on-Module (SoM) based on
> Freescale i.MX7 System-on-Chip family.
> 
> http://www.compulab.co.il/products/computer-on-modules/cl-som-imx7-freescale-i-mx-7-system-on-module/
> 
> Add basic DT support for standalone module (without a carrier board):
> 
> * Memory configuration
> * I2C2 bus
> * PMIC
> * UART1
> 
> Signed-off-by: Ilya Ledvich <ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
> Acked-by: Igor Grinberg <grinberg-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>

One nit, otherwise:

Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

> +&i2c2 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_i2c2>;
> +	status = "okay";
> +
> +	pmic: pfuze3000@08 {

Use generic node names: "pmic@8"

> +		compatible = "fsl,pfuze3000";
> +		reg = <0x08>;
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-12-08 15:14 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-07  7:14 [PATCH 0/8] Add support for CL-SOM-iMX7 and SBC-iMX7 Ilya Ledvich
2015-12-07  7:14 ` Ilya Ledvich
2015-12-07  7:14 ` [PATCH 1/8] ARM: dts: imx7d: cl-som-imx7: add basic module support Ilya Ledvich
2015-12-07  7:14   ` Ilya Ledvich
2015-12-08 15:14   ` Rob Herring [this message]
2015-12-08 15:14     ` Rob Herring
2015-12-10 14:01     ` [PATCH v2] " Igor Grinberg
2015-12-10 14:01       ` Igor Grinberg
2015-12-14  2:43       ` Shawn Guo
2015-12-14  2:43         ` Shawn Guo
2015-12-16 14:01         ` Igor Grinberg
2015-12-16 14:01           ` Igor Grinberg
2015-12-21  6:36           ` Shawn Guo
2015-12-21  6:36             ` Shawn Guo
2015-12-21  8:07             ` Igor Grinberg
2015-12-21  8:07               ` Igor Grinberg
2015-12-21 13:54               ` Shawn Guo
2015-12-21 13:54                 ` Shawn Guo
2015-12-21 13:59               ` Shawn Guo
2015-12-21 13:59                 ` Shawn Guo
2015-12-22  7:38                 ` Igor Grinberg
2015-12-22  7:38                   ` Igor Grinberg
2015-12-07  7:14 ` [PATCH 2/8] ARM: dts: imx7d: cl-som-imx7: add usb otg support Ilya Ledvich
2015-12-07  7:14   ` Ilya Ledvich
2015-12-07  7:14 ` [PATCH 3/8] ARM: dts: imx7d: cl-som-imx7: add eMMC support Ilya Ledvich
2015-12-07  7:14   ` Ilya Ledvich
2015-12-07  7:14 ` [PATCH 4/8] ARM: dts: imx7d: cl-som-imx7: add fec1 support Ilya Ledvich
2015-12-07  7:14   ` Ilya Ledvich
2015-12-07  7:14 ` [PATCH 5/8] ARM: dts: imx7d: cl-som-imx7: add eeprom support Ilya Ledvich
2015-12-07  7:14   ` Ilya Ledvich
2015-12-07  7:14 ` [PATCH 6/8] ARM: dts: imx7d: cl-som-imx7: add gpio extender support Ilya Ledvich
2015-12-07  7:14   ` Ilya Ledvich
2015-12-07  7:14 ` [PATCH 7/8] ARM: dts: imx7d: cl-som-imx7: add fec2 support Ilya Ledvich
2015-12-07  7:14   ` Ilya Ledvich
2015-12-07  7:14 ` [PATCH 8/8] ARM: dts: imx7d: sbc-imx7: add basic board support Ilya Ledvich
2015-12-07  7:14   ` Ilya Ledvich
2015-12-08 15:16   ` Rob Herring
2015-12-08 15:16     ` Rob Herring
2015-12-14  2:47 ` [PATCH 0/8] Add support for CL-SOM-iMX7 and SBC-iMX7 Shawn Guo
2015-12-14  2:47   ` Shawn Guo
2015-12-16 14:09   ` Igor Grinberg
2015-12-16 14:09     ` Igor Grinberg
2015-12-21  6:41     ` Shawn Guo
2015-12-21  6:41       ` Shawn Guo
2015-12-21  7:54       ` Igor Grinberg
2015-12-21  7:54         ` Igor Grinberg
2015-12-22  8:15 ` [PATCH v2 0/2] " Ilya Ledvich
2015-12-22  8:15   ` Ilya Ledvich
2015-12-22  8:15   ` [PATCH v2 1/2] ARM: dts: imx7d: cl-som-imx7: add basic module support Ilya Ledvich
2015-12-22  8:15     ` Ilya Ledvich
2015-12-22 12:17     ` Shawn Guo
2015-12-22 12:17       ` Shawn Guo
2015-12-22 14:07       ` Igor Grinberg
2015-12-22 14:07         ` Igor Grinberg
2015-12-22  8:15   ` [PATCH v2 2/2] ARM: dts: imx7d: sbc-imx7: add basic board support Ilya Ledvich
2015-12-22  8:15     ` Ilya Ledvich
2015-12-22 12:19     ` Shawn Guo
2015-12-22 12:19       ` Shawn Guo
2015-12-22 14:13       ` Igor Grinberg
2015-12-22 14:13         ` Igor Grinberg
2015-12-22 12:13   ` [PATCH v2 0/2] Add support for CL-SOM-iMX7 and SBC-iMX7 Shawn Guo
2015-12-22 12:13     ` Shawn Guo
2015-12-22 14:14     ` Igor Grinberg
2015-12-22 14:14       ` Igor Grinberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151208151401.GA20042@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.