From: Al Viro <viro@ZenIV.linux.org.uk>
To: Willy Tarreau <w@1wt.eu>
Cc: Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>, yalin wang <yalin.wang2010@gmail.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5] fs: clear file privilege bits when mmap writing
Date: Thu, 10 Dec 2015 19:33:51 +0000 [thread overview]
Message-ID: <20151210193351.GE20997@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20151210181611.GB32083@1wt.eu>
On Thu, Dec 10, 2015 at 07:16:11PM +0100, Willy Tarreau wrote:
> > Is f_flags safe to write like this without holding a lock?
>
> Unfortunately I have no idea. I've seen places where it's written without
> taking a lock such as in blkdev_open() and I don't think that this one is
> called with a lock held.
In any ->open() we obviously have nobody else able to find that struct file,
let alone modify it, so there the damn thing is essentially caller-private
and no locking is needed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Willy Tarreau <w@1wt.eu>
Cc: Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>, yalin wang <yalin.wang2010@gmail.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5] fs: clear file privilege bits when mmap writing
Date: Thu, 10 Dec 2015 19:33:51 +0000 [thread overview]
Message-ID: <20151210193351.GE20997@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20151210181611.GB32083@1wt.eu>
On Thu, Dec 10, 2015 at 07:16:11PM +0100, Willy Tarreau wrote:
> > Is f_flags safe to write like this without holding a lock?
>
> Unfortunately I have no idea. I've seen places where it's written without
> taking a lock such as in blkdev_open() and I don't think that this one is
> called with a lock held.
In any ->open() we obviously have nobody else able to find that struct file,
let alone modify it, so there the damn thing is essentially caller-private
and no locking is needed.
next prev parent reply other threads:[~2015-12-10 19:33 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 22:51 [PATCH v5] fs: clear file privilege bits when mmap writing Kees Cook
2015-12-09 22:51 ` Kees Cook
2015-12-10 1:21 ` Christoph Hellwig
2015-12-10 1:21 ` Christoph Hellwig
2015-12-10 3:25 ` Kees Cook
2015-12-10 3:25 ` Kees Cook
2015-12-10 4:14 ` Al Viro
2015-12-10 4:14 ` Al Viro
2015-12-10 7:06 ` Willy Tarreau
2015-12-10 7:06 ` Willy Tarreau
2015-12-10 7:10 ` Willy Tarreau
2015-12-10 7:10 ` Willy Tarreau
2015-12-10 18:05 ` Kees Cook
2015-12-10 18:05 ` Kees Cook
2015-12-10 18:16 ` Willy Tarreau
2015-12-10 18:16 ` Willy Tarreau
2015-12-10 18:18 ` Kees Cook
2015-12-10 18:18 ` Kees Cook
2015-12-10 19:33 ` Al Viro [this message]
2015-12-10 19:33 ` Al Viro
2015-12-10 19:47 ` Kees Cook
2015-12-10 19:47 ` Kees Cook
2015-12-10 20:27 ` Al Viro
2015-12-10 20:27 ` Al Viro
2015-12-10 21:45 ` Kees Cook
2015-12-10 21:45 ` Kees Cook
2015-12-10 21:56 ` Al Viro
2015-12-10 21:56 ` Al Viro
2015-12-10 22:00 ` Kees Cook
2015-12-10 22:00 ` Kees Cook
-- strict thread matches above, loose matches on Subject: below --
2015-12-10 22:33 Kees Cook
2016-01-07 19:36 ` Kees Cook
2016-01-08 0:30 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151210193351.GE20997@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=jack@suse.cz \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=w@1wt.eu \
--cc=yalin.wang2010@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.