All of lore.kernel.org
 help / color / mirror / Atom feed
* linux-4.4-rc5 bug report ?
@ 2015-12-14 12:22 David Binderman
  2015-12-14 14:36 ` Mike Snitzer
  0 siblings, 1 reply; 2+ messages in thread
From: David Binderman @ 2015-12-14 12:22 UTC (permalink / raw)
  To: Alasdair Kergon, Mike Snitzer, dm-devel@redhat.com

Hello there,

[linux-4.4-rc5/drivers/md/persistent-data/dm-space-map-metadata.c:160]: (style) Variable 'bop' is assigned a value that is never used.

    bop = brb->bops + brb->begin;
    brb->begin = brb_next(brb, brb->begin);

    return 0;

Suggest either use the variable in some way, or delete it.

Regards

David Binderman
 		 	   		  

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: linux-4.4-rc5 bug report ?
  2015-12-14 12:22 linux-4.4-rc5 bug report ? David Binderman
@ 2015-12-14 14:36 ` Mike Snitzer
  0 siblings, 0 replies; 2+ messages in thread
From: Mike Snitzer @ 2015-12-14 14:36 UTC (permalink / raw)
  To: David Binderman; +Cc: dm-devel@redhat.com, Alasdair Kergon

On Mon, Dec 14 2015 at  7:22am -0500,
David Binderman <dcb314@hotmail.com> wrote:

> Hello there,
> 
> [linux-4.4-rc5/drivers/md/persistent-data/dm-space-map-metadata.c:160]: (style) Variable 'bop' is assigned a value that is never used.
> 
>     bop = brb->bops + brb->begin;
>     brb->begin = brb_next(brb, brb->begin);
> 
>     return 0;
> 
> Suggest either use the variable in some way, or delete it.

Thanks for the report, I've staged a fix here:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-4.5&id=512167788a6fe9481a33a3cce5f80b684631a1bb

Waiting for the 4.5 merge window sense this isn't a serious problem
(it'll make its way back to stable@ kernels once merged)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-12-14 14:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-14 12:22 linux-4.4-rc5 bug report ? David Binderman
2015-12-14 14:36 ` Mike Snitzer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.