linux-4.4-rc5 bug report ?

linux-4.4-rc5 bug report ?

[David Binderman]

Hello there,

[linux-4.4-rc5/drivers/md/persistent-data/dm-space-map-metadata.c:160]: (style) Variable 'bop' is assigned a value that is never used.

    bop = brb->bops + brb->begin;
    brb->begin = brb_next(brb, brb->begin);

    return 0;

Suggest either use the variable in some way, or delete it.

Regards

David Binderman
 		 	   		  

Re: linux-4.4-rc5 bug report ?

[Mike Snitzer]

On Mon, Dec 14 2015 at  7:22am -0500,
David Binderman <dcb314@hotmail.com> wrote:

> Hello there,
> 
> [linux-4.4-rc5/drivers/md/persistent-data/dm-space-map-metadata.c:160]: (style) Variable 'bop' is assigned a value that is never used.
> 
>     bop = brb->bops + brb->begin;
>     brb->begin = brb_next(brb, brb->begin);
> 
>     return 0;
> 
> Suggest either use the variable in some way, or delete it.

Thanks for the report, I've staged a fix here:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-4.5&id=512167788a6fe9481a33a3cce5f80b684631a1bb

Waiting for the 4.5 merge window sense this isn't a serious problem
(it'll make its way back to stable@ kernels once merged)