From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/8] irq: bcm2836: Add SMP support for the 2836
Date: Thu, 17 Dec 2015 07:17:42 +0200 [thread overview]
Message-ID: <20151217051742.GV2318@tarshish> (raw)
In-Reply-To: <1450310115-22163-3-git-send-email-eric@anholt.net>
Hi Eric,
On Wed, Dec 16, 2015 at 03:55:09PM -0800, Eric Anholt wrote:
> @@ -226,6 +228,26 @@ static const struct irq_domain_ops bcm2836_arm_irqchip_intc_ops = {
> .xlate = irq_domain_xlate_onecell
> };
>
> +#ifdef CONFIG_SMP
Why not put this section under the existing '#ifdef CONFIG_SMP' just a few
lines above?
> +int __init bcm2836_smp_boot_secondary(unsigned int cpu,
> + struct task_struct *idle)
> +{
> + unsigned long secondary_startup_phys =
> + (unsigned long)virt_to_phys((void *)secondary_startup);
> +
> + dsb();
> + writel(secondary_startup_phys,
> + intc.base + LOCAL_MAILBOX3_SET0 + 16 * cpu);
> +
> + return 0;
> +}
> +
> +static const struct smp_operations bcm2836_smp_ops __initconst = {
> + .smp_boot_secondary = bcm2836_smp_boot_secondary,
> +};
> +
> +#endif
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
WARNING: multiple messages have this Message-ID (diff)
From: Baruch Siach <baruch@tkos.co.il>
To: Eric Anholt <eric@anholt.net>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Jason Cooper <jason@lakedaemon.net>,
Scott Branden <sbranden@broadcom.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Marc Zyngier <marc.zyngier@arm.com>, Ray Jui <rjui@broadcom.com>,
Stephen Warren <swarren@wwwdotorg.org>,
linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>,
Andrea Merello <andrea.merello@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
Kumar Gala <galak@codeaurora.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/8] irq: bcm2836: Add SMP support for the 2836
Date: Thu, 17 Dec 2015 07:17:42 +0200 [thread overview]
Message-ID: <20151217051742.GV2318@tarshish> (raw)
In-Reply-To: <1450310115-22163-3-git-send-email-eric@anholt.net>
Hi Eric,
On Wed, Dec 16, 2015 at 03:55:09PM -0800, Eric Anholt wrote:
> @@ -226,6 +228,26 @@ static const struct irq_domain_ops bcm2836_arm_irqchip_intc_ops = {
> .xlate = irq_domain_xlate_onecell
> };
>
> +#ifdef CONFIG_SMP
Why not put this section under the existing '#ifdef CONFIG_SMP' just a few
lines above?
> +int __init bcm2836_smp_boot_secondary(unsigned int cpu,
> + struct task_struct *idle)
> +{
> + unsigned long secondary_startup_phys =
> + (unsigned long)virt_to_phys((void *)secondary_startup);
> +
> + dsb();
> + writel(secondary_startup_phys,
> + intc.base + LOCAL_MAILBOX3_SET0 + 16 * cpu);
> +
> + return 0;
> +}
> +
> +static const struct smp_operations bcm2836_smp_ops __initconst = {
> + .smp_boot_secondary = bcm2836_smp_boot_secondary,
> +};
> +
> +#endif
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
WARNING: multiple messages have this Message-ID (diff)
From: Baruch Siach <baruch@tkos.co.il>
To: Eric Anholt <eric@anholt.net>
Cc: linux-rpi-kernel@lists.infradead.org,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Florian Fainelli <f.fainelli@gmail.com>,
Jason Cooper <jason@lakedaemon.net>,
Scott Branden <sbranden@broadcom.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Marc Zyngier <marc.zyngier@arm.com>, Ray Jui <rjui@broadcom.com>,
Lee Jones <lee@kernel.org>,
linux-kernel@vger.kernel.org,
Andrea Merello <andrea.merello@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
Kumar Gala <galak@codeaurora.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/8] irq: bcm2836: Add SMP support for the 2836
Date: Thu, 17 Dec 2015 07:17:42 +0200 [thread overview]
Message-ID: <20151217051742.GV2318@tarshish> (raw)
In-Reply-To: <1450310115-22163-3-git-send-email-eric@anholt.net>
Hi Eric,
On Wed, Dec 16, 2015 at 03:55:09PM -0800, Eric Anholt wrote:
> @@ -226,6 +228,26 @@ static const struct irq_domain_ops bcm2836_arm_irqchip_intc_ops = {
> .xlate = irq_domain_xlate_onecell
> };
>
> +#ifdef CONFIG_SMP
Why not put this section under the existing '#ifdef CONFIG_SMP' just a few
lines above?
> +int __init bcm2836_smp_boot_secondary(unsigned int cpu,
> + struct task_struct *idle)
> +{
> + unsigned long secondary_startup_phys =
> + (unsigned long)virt_to_phys((void *)secondary_startup);
> +
> + dsb();
> + writel(secondary_startup_phys,
> + intc.base + LOCAL_MAILBOX3_SET0 + 16 * cpu);
> +
> + return 0;
> +}
> +
> +static const struct smp_operations bcm2836_smp_ops __initconst = {
> + .smp_boot_secondary = bcm2836_smp_boot_secondary,
> +};
> +
> +#endif
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2015-12-17 5:17 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 23:55 [PATCH v2 0/8] Raspberry Pi 2 support Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-16 23:55 ` [PATCH v2 1/8] irq: bcm2836: Fix initialization of the LOCAL_IRQ_CNT*IRQ timers Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-16 23:55 ` [PATCH v2 2/8] irq: bcm2836: Add SMP support for the 2836 Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-17 5:17 ` Baruch Siach [this message]
2015-12-17 5:17 ` Baruch Siach
2015-12-17 5:17 ` Baruch Siach
2015-12-16 23:55 ` [PATCH v2 3/8] dt-bindings: Add root properties for Raspberry Pi 2 Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-19 4:18 ` Rob Herring
2015-12-19 4:18 ` Rob Herring
2015-12-16 23:55 ` [PATCH v2 4/8] ARM: bcm2835: Split the DT for peripherals from the DT for the CPU Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-18 10:00 ` Alexander Aring
2015-12-18 10:00 ` Alexander Aring
2015-12-21 23:09 ` Eric Anholt
2015-12-21 23:09 ` Eric Anholt
2015-12-21 23:09 ` Eric Anholt
2015-12-16 23:55 ` [PATCH v2 5/8] ARM: bcm2835: Move the CPU/peripheral include out of common RPi DT Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-16 23:55 ` [PATCH v2 6/8] ARM: bcm2835: Add devicetree for bcm2836 and Raspberry Pi 2 B Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-22 10:11 ` Alexander Aring
2015-12-22 10:11 ` Alexander Aring
2015-12-16 23:55 ` [PATCH v2 7/8] ARM: bcm2835: Add a compat string for bcm2836 machine probe Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-16 23:55 ` [PATCH v2 8/8] ARM: bcm2835: Add Kconfig support for bcm2836 Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-26 22:38 ` Eric Anholt
2015-12-26 22:38 ` Eric Anholt
2016-01-03 21:53 ` Noralf Trønnes
2016-01-03 21:53 ` Noralf Trønnes
2015-12-17 0:03 ` [PATCH v2 0/8] Raspberry Pi 2 support Arnd Bergmann
2015-12-17 0:03 ` Arnd Bergmann
2015-12-17 0:37 ` Eric Anholt
2015-12-17 0:37 ` Eric Anholt
2015-12-17 0:37 ` Eric Anholt
2015-12-17 8:48 ` Stefan Wahren
2015-12-17 8:48 ` Stefan Wahren
2015-12-17 10:26 ` Arnd Bergmann
2015-12-17 10:26 ` Arnd Bergmann
2015-12-17 10:26 ` Arnd Bergmann
2015-12-18 10:08 ` Alexander Aring
2015-12-18 10:08 ` Alexander Aring
2015-12-18 10:55 ` Alexander Aring
2015-12-18 10:55 ` Alexander Aring
2015-12-20 22:11 ` Alexander Aring
2015-12-20 22:11 ` Alexander Aring
2015-12-20 22:11 ` Alexander Aring
2015-12-21 23:07 ` Eric Anholt
2015-12-21 23:07 ` Eric Anholt
2015-12-22 14:26 ` Alexander Aring
2015-12-22 14:26 ` Alexander Aring
2015-12-22 14:26 ` Alexander Aring
2015-12-22 19:01 ` Eric Anholt
2015-12-22 19:01 ` Eric Anholt
2015-12-22 19:01 ` Eric Anholt
2015-12-26 21:38 ` Noralf Trønnes
2015-12-26 21:38 ` Noralf Trønnes
2015-12-21 23:11 ` Arnd Bergmann
2015-12-21 23:11 ` Arnd Bergmann
2015-12-22 14:20 ` Alexander Aring
2015-12-22 14:20 ` Alexander Aring
2015-12-22 14:20 ` Alexander Aring
2015-12-22 21:23 ` Arnd Bergmann
2015-12-22 21:23 ` Arnd Bergmann
2015-12-22 21:23 ` Arnd Bergmann
2015-12-25 0:01 ` Eric Anholt
2015-12-25 0:01 ` Eric Anholt
2015-12-25 0:01 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151217051742.GV2318@tarshish \
--to=baruch@tkos.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.