From: alex.aring@gmail.com (Alexander Aring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 6/8] ARM: bcm2835: Add devicetree for bcm2836 and Raspberry Pi 2 B
Date: Tue, 22 Dec 2015 11:11:33 +0100 [thread overview]
Message-ID: <20151222101131.GA566@omega> (raw)
In-Reply-To: <1450310115-22163-7-git-send-email-eric@anholt.net>
On Wed, Dec 16, 2015 at 03:55:13PM -0800, Eric Anholt wrote:
> The Pi 2 B ends up like a Pi 1 B+, with the same peripherals and
> pinout, but the CPU and memory layout changed to use the 2836.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
> arch/arm/boot/dts/bcm2836-rpi-2-b.dts | 35 ++++++++++++++++
> arch/arm/boot/dts/bcm2836.dtsi | 77 +++++++++++++++++++++++++++++++++++
> 2 files changed, 112 insertions(+)
> create mode 100644 arch/arm/boot/dts/bcm2836-rpi-2-b.dts
> create mode 100644 arch/arm/boot/dts/bcm2836.dtsi
>
> diff --git a/arch/arm/boot/dts/bcm2836-rpi-2-b.dts b/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
> new file mode 100644
> index 0000000..ff94666
> --- /dev/null
> +++ b/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
> @@ -0,0 +1,35 @@
> +/dts-v1/;
> +#include "bcm2836.dtsi"
> +#include "bcm2835-rpi.dtsi"
> +
> +/ {
> + compatible = "raspberrypi,2-model-b", "brcm,bcm2836";
> + model = "Raspberry Pi 2 Model B";
> +
> + memory {
> + reg = <0 0x40000000>;
> + };
> +
> + leds {
> + act {
> + gpios = <&gpio 47 0>;
> + };
> +
> + pwr {
> + label = "PWR";
> + gpios = <&gpio 35 0>;
> + default-state = "keep";
> + linux,default-trigger = "default-on";
> + };
> + };
> +};
> +
> +&gpio {
> + pinctrl-0 = <&gpioout &alt0 &i2s_alt0 &alt3>;
> +
> + /* I2S interface */
> + i2s_alt0: i2s_alt0 {
> + brcm,pins = <18 19 20 21>;
> + brcm,function = <BCM2835_FSEL_ALT0>;
> + };
> +};
> diff --git a/arch/arm/boot/dts/bcm2836.dtsi b/arch/arm/boot/dts/bcm2836.dtsi
> new file mode 100644
> index 0000000..6693118
> --- /dev/null
> +++ b/arch/arm/boot/dts/bcm2836.dtsi
> @@ -0,0 +1,77 @@
> +#include "bcm283x.dtsi"
> +
> +/ {
> + compatible = "brcm,bcm2836";
> +
> + soc {
> + ranges = <0x7e000000 0x3f000000 0x1000000>,
nitpik, I would change it here to 0x01000000 for the size parameter,
like below: 8-byte filled with zeroes.
> + <0x40000000 0x40000000 0x00001000>;
Is 0x00001000 correct here? I currently debug this part because the
devicetree issues which I mentioned. I looked into some bcm2836
datasheet. See [0], section "4 Registers", I assume this should be 0x00000100.
Or are there more than these registers which need to be accessable?
- Alex
[0] https://github.com/raspberrypi/documentation/blob/master/hardware/raspberrypi/bcm2836/QA7_rev3.4.pdf
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Aring <alex.aring@gmail.com>
To: Eric Anholt <eric@anholt.net>
Cc: linux-rpi-kernel@lists.infradead.org,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Florian Fainelli <f.fainelli@gmail.com>,
Jason Cooper <jason@lakedaemon.net>,
Scott Branden <sbranden@broadcom.com>,
Marc Zyngier <marc.zyngier@arm.com>, Ray Jui <rjui@broadcom.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
Kumar Gala <galak@codeaurora.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 6/8] ARM: bcm2835: Add devicetree for bcm2836 and Raspberry Pi 2 B
Date: Tue, 22 Dec 2015 11:11:33 +0100 [thread overview]
Message-ID: <20151222101131.GA566@omega> (raw)
In-Reply-To: <1450310115-22163-7-git-send-email-eric@anholt.net>
On Wed, Dec 16, 2015 at 03:55:13PM -0800, Eric Anholt wrote:
> The Pi 2 B ends up like a Pi 1 B+, with the same peripherals and
> pinout, but the CPU and memory layout changed to use the 2836.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
> arch/arm/boot/dts/bcm2836-rpi-2-b.dts | 35 ++++++++++++++++
> arch/arm/boot/dts/bcm2836.dtsi | 77 +++++++++++++++++++++++++++++++++++
> 2 files changed, 112 insertions(+)
> create mode 100644 arch/arm/boot/dts/bcm2836-rpi-2-b.dts
> create mode 100644 arch/arm/boot/dts/bcm2836.dtsi
>
> diff --git a/arch/arm/boot/dts/bcm2836-rpi-2-b.dts b/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
> new file mode 100644
> index 0000000..ff94666
> --- /dev/null
> +++ b/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
> @@ -0,0 +1,35 @@
> +/dts-v1/;
> +#include "bcm2836.dtsi"
> +#include "bcm2835-rpi.dtsi"
> +
> +/ {
> + compatible = "raspberrypi,2-model-b", "brcm,bcm2836";
> + model = "Raspberry Pi 2 Model B";
> +
> + memory {
> + reg = <0 0x40000000>;
> + };
> +
> + leds {
> + act {
> + gpios = <&gpio 47 0>;
> + };
> +
> + pwr {
> + label = "PWR";
> + gpios = <&gpio 35 0>;
> + default-state = "keep";
> + linux,default-trigger = "default-on";
> + };
> + };
> +};
> +
> +&gpio {
> + pinctrl-0 = <&gpioout &alt0 &i2s_alt0 &alt3>;
> +
> + /* I2S interface */
> + i2s_alt0: i2s_alt0 {
> + brcm,pins = <18 19 20 21>;
> + brcm,function = <BCM2835_FSEL_ALT0>;
> + };
> +};
> diff --git a/arch/arm/boot/dts/bcm2836.dtsi b/arch/arm/boot/dts/bcm2836.dtsi
> new file mode 100644
> index 0000000..6693118
> --- /dev/null
> +++ b/arch/arm/boot/dts/bcm2836.dtsi
> @@ -0,0 +1,77 @@
> +#include "bcm283x.dtsi"
> +
> +/ {
> + compatible = "brcm,bcm2836";
> +
> + soc {
> + ranges = <0x7e000000 0x3f000000 0x1000000>,
nitpik, I would change it here to 0x01000000 for the size parameter,
like below: 8-byte filled with zeroes.
> + <0x40000000 0x40000000 0x00001000>;
Is 0x00001000 correct here? I currently debug this part because the
devicetree issues which I mentioned. I looked into some bcm2836
datasheet. See [0], section "4 Registers", I assume this should be 0x00000100.
Or are there more than these registers which need to be accessable?
- Alex
[0] https://github.com/raspberrypi/documentation/blob/master/hardware/raspberrypi/bcm2836/QA7_rev3.4.pdf
next prev parent reply other threads:[~2015-12-22 10:11 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 23:55 [PATCH v2 0/8] Raspberry Pi 2 support Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-16 23:55 ` [PATCH v2 1/8] irq: bcm2836: Fix initialization of the LOCAL_IRQ_CNT*IRQ timers Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-16 23:55 ` [PATCH v2 2/8] irq: bcm2836: Add SMP support for the 2836 Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-17 5:17 ` Baruch Siach
2015-12-17 5:17 ` Baruch Siach
2015-12-17 5:17 ` Baruch Siach
2015-12-16 23:55 ` [PATCH v2 3/8] dt-bindings: Add root properties for Raspberry Pi 2 Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-19 4:18 ` Rob Herring
2015-12-19 4:18 ` Rob Herring
2015-12-16 23:55 ` [PATCH v2 4/8] ARM: bcm2835: Split the DT for peripherals from the DT for the CPU Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-18 10:00 ` Alexander Aring
2015-12-18 10:00 ` Alexander Aring
2015-12-21 23:09 ` Eric Anholt
2015-12-21 23:09 ` Eric Anholt
2015-12-21 23:09 ` Eric Anholt
2015-12-16 23:55 ` [PATCH v2 5/8] ARM: bcm2835: Move the CPU/peripheral include out of common RPi DT Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-16 23:55 ` [PATCH v2 6/8] ARM: bcm2835: Add devicetree for bcm2836 and Raspberry Pi 2 B Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-22 10:11 ` Alexander Aring [this message]
2015-12-22 10:11 ` Alexander Aring
2015-12-16 23:55 ` [PATCH v2 7/8] ARM: bcm2835: Add a compat string for bcm2836 machine probe Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-16 23:55 ` [PATCH v2 8/8] ARM: bcm2835: Add Kconfig support for bcm2836 Eric Anholt
2015-12-16 23:55 ` Eric Anholt
2015-12-26 22:38 ` Eric Anholt
2015-12-26 22:38 ` Eric Anholt
2016-01-03 21:53 ` Noralf Trønnes
2016-01-03 21:53 ` Noralf Trønnes
2015-12-17 0:03 ` [PATCH v2 0/8] Raspberry Pi 2 support Arnd Bergmann
2015-12-17 0:03 ` Arnd Bergmann
2015-12-17 0:37 ` Eric Anholt
2015-12-17 0:37 ` Eric Anholt
2015-12-17 0:37 ` Eric Anholt
2015-12-17 8:48 ` Stefan Wahren
2015-12-17 8:48 ` Stefan Wahren
2015-12-17 10:26 ` Arnd Bergmann
2015-12-17 10:26 ` Arnd Bergmann
2015-12-17 10:26 ` Arnd Bergmann
2015-12-18 10:08 ` Alexander Aring
2015-12-18 10:08 ` Alexander Aring
2015-12-18 10:55 ` Alexander Aring
2015-12-18 10:55 ` Alexander Aring
2015-12-20 22:11 ` Alexander Aring
2015-12-20 22:11 ` Alexander Aring
2015-12-20 22:11 ` Alexander Aring
2015-12-21 23:07 ` Eric Anholt
2015-12-21 23:07 ` Eric Anholt
2015-12-22 14:26 ` Alexander Aring
2015-12-22 14:26 ` Alexander Aring
2015-12-22 14:26 ` Alexander Aring
2015-12-22 19:01 ` Eric Anholt
2015-12-22 19:01 ` Eric Anholt
2015-12-22 19:01 ` Eric Anholt
2015-12-26 21:38 ` Noralf Trønnes
2015-12-26 21:38 ` Noralf Trønnes
2015-12-21 23:11 ` Arnd Bergmann
2015-12-21 23:11 ` Arnd Bergmann
2015-12-22 14:20 ` Alexander Aring
2015-12-22 14:20 ` Alexander Aring
2015-12-22 14:20 ` Alexander Aring
2015-12-22 21:23 ` Arnd Bergmann
2015-12-22 21:23 ` Arnd Bergmann
2015-12-22 21:23 ` Arnd Bergmann
2015-12-25 0:01 ` Eric Anholt
2015-12-25 0:01 ` Eric Anholt
2015-12-25 0:01 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151222101131.GA566@omega \
--to=alex.aring@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.