From: Segher Boessenkool <segher@kernel.crashing.org>
To: Curt Brune <curt@cumulusnetworks.com>
Cc: galak@codeaurora.org, ijc+devicetree@hellion.org.uk,
mark.rutland@arm.com, pawel.moll@arm.com,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
robh+dt@kernel.org, devicetree@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC 1/1] powerpc: legacy serial port use device tree cell-index property
Date: Sun, 20 Dec 2015 09:02:25 -0600 [thread overview]
Message-ID: <20151220150225.GA27380@gate.crashing.org> (raw)
In-Reply-To: <1448477209-22340-2-git-send-email-curt@cumulusnetworks.com>
On Wed, Nov 25, 2015 at 10:46:49AM -0800, Curt Brune wrote:
> + /* Check if the ports have an ordering, defined by 'cell-index' */
> + if (((indexp = (u32*)of_get_property(np, "cell-index", &len)) != NULL) &&
> + (len == sizeof(u32)))
> + index = *indexp;
> +
> /* Add port, irq will be dealt with later. We passed a translated
> * IO port value. It will be fixed up later along with the irq
> */
> if (tsi && !strcmp(tsi->type, "tsi-bridge"))
> - return add_legacy_port(np, -1, UPIO_TSI, addr, addr,
> + return add_legacy_port(np, index, UPIO_TSI, addr, addr,
> NO_IRQ, legacy_port_flags, 0);
> else
> - return add_legacy_port(np, -1, UPIO_MEM, addr, addr,
> + return add_legacy_port(np, index, UPIO_MEM, addr, addr,
> NO_IRQ, legacy_port_flags, 0);
What does this do if the value in cell-index is a duplicate. or the port
with that number is already created some other way? Are the numbers in
cell-index global anyway, or relative to some parent device (I couldn't
find the documentation for this).
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Curt Brune <curt@cumulusnetworks.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
robh+dt@kernel.org, paulus@samba.org, galak@codeaurora.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC 1/1] powerpc: legacy serial port use device tree cell-index property
Date: Sun, 20 Dec 2015 09:02:25 -0600 [thread overview]
Message-ID: <20151220150225.GA27380@gate.crashing.org> (raw)
In-Reply-To: <1448477209-22340-2-git-send-email-curt@cumulusnetworks.com>
On Wed, Nov 25, 2015 at 10:46:49AM -0800, Curt Brune wrote:
> + /* Check if the ports have an ordering, defined by 'cell-index' */
> + if (((indexp = (u32*)of_get_property(np, "cell-index", &len)) != NULL) &&
> + (len == sizeof(u32)))
> + index = *indexp;
> +
> /* Add port, irq will be dealt with later. We passed a translated
> * IO port value. It will be fixed up later along with the irq
> */
> if (tsi && !strcmp(tsi->type, "tsi-bridge"))
> - return add_legacy_port(np, -1, UPIO_TSI, addr, addr,
> + return add_legacy_port(np, index, UPIO_TSI, addr, addr,
> NO_IRQ, legacy_port_flags, 0);
> else
> - return add_legacy_port(np, -1, UPIO_MEM, addr, addr,
> + return add_legacy_port(np, index, UPIO_MEM, addr, addr,
> NO_IRQ, legacy_port_flags, 0);
What does this do if the value in cell-index is a duplicate. or the port
with that number is already created some other way? Are the numbers in
cell-index global anyway, or relative to some parent device (I couldn't
find the documentation for this).
Segher
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
next prev parent reply other threads:[~2015-12-20 15:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 18:46 [RFC 1/1] powerpc: legacy serial port use device tree cell-index property Curt Brune
2015-11-25 18:46 ` Curt Brune
2015-12-20 15:02 ` Segher Boessenkool [this message]
2015-12-20 15:02 ` Segher Boessenkool
2015-12-30 16:36 ` Curt Brune
2015-12-30 16:36 ` Curt Brune
2015-12-30 20:12 ` Segher Boessenkool
2015-12-30 20:12 ` Segher Boessenkool
2015-12-22 3:42 ` Scott Wood
2015-12-22 3:42 ` Scott Wood
2015-12-30 16:37 ` Curt Brune
2015-12-30 16:37 ` Curt Brune
2015-12-30 22:34 ` Rob Herring
2015-12-30 22:34 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151220150225.GA27380@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=benh@kernel.crashing.org \
--cc=curt@cumulusnetworks.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.