From: Segher Boessenkool <segher@kernel.crashing.org>
To: Curt Brune <curt@cumulusnetworks.com>
Cc: galak@codeaurora.org, ijc+devicetree@hellion.org.uk,
mark.rutland@arm.com, pawel.moll@arm.com,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
robh+dt@kernel.org, devicetree@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC 1/1] powerpc: legacy serial port use device tree cell-index property
Date: Wed, 30 Dec 2015 14:12:59 -0600 [thread overview]
Message-ID: <20151230201259.GA11741@gate.crashing.org> (raw)
In-Reply-To: <20151230163601.GX14046@cumulusnetworks.com>
On Wed, Dec 30, 2015 at 08:36:01AM -0800, Curt Brune wrote:
> > What does this do if the value in cell-index is a duplicate. or the port
> > with that number is already created some other way? Are the numbers in
> > cell-index global anyway, or relative to some parent device (I couldn't
> > find the documentation for this).
>
> add_legacy_port() has support for handling duplicate index entries.
> Reading that code it looks like the recent entry wins and the older
> entry is moved to the next available index.
>
> The numbers in cell-index are not global nor explicitly relative to a
> parent device. I also could not find documentation on this.
That sounds like it should work then. It does change behaviour for
existing configs.
Thanks,
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
To: Curt Brune <curt-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>
Cc: galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org,
paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org,
mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [RFC 1/1] powerpc: legacy serial port use device tree cell-index property
Date: Wed, 30 Dec 2015 14:12:59 -0600 [thread overview]
Message-ID: <20151230201259.GA11741@gate.crashing.org> (raw)
In-Reply-To: <20151230163601.GX14046-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>
On Wed, Dec 30, 2015 at 08:36:01AM -0800, Curt Brune wrote:
> > What does this do if the value in cell-index is a duplicate. or the port
> > with that number is already created some other way? Are the numbers in
> > cell-index global anyway, or relative to some parent device (I couldn't
> > find the documentation for this).
>
> add_legacy_port() has support for handling duplicate index entries.
> Reading that code it looks like the recent entry wins and the older
> entry is moved to the next available index.
>
> The numbers in cell-index are not global nor explicitly relative to a
> parent device. I also could not find documentation on this.
That sounds like it should work then. It does change behaviour for
existing configs.
Thanks,
Segher
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-30 20:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 18:46 [RFC 1/1] powerpc: legacy serial port use device tree cell-index property Curt Brune
2015-11-25 18:46 ` Curt Brune
2015-12-20 15:02 ` Segher Boessenkool
2015-12-20 15:02 ` Segher Boessenkool
2015-12-30 16:36 ` Curt Brune
2015-12-30 16:36 ` Curt Brune
2015-12-30 20:12 ` Segher Boessenkool [this message]
2015-12-30 20:12 ` Segher Boessenkool
2015-12-22 3:42 ` Scott Wood
2015-12-22 3:42 ` Scott Wood
2015-12-30 16:37 ` Curt Brune
2015-12-30 16:37 ` Curt Brune
2015-12-30 22:34 ` Rob Herring
2015-12-30 22:34 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151230201259.GA11741@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=benh@kernel.crashing.org \
--cc=curt@cumulusnetworks.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.