* [patch] drm/amd/powerplay: precedence bug in init_non_clock_fields()
@ 2016-01-04 20:44 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-01-04 20:44 UTC (permalink / raw)
To: David Airlie, Jammy Zhou
Cc: Alex Deucher, Tom St Denis, kernel-janitors, Rex Zhu, dri-devel
The cast to uint8_t happens before the right shift so this always sets
.m3arb to zero. The cast is actually a no-op so we can remove it.
Fixes: 3bace3591493 ('drm/amd/powerplay: add hardware manager sub-component')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Static analysis stuff. Not tested.
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c b/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c
index 1d385f4..9031a44 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c
@@ -735,8 +735,8 @@ static int init_non_clock_fields(struct pp_hwmgr *hwmgr,
ps->memory.dllOff = (0 != tmp);
- ps->memory.m3arb = (uint8_t)(le32_to_cpu(pnon_clock_info->ulCapsAndSettings) &
- ATOM_PPLIB_M3ARB_MASK) >> ATOM_PPLIB_M3ARB_SHIFT;
+ ps->memory.m3arb = (le32_to_cpu(pnon_clock_info->ulCapsAndSettings) &
+ ATOM_PPLIB_M3ARB_MASK) >> ATOM_PPLIB_M3ARB_SHIFT;
ps->temperatures.min = PP_TEMPERATURE_UNITS_PER_CENTIGRADES *
pnon_clock_info->ucMinTemperature;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] drm/amd/powerplay: precedence bug in init_non_clock_fields()
@ 2016-01-04 20:44 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-01-04 20:44 UTC (permalink / raw)
To: David Airlie, Jammy Zhou
Cc: Alex Deucher, Tom St Denis, kernel-janitors, Rex Zhu, dri-devel
The cast to uint8_t happens before the right shift so this always sets
.m3arb to zero. The cast is actually a no-op so we can remove it.
Fixes: 3bace3591493 ('drm/amd/powerplay: add hardware manager sub-component')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Static analysis stuff. Not tested.
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c b/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c
index 1d385f4..9031a44 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c
@@ -735,8 +735,8 @@ static int init_non_clock_fields(struct pp_hwmgr *hwmgr,
ps->memory.dllOff = (0 != tmp);
- ps->memory.m3arb = (uint8_t)(le32_to_cpu(pnon_clock_info->ulCapsAndSettings) &
- ATOM_PPLIB_M3ARB_MASK) >> ATOM_PPLIB_M3ARB_SHIFT;
+ ps->memory.m3arb = (le32_to_cpu(pnon_clock_info->ulCapsAndSettings) &
+ ATOM_PPLIB_M3ARB_MASK) >> ATOM_PPLIB_M3ARB_SHIFT;
ps->temperatures.min = PP_TEMPERATURE_UNITS_PER_CENTIGRADES *
pnon_clock_info->ucMinTemperature;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] drm/amd/powerplay: precedence bug in init_non_clock_fields()
2016-01-04 20:44 ` Dan Carpenter
@ 2016-01-04 21:22 ` Alex Deucher
-1 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2016-01-04 21:22 UTC (permalink / raw)
To: Dan Carpenter
Cc: Tom St Denis, Jammy Zhou, kernel-janitors,
Maling list - DRI developers, Alex Deucher, Rex Zhu
On Mon, Jan 4, 2016 at 3:44 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The cast to uint8_t happens before the right shift so this always sets
> .m3arb to zero. The cast is actually a no-op so we can remove it.
>
> Fixes: 3bace3591493 ('drm/amd/powerplay: add hardware manager sub-component')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied. thanks!
Alex
> ---
> Static analysis stuff. Not tested.
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c b/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c
> index 1d385f4..9031a44 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c
> @@ -735,8 +735,8 @@ static int init_non_clock_fields(struct pp_hwmgr *hwmgr,
>
> ps->memory.dllOff = (0 != tmp);
>
> - ps->memory.m3arb = (uint8_t)(le32_to_cpu(pnon_clock_info->ulCapsAndSettings) &
> - ATOM_PPLIB_M3ARB_MASK) >> ATOM_PPLIB_M3ARB_SHIFT;
> + ps->memory.m3arb = (le32_to_cpu(pnon_clock_info->ulCapsAndSettings) &
> + ATOM_PPLIB_M3ARB_MASK) >> ATOM_PPLIB_M3ARB_SHIFT;
>
> ps->temperatures.min = PP_TEMPERATURE_UNITS_PER_CENTIGRADES *
> pnon_clock_info->ucMinTemperature;
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] drm/amd/powerplay: precedence bug in init_non_clock_fields()
@ 2016-01-04 21:22 ` Alex Deucher
0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2016-01-04 21:22 UTC (permalink / raw)
To: Dan Carpenter
Cc: Tom St Denis, Jammy Zhou, kernel-janitors,
Maling list - DRI developers, Alex Deucher, Rex Zhu
On Mon, Jan 4, 2016 at 3:44 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The cast to uint8_t happens before the right shift so this always sets
> .m3arb to zero. The cast is actually a no-op so we can remove it.
>
> Fixes: 3bace3591493 ('drm/amd/powerplay: add hardware manager sub-component')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied. thanks!
Alex
> ---
> Static analysis stuff. Not tested.
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c b/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c
> index 1d385f4..9031a44 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c
> @@ -735,8 +735,8 @@ static int init_non_clock_fields(struct pp_hwmgr *hwmgr,
>
> ps->memory.dllOff = (0 != tmp);
>
> - ps->memory.m3arb = (uint8_t)(le32_to_cpu(pnon_clock_info->ulCapsAndSettings) &
> - ATOM_PPLIB_M3ARB_MASK) >> ATOM_PPLIB_M3ARB_SHIFT;
> + ps->memory.m3arb = (le32_to_cpu(pnon_clock_info->ulCapsAndSettings) &
> + ATOM_PPLIB_M3ARB_MASK) >> ATOM_PPLIB_M3ARB_SHIFT;
>
> ps->temperatures.min = PP_TEMPERATURE_UNITS_PER_CENTIGRADES *
> pnon_clock_info->ucMinTemperature;
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-04 21:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-04 20:44 [patch] drm/amd/powerplay: precedence bug in init_non_clock_fields() Dan Carpenter
2016-01-04 20:44 ` Dan Carpenter
2016-01-04 21:22 ` Alex Deucher
2016-01-04 21:22 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.