From: Vinod Koul <vinod.koul@intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Sinan Kaya <okaya@codeaurora.org>,
dmaengine <dmaengine@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Timur Tabi <timur@codeaurora.org>,
devicetree <devicetree@vger.kernel.org>,
Christopher Covington <cov@codeaurora.org>,
jcm@redhat.com, Andy Gross <agross@codeaurora.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-arm-msm@vger.kernel.org,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V11 3/7] dma: add Qualcomm Technologies HIDMA management driver
Date: Tue, 5 Jan 2016 10:16:19 +0530 [thread overview]
Message-ID: <20160105044619.GJ2940@localhost> (raw)
In-Reply-To: <CAHp75Vd49-1H+1dkDmJzLpVhov1g+uJV+YiTBC9Xd3hVTmwRVg@mail.gmail.com>
On Mon, Jan 04, 2016 at 08:37:30PM +0200, Andy Shevchenko wrote:
> > +static int set_priority(struct hidma_mgmt_dev *mdev, unsigned int i, u64 val)
> > +{
> > + u64 tmp;
> > + int rc;
> > +
> > + if (i > mdev->dma_channels)
>
> Shouldn't be >= ? I somehow missed that.
There is no merit is posting not related context while replying, makes your
emails harder to read, please fix that
> > + return -EINVAL;
> > +
> > + tmp = mdev->priority[i];
> > + mdev->priority[i] = val;
> > + rc = hidma_mgmt_setup(mdev);
> > + if (rc)
> > + mdev->priority[i] = tmp;
> > + return rc;
> > +}
> > +
> > +static int set_weight(struct hidma_mgmt_dev *mdev, unsigned int i, u64 val)
> > +{
> > + u64 tmp;
> > + int rc;
> > +
> > + if (i > mdev->dma_channels)
>
> Ditto.
Exactly, ditto...
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V11 3/7] dma: add Qualcomm Technologies HIDMA management driver
Date: Tue, 5 Jan 2016 10:16:19 +0530 [thread overview]
Message-ID: <20160105044619.GJ2940@localhost> (raw)
In-Reply-To: <CAHp75Vd49-1H+1dkDmJzLpVhov1g+uJV+YiTBC9Xd3hVTmwRVg@mail.gmail.com>
On Mon, Jan 04, 2016 at 08:37:30PM +0200, Andy Shevchenko wrote:
> > +static int set_priority(struct hidma_mgmt_dev *mdev, unsigned int i, u64 val)
> > +{
> > + u64 tmp;
> > + int rc;
> > +
> > + if (i > mdev->dma_channels)
>
> Shouldn't be >= ? I somehow missed that.
There is no merit is posting not related context while replying, makes your
emails harder to read, please fix that
> > + return -EINVAL;
> > +
> > + tmp = mdev->priority[i];
> > + mdev->priority[i] = val;
> > + rc = hidma_mgmt_setup(mdev);
> > + if (rc)
> > + mdev->priority[i] = tmp;
> > + return rc;
> > +}
> > +
> > +static int set_weight(struct hidma_mgmt_dev *mdev, unsigned int i, u64 val)
> > +{
> > + u64 tmp;
> > + int rc;
> > +
> > + if (i > mdev->dma_channels)
>
> Ditto.
Exactly, ditto...
--
~Vinod
next prev parent reply other threads:[~2016-01-05 4:42 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 0:06 [PATCH V11 0/7] dma: add Qualcomm Technologies HIDMA driver Sinan Kaya
2016-01-04 0:06 ` Sinan Kaya
2016-01-04 0:06 ` [PATCH V11 1/7] dma: qcom_bam_dma: move to qcom directory Sinan Kaya
2016-01-04 0:06 ` Sinan Kaya
2016-01-04 0:06 ` Sinan Kaya
2016-01-04 0:06 ` [PATCH V11 2/7] dma: hidma: Add Device Tree support Sinan Kaya
2016-01-04 0:06 ` Sinan Kaya
2016-01-04 0:06 ` [PATCH V11 3/7] dma: add Qualcomm Technologies HIDMA management driver Sinan Kaya
2016-01-04 0:06 ` Sinan Kaya
2016-01-04 0:06 ` Sinan Kaya
2016-01-04 18:37 ` Andy Shevchenko
2016-01-04 18:37 ` Andy Shevchenko
2016-01-05 4:46 ` Vinod Koul [this message]
2016-01-05 4:46 ` Vinod Koul
2016-01-10 13:14 ` Sinan Kaya
2016-01-10 13:14 ` Sinan Kaya
2016-01-04 0:06 ` [PATCH V11 4/7] dma: add Qualcomm Technologies HIDMA channel driver Sinan Kaya
2016-01-04 0:06 ` Sinan Kaya
2016-01-04 18:43 ` Andy Shevchenko
2016-01-04 18:43 ` Andy Shevchenko
2016-01-05 14:05 ` Sinan Kaya
2016-01-05 14:05 ` Sinan Kaya
2016-01-04 0:06 ` [PATCH V11 5/7] dma: qcom_hidma: implement lower level hardware interface Sinan Kaya
2016-01-04 0:06 ` Sinan Kaya
2016-01-04 19:01 ` Andy Shevchenko
2016-01-04 19:01 ` Andy Shevchenko
2016-01-10 14:03 ` Sinan Kaya
2016-01-10 14:03 ` Sinan Kaya
2016-01-04 0:06 ` [PATCH V11 6/7] dma: qcom_hidma: add debugfs hooks Sinan Kaya
2016-01-04 0:06 ` Sinan Kaya
2016-01-04 0:06 ` [PATCH V11 7/7] dma: qcom_hidma: add support for object hierarchy Sinan Kaya
2016-01-04 0:06 ` Sinan Kaya
2016-01-04 0:09 ` [PATCH V11 0/7] dma: add Qualcomm Technologies HIDMA driver Sinan Kaya
2016-01-04 0:09 ` Sinan Kaya
[not found] ` <5689B833.7010901-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-01-04 3:36 ` Vinod Koul
2016-01-04 3:36 ` Vinod Koul
2016-01-04 3:36 ` Vinod Koul
2016-01-04 3:51 ` Sinan Kaya
2016-01-04 3:51 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160105044619.GJ2940@localhost \
--to=vinod.koul@intel.com \
--cc=agross@codeaurora.org \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=cov@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=okaya@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.