From: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Mike Marciniszyn
<mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: [PATCH v3 20/36] IB/rdmavt: Add post send and recv stubs
Date: Wed, 06 Jan 2016 10:01:17 -0800 [thread overview]
Message-ID: <20160106180047.8747.6862.stgit@scvm10.sc.intel.com> (raw)
In-Reply-To: <20160106174638.8747.47197.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
This adds the post sned and recv function stubs.
Reviewed-by: Mike Marciniszyn <mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Reviewed-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
Changes since v1:
Fix typo in subject
Change stubs to return EOPNOTSUPP
drivers/infiniband/sw/rdmavt/qp.c | 62 +++++++++++++++++++++++++++++++++++++
drivers/infiniband/sw/rdmavt/qp.h | 7 ++++
drivers/infiniband/sw/rdmavt/vt.c | 3 ++
3 files changed, 71 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/sw/rdmavt/qp.c b/drivers/infiniband/sw/rdmavt/qp.c
index a59f28d..23a5f68 100644
--- a/drivers/infiniband/sw/rdmavt/qp.c
+++ b/drivers/infiniband/sw/rdmavt/qp.c
@@ -118,3 +118,65 @@ int rvt_query_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr,
{
return -EOPNOTSUPP;
}
+
+/**
+ * rvt_post_receive - post a receive on a QP
+ * @ibqp: the QP to post the receive on
+ * @wr: the WR to post
+ * @bad_wr: the first bad WR is put here
+ *
+ * This may be called from interrupt context.
+ */
+int rvt_post_recv(struct ib_qp *ibqp, struct ib_recv_wr *wr,
+ struct ib_recv_wr **bad_wr)
+{
+ /*
+ * When a packet arrives the driver needs to call up to rvt to process
+ * the packet. The UD, RC, UC processing will be done in rvt, however
+ * the driver should be able to override this if it so choses. Perhaps a
+ * set of function pointers set up at registration time.
+ */
+
+ return -EOPNOTSUPP;
+}
+
+/**
+ * rvt_post_send - post a send on a QP
+ * @ibqp: the QP to post the send on
+ * @wr: the list of work requests to post
+ * @bad_wr: the first bad WR is put here
+ *
+ * This may be called from interrupt context.
+ */
+int rvt_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr,
+ struct ib_send_wr **bad_wr)
+{
+ /*
+ * VT-DRIVER-API: do_send()
+ * Driver needs to have a do_send() call which is a single entry point
+ * to take an already formed packet and throw it out on the wire. Once
+ * the packet is sent the driver needs to make an upcall to rvt so the
+ * completion queue can be notified and/or any other outstanding
+ * work/book keeping can be finished.
+ *
+ * Note that there should also be a way for rvt to protect itself
+ * against hangs in the driver layer. If a send doesn't actually
+ * complete in a timely manor rvt needs to return an error event.
+ */
+
+ return -EOPNOTSUPP;
+}
+
+/**
+ * rvt_post_srq_receive - post a receive on a shared receive queue
+ * @ibsrq: the SRQ to post the receive on
+ * @wr: the list of work requests to post
+ * @bad_wr: A pointer to the first WR to cause a problem is put here
+ *
+ * This may be called from interrupt context.
+ */
+int rvt_post_srq_recv(struct ib_srq *ibsrq, struct ib_recv_wr *wr,
+ struct ib_recv_wr **bad_wr)
+{
+ return -EOPNOTSUPP;
+}
diff --git a/drivers/infiniband/sw/rdmavt/qp.h b/drivers/infiniband/sw/rdmavt/qp.h
index 43acba0..10bc636 100644
--- a/drivers/infiniband/sw/rdmavt/qp.h
+++ b/drivers/infiniband/sw/rdmavt/qp.h
@@ -63,5 +63,10 @@ int rvt_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr,
int rvt_destroy_qp(struct ib_qp *ibqp);
int rvt_query_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr,
int attr_mask, struct ib_qp_init_attr *init_attr);
-
+int rvt_post_recv(struct ib_qp *ibqp, struct ib_recv_wr *wr,
+ struct ib_recv_wr **bad_wr);
+int rvt_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr,
+ struct ib_send_wr **bad_wr);
+int rvt_post_srq_recv(struct ib_srq *ibsrq, struct ib_recv_wr *wr,
+ struct ib_recv_wr **bad_wr);
#endif /* DEF_RVTQP_H */
diff --git a/drivers/infiniband/sw/rdmavt/vt.c b/drivers/infiniband/sw/rdmavt/vt.c
index 7fd879f..367bc45 100644
--- a/drivers/infiniband/sw/rdmavt/vt.c
+++ b/drivers/infiniband/sw/rdmavt/vt.c
@@ -232,6 +232,9 @@ int rvt_register_device(struct rvt_dev_info *rdi)
CHECK_DRIVER_OVERRIDE(rdi, modify_qp);
CHECK_DRIVER_OVERRIDE(rdi, destroy_qp);
CHECK_DRIVER_OVERRIDE(rdi, query_qp);
+ CHECK_DRIVER_OVERRIDE(rdi, post_send);
+ CHECK_DRIVER_OVERRIDE(rdi, post_recv);
+ CHECK_DRIVER_OVERRIDE(rdi, post_srq_recv);
/* Address Handle */
CHECK_DRIVER_OVERRIDE(rdi, create_ah);
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-06 18:01 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 17:49 [PATCH v3 00/36] Add rdma verbs transport library Dennis Dalessandro
[not found] ` <20160106174638.8747.47197.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2016-01-06 17:50 ` [PATCH v3 01/36] IB/rdmavt: Create module framework and handle driver registration Dennis Dalessandro
2016-01-06 17:51 ` [PATCH v3 02/36] IB/rdmavt: Consolidate dma ops in rdmavt Dennis Dalessandro
2016-01-06 17:51 ` [PATCH v3 03/36] IB/rdmavt: Add protection domain to rdmavt Dennis Dalessandro
2016-01-06 17:52 ` [PATCH v3 04/36] IB/rdmavt: Add ib core device attributes to rvt driver params list Dennis Dalessandro
2016-01-06 17:52 ` [PATCH v3 05/36] IB/rdmavt: Macroize override checks during driver registration Dennis Dalessandro
2016-01-06 17:53 ` [PATCH v3 06/36] IB/rdmavt: Add query and modify device stubs Dennis Dalessandro
2016-01-06 17:54 ` [PATCH v3 07/36] IB/rdmavt: Add query and modify port stubs Dennis Dalessandro
2016-01-06 17:54 ` [PATCH v3 08/36] IB/rdmavt: Add pkey query stub Dennis Dalessandro
2016-01-06 17:54 ` [PATCH v3 09/36] IB/rdmavt: Add query gid stub Dennis Dalessandro
2016-01-06 17:55 ` [PATCH v3 10/36] IB/rdmavt: Alloc and dealloc ucontexts Dennis Dalessandro
2016-01-06 17:56 ` [PATCH v3 11/36] IB/rdmavt: Add queue pair function stubs Dennis Dalessandro
2016-01-06 17:56 ` [PATCH v3 12/36] IB/rdmavt: Add address handle stubs Dennis Dalessandro
2016-01-06 17:57 ` [PATCH v3 13/36] IB/rdmavt: Add memory region stubs Dennis Dalessandro
2016-01-06 17:57 ` [PATCH v3 14/36] IB/rdmavt: Add SRQ stubs Dennis Dalessandro
2016-01-06 17:58 ` [PATCH v3 15/36] IB/rdmavt: Add multicast stubs Dennis Dalessandro
2016-01-06 17:58 ` [PATCH v3 16/36] IB/rdmavt: Add process MAD stub Dennis Dalessandro
2016-01-06 17:59 ` [PATCH v3 17/36] IB/rdmavt: Add mmap stub Dennis Dalessandro
2016-01-06 17:59 ` [PATCH v3 18/36] IB/rdmavt: Add get port immutable stub Dennis Dalessandro
2016-01-06 18:00 ` [PATCH v3 19/36] IB/rdmavt: Add completion queue function stubs Dennis Dalessandro
2016-01-06 18:01 ` Dennis Dalessandro [this message]
2016-01-06 18:01 ` [PATCH v3 21/36] IB/rdmavt: Move MR datastructures into rvt Dennis Dalessandro
2016-01-06 18:02 ` [PATCH v3 22/36] IB/rdmavt: Add queue pair data structure to rdmavt Dennis Dalessandro
2016-01-06 18:02 ` [PATCH v3 23/36] IB/rdmavt: Move driver helper functions to a common structure Dennis Dalessandro
2016-01-06 18:02 ` [PATCH v3 24/36] IB/rdmavt: Add device specific info prints Dennis Dalessandro
2016-01-06 18:03 ` [PATCH v3 25/36] IB/rdmavt: Add the start of capability flags Dennis Dalessandro
2016-01-06 18:03 ` [PATCH v3 26/36] IB/rdmavt: Move memory registration into rdmavt Dennis Dalessandro
2016-01-06 18:03 ` [PATCH v3 27/36] IB/rdmavt: Do not use rvt prints which rely on driver too early Dennis Dalessandro
2016-01-06 18:03 ` [PATCH v3 28/36] IB/rdmavt: Add common LID defines to rdmavt Dennis Dalessandro
2016-01-06 18:03 ` [PATCH v3 29/36] IB/rdmavt: Add AH " Dennis Dalessandro
2016-01-06 18:04 ` [PATCH v3 30/36] IB/rdmavt: Move SRQ data structure into rdmavt Dennis Dalessandro
2016-01-06 18:04 ` [PATCH v3 31/36] IB/rdmavt: Add an ibport data structure to rdmavt Dennis Dalessandro
2016-01-06 18:04 ` [PATCH v3 32/36] IB/rdmavt: Add driver notification for new AH Dennis Dalessandro
2016-01-06 18:04 ` [PATCH v3 33/36] IB/rdmavt: Break rdma_vt main include header file up Dennis Dalessandro
2016-01-06 18:04 ` [PATCH v3 34/36] IB/rdmavt: Initialize and teardown of qpn table Dennis Dalessandro
2016-01-06 18:04 ` [PATCH v3 35/36] IB/rdmavt: Add mmap related functions Dennis Dalessandro
2016-01-06 18:05 ` [PATCH v3 36/36] IB/rdmavt: Add pkey support Dennis Dalessandro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106180047.8747.6862.stgit@scvm10.sc.intel.com \
--to=dennis.dalessandro-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.