All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Harish Chegondi
	<harish.chegondi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Mike Marciniszyn
	<mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: [PATCH v3 32/36] IB/rdmavt: Add driver notification for new AH
Date: Wed, 06 Jan 2016 10:04:23 -0800	[thread overview]
Message-ID: <20160106180418.8747.56232.stgit@scvm10.sc.intel.com> (raw)
In-Reply-To: <20160106174638.8747.47197.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>

Drivers may need to do some work once an address handle has been
created. Add a driver function for this purpose.

Reviewed-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Reviewed-by: Mike Marciniszyn <mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Reviewed-by: Harish Chegondi <harish.chegondi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 drivers/infiniband/sw/rdmavt/ah.c |    7 +++++-
 include/rdma/rdma_vt.h            |   41 +++++++++++++++++++++++--------------
 2 files changed, 30 insertions(+), 18 deletions(-)

diff --git a/drivers/infiniband/sw/rdmavt/ah.c b/drivers/infiniband/sw/rdmavt/ah.c
index 2519db9..621afc3 100644
--- a/drivers/infiniband/sw/rdmavt/ah.c
+++ b/drivers/infiniband/sw/rdmavt/ah.c
@@ -83,8 +83,8 @@ int rvt_check_ah(struct ib_device *ibdev,
 		    !(ah_attr->ah_flags & IB_AH_GRH))
 			return -EINVAL;
 	}
-	if (rdi->driver_f.check_ah(ibdev, ah_attr))
-		return -EINVAL;
+	if (rdi->driver_f.check_ah)
+		return rdi->driver_f.check_ah(ibdev, ah_attr);
 	return 0;
 }
 EXPORT_SYMBOL(rvt_check_ah);
@@ -123,6 +123,9 @@ struct ib_ah *rvt_create_ah(struct ib_pd *pd,
 	ah->attr = *ah_attr;
 	atomic_set(&ah->refcount, 0);
 
+	if (dev->driver_f.notify_new_ah)
+		dev->driver_f.notify_new_ah(pd->device, ah_attr, ah);
+
 	return &ah->ibah;
 }
 
diff --git a/include/rdma/rdma_vt.h b/include/rdma/rdma_vt.h
index a3d6a5b..ef66d2b 100644
--- a/include/rdma/rdma_vt.h
+++ b/include/rdma/rdma_vt.h
@@ -467,9 +467,21 @@ struct rvt_driver_params {
 	int nports;
 };
 
-/*
- * Functions that drivers are required to support
- */
+/* Protection domain */
+struct rvt_pd {
+	struct ib_pd ibpd;
+	int user;               /* non-zero if created from user space */
+};
+
+/* Address handle */
+struct rvt_ah {
+	struct ib_ah ibah;
+	struct ib_ah_attr attr;
+	atomic_t refcount;
+	u8 vl;
+	u8 log_pmtu;
+};
+
 struct rvt_dev_info;
 struct rvt_driver_provided {
 	/*
@@ -478,23 +490,20 @@ struct rvt_driver_provided {
 	 * instead drivers are responsible for setting the correct callback for
 	 * this.
 	 */
+
+	/* -------------------*/
+	/* Required functions */
+	/* -------------------*/
 	int (*port_callback)(struct ib_device *, u8, struct kobject *);
 	const char * (*get_card_name)(struct rvt_dev_info *rdi);
 	struct pci_dev * (*get_pci_dev)(struct rvt_dev_info *rdi);
-	int (*check_ah)(struct ib_device *, struct ib_ah_attr *);
-};
 
-/* Protection domain */
-struct rvt_pd {
-	struct ib_pd ibpd;
-	int user;               /* non-zero if created from user space */
-};
-
-/* Address handle */
-struct rvt_ah {
-	struct ib_ah ibah;
-	struct ib_ah_attr attr;
-	atomic_t refcount;
+	/*--------------------*/
+	/* Optional functions */
+	/*--------------------*/
+	int (*check_ah)(struct ib_device *, struct ib_ah_attr *);
+	void (*notify_new_ah)(struct ib_device *, struct ib_ah_attr *,
+			      struct rvt_ah *);
 };
 
 struct rvt_dev_info {

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-01-06 18:04 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-06 17:49 [PATCH v3 00/36] Add rdma verbs transport library Dennis Dalessandro
     [not found] ` <20160106174638.8747.47197.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2016-01-06 17:50   ` [PATCH v3 01/36] IB/rdmavt: Create module framework and handle driver registration Dennis Dalessandro
2016-01-06 17:51   ` [PATCH v3 02/36] IB/rdmavt: Consolidate dma ops in rdmavt Dennis Dalessandro
2016-01-06 17:51   ` [PATCH v3 03/36] IB/rdmavt: Add protection domain to rdmavt Dennis Dalessandro
2016-01-06 17:52   ` [PATCH v3 04/36] IB/rdmavt: Add ib core device attributes to rvt driver params list Dennis Dalessandro
2016-01-06 17:52   ` [PATCH v3 05/36] IB/rdmavt: Macroize override checks during driver registration Dennis Dalessandro
2016-01-06 17:53   ` [PATCH v3 06/36] IB/rdmavt: Add query and modify device stubs Dennis Dalessandro
2016-01-06 17:54   ` [PATCH v3 07/36] IB/rdmavt: Add query and modify port stubs Dennis Dalessandro
2016-01-06 17:54   ` [PATCH v3 08/36] IB/rdmavt: Add pkey query stub Dennis Dalessandro
2016-01-06 17:54   ` [PATCH v3 09/36] IB/rdmavt: Add query gid stub Dennis Dalessandro
2016-01-06 17:55   ` [PATCH v3 10/36] IB/rdmavt: Alloc and dealloc ucontexts Dennis Dalessandro
2016-01-06 17:56   ` [PATCH v3 11/36] IB/rdmavt: Add queue pair function stubs Dennis Dalessandro
2016-01-06 17:56   ` [PATCH v3 12/36] IB/rdmavt: Add address handle stubs Dennis Dalessandro
2016-01-06 17:57   ` [PATCH v3 13/36] IB/rdmavt: Add memory region stubs Dennis Dalessandro
2016-01-06 17:57   ` [PATCH v3 14/36] IB/rdmavt: Add SRQ stubs Dennis Dalessandro
2016-01-06 17:58   ` [PATCH v3 15/36] IB/rdmavt: Add multicast stubs Dennis Dalessandro
2016-01-06 17:58   ` [PATCH v3 16/36] IB/rdmavt: Add process MAD stub Dennis Dalessandro
2016-01-06 17:59   ` [PATCH v3 17/36] IB/rdmavt: Add mmap stub Dennis Dalessandro
2016-01-06 17:59   ` [PATCH v3 18/36] IB/rdmavt: Add get port immutable stub Dennis Dalessandro
2016-01-06 18:00   ` [PATCH v3 19/36] IB/rdmavt: Add completion queue function stubs Dennis Dalessandro
2016-01-06 18:01   ` [PATCH v3 20/36] IB/rdmavt: Add post send and recv stubs Dennis Dalessandro
2016-01-06 18:01   ` [PATCH v3 21/36] IB/rdmavt: Move MR datastructures into rvt Dennis Dalessandro
2016-01-06 18:02   ` [PATCH v3 22/36] IB/rdmavt: Add queue pair data structure to rdmavt Dennis Dalessandro
2016-01-06 18:02   ` [PATCH v3 23/36] IB/rdmavt: Move driver helper functions to a common structure Dennis Dalessandro
2016-01-06 18:02   ` [PATCH v3 24/36] IB/rdmavt: Add device specific info prints Dennis Dalessandro
2016-01-06 18:03   ` [PATCH v3 25/36] IB/rdmavt: Add the start of capability flags Dennis Dalessandro
2016-01-06 18:03   ` [PATCH v3 26/36] IB/rdmavt: Move memory registration into rdmavt Dennis Dalessandro
2016-01-06 18:03   ` [PATCH v3 27/36] IB/rdmavt: Do not use rvt prints which rely on driver too early Dennis Dalessandro
2016-01-06 18:03   ` [PATCH v3 28/36] IB/rdmavt: Add common LID defines to rdmavt Dennis Dalessandro
2016-01-06 18:03   ` [PATCH v3 29/36] IB/rdmavt: Add AH " Dennis Dalessandro
2016-01-06 18:04   ` [PATCH v3 30/36] IB/rdmavt: Move SRQ data structure into rdmavt Dennis Dalessandro
2016-01-06 18:04   ` [PATCH v3 31/36] IB/rdmavt: Add an ibport data structure to rdmavt Dennis Dalessandro
2016-01-06 18:04   ` Dennis Dalessandro [this message]
2016-01-06 18:04   ` [PATCH v3 33/36] IB/rdmavt: Break rdma_vt main include header file up Dennis Dalessandro
2016-01-06 18:04   ` [PATCH v3 34/36] IB/rdmavt: Initialize and teardown of qpn table Dennis Dalessandro
2016-01-06 18:04   ` [PATCH v3 35/36] IB/rdmavt: Add mmap related functions Dennis Dalessandro
2016-01-06 18:05   ` [PATCH v3 36/36] IB/rdmavt: Add pkey support Dennis Dalessandro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160106180418.8747.56232.stgit@scvm10.sc.intel.com \
    --to=dennis.dalessandro-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=harish.chegondi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.