From: Sakari Ailus <sakari.ailus@iki.fi>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
"Prabhakar\"" <prabhakar.csengg@gmail.com>,
Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 5/8] [media] tvp514x: Check v4l2_of_parse_endpoint() return value
Date: Sun, 10 Jan 2016 01:01:48 +0200 [thread overview]
Message-ID: <20160109230148.GF576@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <1452191248-15847-6-git-send-email-javier@osg.samsung.com>
On Thu, Jan 07, 2016 at 03:27:19PM -0300, Javier Martinez Canillas wrote:
> The v4l2_of_parse_endpoint() function can fail so check the return value.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> drivers/media/i2c/tvp514x.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/tvp514x.c b/drivers/media/i2c/tvp514x.c
> index 7fa5f1e4fe37..7a1e20feade9 100644
> --- a/drivers/media/i2c/tvp514x.c
> +++ b/drivers/media/i2c/tvp514x.c
> @@ -1013,11 +1013,13 @@ tvp514x_get_pdata(struct i2c_client *client)
> if (!endpoint)
> return NULL;
>
> + if (v4l2_of_parse_endpoint(endpoint, &bus_cfg))
Same as in patch 6.
> + goto done;
> +
> pdata = devm_kzalloc(&client->dev, sizeof(*pdata), GFP_KERNEL);
> if (!pdata)
> goto done;
>
> - v4l2_of_parse_endpoint(endpoint, &bus_cfg);
> flags = bus_cfg.bus.parallel.flags;
>
> if (flags & V4L2_MBUS_HSYNC_ACTIVE_HIGH)
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
next prev parent reply other threads:[~2016-01-09 23:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 18:27 [PATCH 0/8] [media] Check v4l2_of_parse_endpoint() ret val in all drivers Javier Martinez Canillas
2016-01-07 18:27 ` Javier Martinez Canillas
2016-01-07 18:27 ` [PATCH 1/8] [media] v4l: of: Correct v4l2_of_parse_endpoint() kernel-doc Javier Martinez Canillas
2016-01-07 19:56 ` Sakari Ailus
2016-01-11 1:57 ` Laurent Pinchart
2016-01-07 18:27 ` [PATCH 2/8] [media] adv7604: Check v4l2_of_parse_endpoint() return value Javier Martinez Canillas
2016-01-07 18:27 ` [PATCH 3/8] [media] s5c73m3: " Javier Martinez Canillas
2016-01-07 18:27 ` [PATCH 4/8] [media] s5k5baf: " Javier Martinez Canillas
2016-01-07 18:27 ` [PATCH 5/8] [media] tvp514x: " Javier Martinez Canillas
2016-01-09 23:01 ` Sakari Ailus [this message]
2016-01-07 18:27 ` [PATCH 6/8] [media] tvp7002: " Javier Martinez Canillas
2016-01-09 23:01 ` Sakari Ailus
2016-01-07 18:27 ` [PATCH 7/8] [media] exynos4-is: " Javier Martinez Canillas
2016-01-07 18:27 ` Javier Martinez Canillas
2016-01-07 18:27 ` [PATCH 8/8] [media] omap3isp: " Javier Martinez Canillas
2016-01-11 1:58 ` Laurent Pinchart
2016-01-09 23:03 ` [PATCH 0/8] [media] Check v4l2_of_parse_endpoint() ret val in all drivers Sakari Ailus
2016-01-09 23:03 ` Sakari Ailus
2016-01-11 16:49 ` Javier Martinez Canillas
2016-01-11 16:49 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160109230148.GF576@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=hans.verkuil@cisco.com \
--cc=javier@osg.samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=prabhakar.csengg@gmail.com \
--cc=ricardo.ribalda@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.