From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: linux-kernel@vger.kernel.org,
Nikhil Devshatwar <nikhil.nd@ti.com>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-samsung-soc@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
"Prabhakar\"" <prabhakar.csengg@gmail.com>,
Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 0/8] [media] Check v4l2_of_parse_endpoint() ret val in all drivers
Date: Mon, 11 Jan 2016 13:49:38 -0300 [thread overview]
Message-ID: <5693DD22.9020805@osg.samsung.com> (raw)
In-Reply-To: <20160109230330.GG576@valkosipuli.retiisi.org.uk>
Hello Sakari,
On 01/09/2016 08:03 PM, Sakari Ailus wrote:
> Hi Javier,
>
> On Thu, Jan 07, 2016 at 03:27:14PM -0300, Javier Martinez Canillas wrote:
>> Hello,
>>
>> When discussing a patch [0] with Laurent Pinchart for another series I
>> mentioned to him that most callers of v4l2_of_parse_endpoint() weren't
>> checking the return value. This is likely due the function kernel-doc
>> stating incorrectly that the return value is always 0 but can return a
>> negative error code on failure.
>>
>> This trivial patch series fixes the function kernel-doc and add proper
>> error checking in all the drivers that are currently not doing so.
>
> After fixing patches 5 and 6,
>
Done, posted a v2 fixing the issues you pointed out.
> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>
Thanks a lot for your feedback and review!
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
WARNING: multiple messages have this Message-ID (diff)
From: javier@osg.samsung.com (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/8] [media] Check v4l2_of_parse_endpoint() ret val in all drivers
Date: Mon, 11 Jan 2016 13:49:38 -0300 [thread overview]
Message-ID: <5693DD22.9020805@osg.samsung.com> (raw)
In-Reply-To: <20160109230330.GG576@valkosipuli.retiisi.org.uk>
Hello Sakari,
On 01/09/2016 08:03 PM, Sakari Ailus wrote:
> Hi Javier,
>
> On Thu, Jan 07, 2016 at 03:27:14PM -0300, Javier Martinez Canillas wrote:
>> Hello,
>>
>> When discussing a patch [0] with Laurent Pinchart for another series I
>> mentioned to him that most callers of v4l2_of_parse_endpoint() weren't
>> checking the return value. This is likely due the function kernel-doc
>> stating incorrectly that the return value is always 0 but can return a
>> negative error code on failure.
>>
>> This trivial patch series fixes the function kernel-doc and add proper
>> error checking in all the drivers that are currently not doing so.
>
> After fixing patches 5 and 6,
>
Done, posted a v2 fixing the issues you pointed out.
> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>
Thanks a lot for your feedback and review!
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2016-01-11 16:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 18:27 [PATCH 0/8] [media] Check v4l2_of_parse_endpoint() ret val in all drivers Javier Martinez Canillas
2016-01-07 18:27 ` Javier Martinez Canillas
2016-01-07 18:27 ` [PATCH 1/8] [media] v4l: of: Correct v4l2_of_parse_endpoint() kernel-doc Javier Martinez Canillas
2016-01-07 19:56 ` Sakari Ailus
2016-01-11 1:57 ` Laurent Pinchart
2016-01-07 18:27 ` [PATCH 2/8] [media] adv7604: Check v4l2_of_parse_endpoint() return value Javier Martinez Canillas
2016-01-07 18:27 ` [PATCH 3/8] [media] s5c73m3: " Javier Martinez Canillas
2016-01-07 18:27 ` [PATCH 4/8] [media] s5k5baf: " Javier Martinez Canillas
2016-01-07 18:27 ` [PATCH 5/8] [media] tvp514x: " Javier Martinez Canillas
2016-01-09 23:01 ` Sakari Ailus
2016-01-07 18:27 ` [PATCH 6/8] [media] tvp7002: " Javier Martinez Canillas
2016-01-09 23:01 ` Sakari Ailus
2016-01-07 18:27 ` [PATCH 7/8] [media] exynos4-is: " Javier Martinez Canillas
2016-01-07 18:27 ` Javier Martinez Canillas
2016-01-07 18:27 ` [PATCH 8/8] [media] omap3isp: " Javier Martinez Canillas
2016-01-11 1:58 ` Laurent Pinchart
2016-01-09 23:03 ` [PATCH 0/8] [media] Check v4l2_of_parse_endpoint() ret val in all drivers Sakari Ailus
2016-01-09 23:03 ` Sakari Ailus
2016-01-11 16:49 ` Javier Martinez Canillas [this message]
2016-01-11 16:49 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5693DD22.9020805@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=a.hajda@samsung.com \
--cc=g.liakhovetski@gmx.de \
--cc=hans.verkuil@cisco.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=nikhil.nd@ti.com \
--cc=prabhakar.csengg@gmail.com \
--cc=ricardo.ribalda@gmail.com \
--cc=s.nawrocki@samsung.com \
--cc=sakari.ailus@iki.fi \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.