From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, Sakari Ailus <sakari.ailus@iki.fi>,
Nikhil Devshatwar <nikhil.nd@ti.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 1/8] [media] v4l: of: Correct v4l2_of_parse_endpoint() kernel-doc
Date: Mon, 11 Jan 2016 03:57:32 +0200 [thread overview]
Message-ID: <5744371.YiWThJLWUr@avalon> (raw)
In-Reply-To: <1452191248-15847-2-git-send-email-javier@osg.samsung.com>
Hi Javier,
Thank you for the patch.
On Thursday 07 January 2016 15:27:15 Javier Martinez Canillas wrote:
> The v4l2_of_parse_endpoint function kernel-doc says that the return value
> is always 0. But that is not true since the function can fail and a error
> negative code is returned on failure. So correct the kernel-doc to match.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>
> drivers/media/v4l2-core/v4l2-of.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-of.c
> b/drivers/media/v4l2-core/v4l2-of.c index b27cbb1f5afe..93b33681776c 100644
> --- a/drivers/media/v4l2-core/v4l2-of.c
> +++ b/drivers/media/v4l2-core/v4l2-of.c
> @@ -146,7 +146,7 @@ static void v4l2_of_parse_parallel_bus(const struct
> device_node *node, * variable without a low fixed limit. Please use
> * v4l2_of_alloc_parse_endpoint() in new drivers instead.
> *
> - * Return: 0.
> + * Return: 0 on success or a negative error code on failure.
> */
> int v4l2_of_parse_endpoint(const struct device_node *node,
> struct v4l2_of_endpoint *endpoint)
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2016-01-11 1:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 18:27 [PATCH 0/8] [media] Check v4l2_of_parse_endpoint() ret val in all drivers Javier Martinez Canillas
2016-01-07 18:27 ` Javier Martinez Canillas
2016-01-07 18:27 ` [PATCH 1/8] [media] v4l: of: Correct v4l2_of_parse_endpoint() kernel-doc Javier Martinez Canillas
2016-01-07 19:56 ` Sakari Ailus
2016-01-11 1:57 ` Laurent Pinchart [this message]
2016-01-07 18:27 ` [PATCH 2/8] [media] adv7604: Check v4l2_of_parse_endpoint() return value Javier Martinez Canillas
2016-01-07 18:27 ` [PATCH 3/8] [media] s5c73m3: " Javier Martinez Canillas
2016-01-07 18:27 ` [PATCH 4/8] [media] s5k5baf: " Javier Martinez Canillas
2016-01-07 18:27 ` [PATCH 5/8] [media] tvp514x: " Javier Martinez Canillas
2016-01-09 23:01 ` Sakari Ailus
2016-01-07 18:27 ` [PATCH 6/8] [media] tvp7002: " Javier Martinez Canillas
2016-01-09 23:01 ` Sakari Ailus
2016-01-07 18:27 ` [PATCH 7/8] [media] exynos4-is: " Javier Martinez Canillas
2016-01-07 18:27 ` Javier Martinez Canillas
2016-01-07 18:27 ` [PATCH 8/8] [media] omap3isp: " Javier Martinez Canillas
2016-01-11 1:58 ` Laurent Pinchart
2016-01-09 23:03 ` [PATCH 0/8] [media] Check v4l2_of_parse_endpoint() ret val in all drivers Sakari Ailus
2016-01-09 23:03 ` Sakari Ailus
2016-01-11 16:49 ` Javier Martinez Canillas
2016-01-11 16:49 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5744371.YiWThJLWUr@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=hans.verkuil@cisco.com \
--cc=javier@osg.samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=nikhil.nd@ti.com \
--cc=s.nawrocki@samsung.com \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.