All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Henry Chen <henryc.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Flora Fu <flora.fu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Matthias Brugger
	<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] mfd: mt6397: convert to arch_initcall
Date: Mon, 11 Jan 2016 05:49:32 +0000	[thread overview]
Message-ID: <20160111054932.GH3331@x1> (raw)
In-Reply-To: <1450862711-22124-1-git-send-email-henryc.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>

On Wed, 23 Dec 2015, Henry Chen wrote:

> Since pinctrl or regulator of mt6396 need to initialize earlier to avoid
> probe deferring, also change the core driver to arch_init.

This is exactly what deferring probe was designed for; so that you
don't have to mess around with initcall ordering.

> Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> ---
>  drivers/mfd/mt6397-core.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> index 1749c1c..af98b4b 100644
> --- a/drivers/mfd/mt6397-core.c
> +++ b/drivers/mfd/mt6397-core.c
> @@ -285,7 +285,11 @@ static struct platform_driver mt6397_driver = {
>  	},
>  };
>  
> -module_platform_driver(mt6397_driver);
> +static int __init mt6397_core_init(void)
> +{
> +	return platform_driver_register(&mt6397_driver);
> +}
> +arch_initcall(mt6397_core_init);
>  
>  MODULE_AUTHOR("Flora Fu, MediaTek");
>  MODULE_DESCRIPTION("Driver for MediaTek MT6397 PMIC");

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mfd: mt6397: convert to arch_initcall
Date: Mon, 11 Jan 2016 05:49:32 +0000	[thread overview]
Message-ID: <20160111054932.GH3331@x1> (raw)
In-Reply-To: <1450862711-22124-1-git-send-email-henryc.chen@mediatek.com>

On Wed, 23 Dec 2015, Henry Chen wrote:

> Since pinctrl or regulator of mt6396 need to initialize earlier to avoid
> probe deferring, also change the core driver to arch_init.

This is exactly what deferring probe was designed for; so that you
don't have to mess around with initcall ordering.

> Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> ---
>  drivers/mfd/mt6397-core.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> index 1749c1c..af98b4b 100644
> --- a/drivers/mfd/mt6397-core.c
> +++ b/drivers/mfd/mt6397-core.c
> @@ -285,7 +285,11 @@ static struct platform_driver mt6397_driver = {
>  	},
>  };
>  
> -module_platform_driver(mt6397_driver);
> +static int __init mt6397_core_init(void)
> +{
> +	return platform_driver_register(&mt6397_driver);
> +}
> +arch_initcall(mt6397_core_init);
>  
>  MODULE_AUTHOR("Flora Fu, MediaTek");
>  MODULE_DESCRIPTION("Driver for MediaTek MT6397 PMIC");

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Henry Chen <henryc.chen@mediatek.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Flora Fu <flora.fu@mediatek.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] mfd: mt6397: convert to arch_initcall
Date: Mon, 11 Jan 2016 05:49:32 +0000	[thread overview]
Message-ID: <20160111054932.GH3331@x1> (raw)
In-Reply-To: <1450862711-22124-1-git-send-email-henryc.chen@mediatek.com>

On Wed, 23 Dec 2015, Henry Chen wrote:

> Since pinctrl or regulator of mt6396 need to initialize earlier to avoid
> probe deferring, also change the core driver to arch_init.

This is exactly what deferring probe was designed for; so that you
don't have to mess around with initcall ordering.

> Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> ---
>  drivers/mfd/mt6397-core.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> index 1749c1c..af98b4b 100644
> --- a/drivers/mfd/mt6397-core.c
> +++ b/drivers/mfd/mt6397-core.c
> @@ -285,7 +285,11 @@ static struct platform_driver mt6397_driver = {
>  	},
>  };
>  
> -module_platform_driver(mt6397_driver);
> +static int __init mt6397_core_init(void)
> +{
> +	return platform_driver_register(&mt6397_driver);
> +}
> +arch_initcall(mt6397_core_init);
>  
>  MODULE_AUTHOR("Flora Fu, MediaTek");
>  MODULE_DESCRIPTION("Driver for MediaTek MT6397 PMIC");

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  parent reply	other threads:[~2016-01-11  5:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-23  9:25 [PATCH] mfd: mt6397: convert to arch_initcall Henry Chen
2015-12-23  9:25 ` Henry Chen
2015-12-23  9:25 ` Henry Chen
     [not found] ` <1450862711-22124-1-git-send-email-henryc.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2016-01-11  5:49   ` Lee Jones [this message]
2016-01-11  5:49     ` Lee Jones
2016-01-11  5:49     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160111054932.GH3331@x1 \
    --to=lee.jones-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
    --cc=flora.fu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
    --cc=henryc.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.