From: Marek Vasut <marex@denx.de>
To: Vignesh R <vigneshr@ti.com>
Cc: Dinh Nguyen <dinguyen@opensource.altera.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Graham Moore <grmoore@opensource.altera.com>,
Alan Tull <atull@opensource.altera.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Yves Vandervennet <yvanderv@opensource.altera.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH V10 2/2] mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller.
Date: Tue, 12 Jan 2016 14:49:49 +0100 [thread overview]
Message-ID: <201601121449.49266.marex@denx.de> (raw)
In-Reply-To: <569483DE.4070901@ti.com>
On Tuesday, January 12, 2016 at 05:41:02 AM, Vignesh R wrote:
> On 01/11/2016 09:39 PM, Dinh Nguyen wrote:
> > On 01/10/2016 10:34 PM, Marek Vasut wrote:
> >> From: Graham Moore <grmoore@opensource.altera.com>
> >>
> >> Add support for the Cadence QSPI controller. This controller is
> >> present in the Altera SoCFPGA SoCs and this driver has been tested
> >> on the Cyclone V SoC.
>
> [...]
>
> >> diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
> >> index 43bafde..7e29050 100644
> >> --- a/drivers/mtd/spi-nor/Kconfig
> >> +++ b/drivers/mtd/spi-nor/Kconfig
> >> @@ -50,4 +50,15 @@ config SPI_NXP_SPIFI
> >>
> >> Flash. Enable this option if you have a device with a SPIFI
> >> controller and want to access the Flash as a mtd device.
> >>
> >> +config SPI_CADENCE_QUADSPI
> >> + tristate "Cadence Quad SPI controller"
> >> + depends on OF && (ARCH_SOCFPGA || COMPILE_TEST)
> >
> > I think you can remove the ARCH_SOCFPGA dependency as this driver is
> > used on a TI EVM as well.
>
> I think above usage is correct. This will enable SPI_CADENCE_QUADSPI to
> be selected when ARCH_SOCFPGA=y without having to enable COMPILE_TEST.
> AFAIK, COMPILE_TEST is used usually to build test the driver w/o having
> to enable ARCH specific configs (usually by maintainers).
> For TI EVM, I would patch this file to add my architecture later(i.e
> along with DT patch to my board).
I changed this to OF && (ARM || COMPILE_TEST) , so that should be enough.
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
To: Vignesh R <vigneshr-l0cyMroinI0@public.gmane.org>
Cc: Dinh Nguyen
<dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>,
"linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Graham Moore
<grmoore-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>,
Alan Tull
<atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>,
Brian Norris
<computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Yves Vandervennet
<yvanderv-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH V10 2/2] mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller.
Date: Tue, 12 Jan 2016 14:49:49 +0100 [thread overview]
Message-ID: <201601121449.49266.marex@denx.de> (raw)
In-Reply-To: <569483DE.4070901-l0cyMroinI0@public.gmane.org>
On Tuesday, January 12, 2016 at 05:41:02 AM, Vignesh R wrote:
> On 01/11/2016 09:39 PM, Dinh Nguyen wrote:
> > On 01/10/2016 10:34 PM, Marek Vasut wrote:
> >> From: Graham Moore <grmoore-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
> >>
> >> Add support for the Cadence QSPI controller. This controller is
> >> present in the Altera SoCFPGA SoCs and this driver has been tested
> >> on the Cyclone V SoC.
>
> [...]
>
> >> diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
> >> index 43bafde..7e29050 100644
> >> --- a/drivers/mtd/spi-nor/Kconfig
> >> +++ b/drivers/mtd/spi-nor/Kconfig
> >> @@ -50,4 +50,15 @@ config SPI_NXP_SPIFI
> >>
> >> Flash. Enable this option if you have a device with a SPIFI
> >> controller and want to access the Flash as a mtd device.
> >>
> >> +config SPI_CADENCE_QUADSPI
> >> + tristate "Cadence Quad SPI controller"
> >> + depends on OF && (ARCH_SOCFPGA || COMPILE_TEST)
> >
> > I think you can remove the ARCH_SOCFPGA dependency as this driver is
> > used on a TI EVM as well.
>
> I think above usage is correct. This will enable SPI_CADENCE_QUADSPI to
> be selected when ARCH_SOCFPGA=y without having to enable COMPILE_TEST.
> AFAIK, COMPILE_TEST is used usually to build test the driver w/o having
> to enable ARCH specific configs (usually by maintainers).
> For TI EVM, I would patch this file to add my architecture later(i.e
> along with DT patch to my board).
I changed this to OF && (ARM || COMPILE_TEST) , so that should be enough.
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-12 13:51 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 4:34 [PATCH V8 1/2] mtd: spi-nor: Bindings for Cadence Quad SPI Flash Controller driver Marek Vasut
2016-01-11 4:34 ` Marek Vasut
2016-01-11 4:34 ` [PATCH V10 2/2] mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller Marek Vasut
2016-01-11 4:34 ` Marek Vasut
2016-01-11 16:09 ` Dinh Nguyen
2016-01-11 16:09 ` Dinh Nguyen
2016-01-11 16:32 ` Marek Vasut
2016-01-11 16:32 ` Marek Vasut
2016-01-12 4:41 ` Vignesh R
2016-01-12 4:41 ` Vignesh R
2016-01-12 13:49 ` Marek Vasut [this message]
2016-01-12 13:49 ` Marek Vasut
2016-04-06 16:55 ` R, Vignesh
2016-04-06 16:55 ` R, Vignesh
2016-04-06 19:30 ` Marek Vasut
2016-04-06 19:30 ` Marek Vasut
2016-04-07 4:55 ` Vignesh R
2016-04-07 4:55 ` Vignesh R
2016-04-13 10:27 ` Marek Vasut
2016-04-13 10:27 ` Marek Vasut
2016-04-13 15:06 ` Marek Vasut
2016-04-13 15:06 ` Marek Vasut
2016-04-14 16:41 ` R, Vignesh
2016-04-14 16:41 ` R, Vignesh
2016-04-14 17:46 ` Marek Vasut
2016-04-14 17:46 ` Marek Vasut
2016-05-13 0:00 ` Trent Piepho
2016-05-13 0:00 ` Trent Piepho
2016-05-13 0:24 ` Marek Vasut
2016-05-13 0:24 ` Marek Vasut
2016-05-13 20:43 ` Trent Piepho
2016-05-13 20:43 ` Trent Piepho
2016-05-25 23:08 ` Marek Vasut
2016-05-25 23:08 ` Marek Vasut
2016-05-25 23:02 ` Marek Vasut
2016-05-25 23:02 ` Marek Vasut
2016-01-11 16:06 ` [PATCH V8 1/2] mtd: spi-nor: Bindings for Cadence Quad SPI Flash Controller driver Dinh Nguyen
2016-01-11 16:06 ` Dinh Nguyen
2016-01-11 16:32 ` Marek Vasut
2016-01-11 16:32 ` Marek Vasut
2016-01-11 17:03 ` Dinh Nguyen
2016-01-11 17:03 ` Dinh Nguyen
2016-01-11 17:27 ` Marek Vasut
2016-01-11 17:27 ` Marek Vasut
2016-01-13 2:26 ` Rob Herring
2016-01-13 2:26 ` Rob Herring
2016-01-13 2:39 ` Marek Vasut
2016-01-13 2:39 ` Marek Vasut
2016-02-01 21:03 ` Brian Norris
2016-02-01 21:03 ` Brian Norris
2016-02-01 21:13 ` Marek Vasut
2016-02-01 21:13 ` Marek Vasut
2016-02-04 7:38 ` Vignesh R
2016-02-04 7:38 ` Vignesh R
2016-02-04 11:25 ` Marek Vasut
2016-02-04 11:25 ` Marek Vasut
2016-02-04 17:04 ` Dinh Nguyen
2016-02-04 17:04 ` Dinh Nguyen
2016-02-06 7:42 ` Marek Vasut
2016-02-06 7:42 ` Marek Vasut
2016-02-04 17:30 ` R, Vignesh
2016-02-04 17:30 ` R, Vignesh
2016-02-06 7:42 ` Marek Vasut
2016-02-06 7:42 ` Marek Vasut
2016-02-08 11:19 ` Vignesh R
2016-02-08 11:19 ` Vignesh R
2016-02-08 15:27 ` Marek Vasut
2016-02-08 15:27 ` Marek Vasut
2016-02-10 16:10 ` Graham Moore
2016-02-10 16:10 ` Graham Moore
2016-02-10 16:17 ` Marek Vasut
2016-02-10 16:17 ` Marek Vasut
2016-03-10 20:55 ` Graham Moore
2016-03-10 20:55 ` Graham Moore
2016-03-10 21:10 ` Marek Vasut
2016-03-10 21:10 ` Marek Vasut
2016-03-14 18:17 ` Graham Moore
2016-03-14 18:17 ` Graham Moore
2016-03-14 22:47 ` Marek Vasut
2016-03-14 22:47 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201601121449.49266.marex@denx.de \
--to=marex@denx.de \
--cc=atull@opensource.altera.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@opensource.altera.com \
--cc=dwmw2@infradead.org \
--cc=grmoore@opensource.altera.com \
--cc=linux-mtd@lists.infradead.org \
--cc=vigneshr@ti.com \
--cc=yvanderv@opensource.altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.