All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vignesh R <vigneshr@ti.com>
To: Marek Vasut <marex@denx.de>
Cc: Brian Norris <computersforpeace@gmail.com>,
	Rob Herring <robh@kernel.org>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	Graham Moore <grmoore@opensource.altera.com>,
	Alan Tull <atull@opensource.altera.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Dinh Nguyen <dinguyen@opensource.altera.com>,
	Yves Vandervennet <yvanderv@opensource.altera.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH V8 1/2] mtd: spi-nor: Bindings for Cadence Quad SPI Flash Controller driver.
Date: Mon, 8 Feb 2016 16:49:25 +0530	[thread overview]
Message-ID: <56B879BD.2070608@ti.com> (raw)
In-Reply-To: <201602060842.38290.marex@denx.de>



On 02/06/2016 01:12 PM, Marek Vasut wrote:
> On Thursday, February 04, 2016 at 06:30:27 PM, R, Vignesh wrote:
>> On 2/4/2016 4:55 PM, Marek Vasut wrote:

[...]

>> Yeah, there is delay(of few ns) required between writing to
>> INDIRECTWR_START bit and actually writing data to flash(i.e writesl()
>> call). This is specific to TI K2G SoC and needs to be tied to the new
>> binding.
> 
> Can't you somehow poll the hardware to check whether or not it's ready instead
> of adding some random delay ?

There is no dedicated register to poll as such.

According to TRM:
"Wait for couple of cycles of QSPI_REF_CLK(functional clock of QSPI
@384MHz) until CQSPI_REG_INDIRECTWR[0] bit is internally synchronized by
the QSPI module before writing to flash".

So, a few ns(~6ns @384MHz) delay is needed (or accessing a QSPI module
register should be sufficient as it will take more than 2 clock cycles).
I believe this delay is specific to TI K2G SoC and maybe needs to be
tied to the binding.


-- 
Regards
Vignesh

WARNING: multiple messages have this Message-ID (diff)
From: Vignesh R <vigneshr-l0cyMroinI0@public.gmane.org>
To: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
Cc: Brian Norris
	<computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	Graham Moore
	<grmoore-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>,
	Alan Tull
	<atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>,
	David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	Dinh Nguyen
	<dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>,
	Yves Vandervennet
	<yvanderv-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH V8 1/2] mtd: spi-nor: Bindings for Cadence Quad SPI Flash Controller driver.
Date: Mon, 8 Feb 2016 16:49:25 +0530	[thread overview]
Message-ID: <56B879BD.2070608@ti.com> (raw)
In-Reply-To: <201602060842.38290.marex-ynQEQJNshbs@public.gmane.org>



On 02/06/2016 01:12 PM, Marek Vasut wrote:
> On Thursday, February 04, 2016 at 06:30:27 PM, R, Vignesh wrote:
>> On 2/4/2016 4:55 PM, Marek Vasut wrote:

[...]

>> Yeah, there is delay(of few ns) required between writing to
>> INDIRECTWR_START bit and actually writing data to flash(i.e writesl()
>> call). This is specific to TI K2G SoC and needs to be tied to the new
>> binding.
> 
> Can't you somehow poll the hardware to check whether or not it's ready instead
> of adding some random delay ?

There is no dedicated register to poll as such.

According to TRM:
"Wait for couple of cycles of QSPI_REF_CLK(functional clock of QSPI
@384MHz) until CQSPI_REG_INDIRECTWR[0] bit is internally synchronized by
the QSPI module before writing to flash".

So, a few ns(~6ns @384MHz) delay is needed (or accessing a QSPI module
register should be sufficient as it will take more than 2 clock cycles).
I believe this delay is specific to TI K2G SoC and maybe needs to be
tied to the binding.


-- 
Regards
Vignesh
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-02-08 11:20 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-11  4:34 [PATCH V8 1/2] mtd: spi-nor: Bindings for Cadence Quad SPI Flash Controller driver Marek Vasut
2016-01-11  4:34 ` Marek Vasut
2016-01-11  4:34 ` [PATCH V10 2/2] mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller Marek Vasut
2016-01-11  4:34   ` Marek Vasut
2016-01-11 16:09   ` Dinh Nguyen
2016-01-11 16:09     ` Dinh Nguyen
2016-01-11 16:32     ` Marek Vasut
2016-01-11 16:32       ` Marek Vasut
2016-01-12  4:41     ` Vignesh R
2016-01-12  4:41       ` Vignesh R
2016-01-12 13:49       ` Marek Vasut
2016-01-12 13:49         ` Marek Vasut
2016-04-06 16:55   ` R, Vignesh
2016-04-06 16:55     ` R, Vignesh
2016-04-06 19:30     ` Marek Vasut
2016-04-06 19:30       ` Marek Vasut
2016-04-07  4:55       ` Vignesh R
2016-04-07  4:55         ` Vignesh R
2016-04-13 10:27         ` Marek Vasut
2016-04-13 10:27           ` Marek Vasut
2016-04-13 15:06         ` Marek Vasut
2016-04-13 15:06           ` Marek Vasut
2016-04-14 16:41           ` R, Vignesh
2016-04-14 16:41             ` R, Vignesh
2016-04-14 17:46             ` Marek Vasut
2016-04-14 17:46               ` Marek Vasut
2016-05-13  0:00   ` Trent Piepho
2016-05-13  0:00     ` Trent Piepho
2016-05-13  0:24     ` Marek Vasut
2016-05-13  0:24       ` Marek Vasut
2016-05-13 20:43       ` Trent Piepho
2016-05-13 20:43         ` Trent Piepho
2016-05-25 23:08         ` Marek Vasut
2016-05-25 23:08           ` Marek Vasut
2016-05-25 23:02     ` Marek Vasut
2016-05-25 23:02       ` Marek Vasut
2016-01-11 16:06 ` [PATCH V8 1/2] mtd: spi-nor: Bindings for Cadence Quad SPI Flash Controller driver Dinh Nguyen
2016-01-11 16:06   ` Dinh Nguyen
2016-01-11 16:32   ` Marek Vasut
2016-01-11 16:32     ` Marek Vasut
2016-01-11 17:03     ` Dinh Nguyen
2016-01-11 17:03       ` Dinh Nguyen
2016-01-11 17:27       ` Marek Vasut
2016-01-11 17:27         ` Marek Vasut
2016-01-13  2:26 ` Rob Herring
2016-01-13  2:26   ` Rob Herring
2016-01-13  2:39   ` Marek Vasut
2016-01-13  2:39     ` Marek Vasut
2016-02-01 21:03     ` Brian Norris
2016-02-01 21:03       ` Brian Norris
2016-02-01 21:13       ` Marek Vasut
2016-02-01 21:13         ` Marek Vasut
2016-02-04  7:38         ` Vignesh R
2016-02-04  7:38           ` Vignesh R
2016-02-04 11:25           ` Marek Vasut
2016-02-04 11:25             ` Marek Vasut
2016-02-04 17:04             ` Dinh Nguyen
2016-02-04 17:04               ` Dinh Nguyen
2016-02-06  7:42               ` Marek Vasut
2016-02-06  7:42                 ` Marek Vasut
2016-02-04 17:30             ` R, Vignesh
2016-02-04 17:30               ` R, Vignesh
2016-02-06  7:42               ` Marek Vasut
2016-02-06  7:42                 ` Marek Vasut
2016-02-08 11:19                 ` Vignesh R [this message]
2016-02-08 11:19                   ` Vignesh R
2016-02-08 15:27                   ` Marek Vasut
2016-02-08 15:27                     ` Marek Vasut
2016-02-10 16:10                     ` Graham Moore
2016-02-10 16:10                       ` Graham Moore
2016-02-10 16:17                       ` Marek Vasut
2016-02-10 16:17                         ` Marek Vasut
2016-03-10 20:55                         ` Graham Moore
2016-03-10 20:55                           ` Graham Moore
2016-03-10 21:10                           ` Marek Vasut
2016-03-10 21:10                             ` Marek Vasut
2016-03-14 18:17                             ` Graham Moore
2016-03-14 18:17                               ` Graham Moore
2016-03-14 22:47                               ` Marek Vasut
2016-03-14 22:47                                 ` Marek Vasut
  -- strict thread matches above, loose matches on Subject: below --
2016-06-04  0:39 Marek Vasut
2016-06-04  0:39 ` Marek Vasut
2016-06-07 14:00 ` Rob Herring
2016-06-07 14:00   ` Rob Herring
2016-07-18 17:00   ` Brian Norris
2016-07-18 17:00     ` Brian Norris
2015-08-21  9:20 Marek Vasut
2015-08-21  9:20 ` Marek Vasut
2015-08-27 17:44 ` vikas
2015-08-27 17:44   ` vikas
2015-08-27 18:12   ` Marek Vasut
2015-08-27 18:12     ` Marek Vasut
2015-08-27 20:18     ` vikas
2015-08-27 20:18       ` vikas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B879BD.2070608@ti.com \
    --to=vigneshr@ti.com \
    --cc=atull@opensource.altera.com \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@opensource.altera.com \
    --cc=dwmw2@infradead.org \
    --cc=grmoore@opensource.altera.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marex@denx.de \
    --cc=robh@kernel.org \
    --cc=yvanderv@opensource.altera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.