From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
X86 Kernel <x86@kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
jacob.jun.pan@linux.intel.com, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH v2 2/2] powercap/rapl: reduce ipi calls
Date: Wed, 13 Jan 2016 08:21:13 -0800 [thread overview]
Message-ID: <20160113082113.3314fa92@icelake> (raw)
In-Reply-To: <alpine.DEB.2.11.1601131042590.3575@nanos>
On Wed, 13 Jan 2016 10:47:26 +0100 (CET)
Thomas Gleixner <tglx@linutronix.de> wrote:
> So here you actually use that new (misnomed) function, but for
>
> > +static void power_limit_irq_save_cpu(void *info)
>
> and
>
> > +static void power_limit_irq_restore_cpu(void *info)
>
> you use a bog standard smp function call. What's the benefit of
> adding that rmw function over a bog standard smp function call if you
> can only use it for one instance of the same pattern?
>
> Boris asked you the same question here
>
> https://lkml.kernel.org/r/20151220152749.GA29805@pd.tnic
>
> but you decided to ignore it.
+Borislav,
Thanks for bring this out. I didn't mean to ignore. I thought my point
was stated in the commit message there was no point of going back and
forth. Read-Modify-Write is quite common, not just for RAPL could be
used by future code. Sorry if I wasn't clear.
Jacob
next prev parent reply other threads:[~2016-01-13 16:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 1:11 [PATCH v2 0/2] Reduce IPI calls for remote msr access Jacob Pan
2016-01-13 1:11 ` [PATCH v2 1/2] x86/msr: add on cpu read/modify/write function Jacob Pan
2016-01-13 1:11 ` [PATCH v2 2/2] powercap/rapl: reduce ipi calls Jacob Pan
2016-01-13 9:47 ` Thomas Gleixner
2016-01-13 16:21 ` Jacob Pan [this message]
2016-01-13 16:36 ` Borislav Petkov
2016-01-13 17:51 ` Jacob Pan
2016-01-13 18:04 ` Borislav Petkov
2016-01-13 18:21 ` Jacob Pan
2016-01-13 19:16 ` Borislav Petkov
2016-01-13 20:10 ` Jacob Pan
2016-01-13 21:26 ` Borislav Petkov
2016-01-13 21:54 ` Srinivas Pandruvada
2016-01-13 22:02 ` Thomas Gleixner
2016-01-13 22:11 ` Jacob Pan
2016-01-13 22:23 ` H. Peter Anvin
2016-01-13 22:16 ` Borislav Petkov
2016-01-13 22:39 ` Srinivas Pandruvada
2016-01-13 22:20 ` Jacob Pan
2016-01-13 22:29 ` Borislav Petkov
2016-01-13 21:49 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160113082113.3314fa92@icelake \
--to=jacob.jun.pan@linux.intel.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.