From: Borislav Petkov <bp@alien8.de>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
X86 Kernel <x86@kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v2 2/2] powercap/rapl: reduce ipi calls
Date: Wed, 13 Jan 2016 20:16:22 +0100 [thread overview]
Message-ID: <20160113191622.GP12897@pd.tnic> (raw)
In-Reply-To: <20160113102138.4e34e890@yairi>
On Wed, Jan 13, 2016 at 10:21:38AM -0800, Jacob Pan wrote:
> static int cpufreq_p4_setdc(unsigned int cpu, unsigned int newstate)
> {
> ...
>
> rdmsr_on_cpu(cpu, MSR_IA32_THERM_CONTROL, &l, &h);
> if (newstate == DC_DISABLE) {
> pr_debug("CPU#%d disabling modulation\n", cpu);
> wrmsr_on_cpu(cpu, MSR_IA32_THERM_CONTROL, l & ~(1<<4),
> h); } else {
> pr_debug("CPU#%d setting duty cycle to %d%%\n",
> cpu, ((125 * newstate) / 10));
> /* bits 63 - 5 : reserved
> * bit 4 : enable/disable
> * bits 3-1 : duty cycle
> * bit 0 : reserved
> */
> l = (l & ~14);
> l = l | (1<<4) | ((newstate & 0x7)<<1);
> wrmsr_on_cpu(cpu, MSR_IA32_THERM_CONTROL, l, h);
> }
This cannot be converted because you need to do the stuff between the
rdmsr_on_cpu() and wrmsr_on_cpu() calls.
> static int sfi_cpufreq_target(struct cpufreq_policy *policy, unsigned
> int index) {
> ...
>
> rdmsr_on_cpu(policy->cpu, MSR_IA32_PERF_CTL, &lo, &hi);
> lo = (lo & ~INTEL_PERF_CTL_MASK) |
> ((u32) sfi_cpufreq_array[next_perf_state].ctrl_val &
> INTEL_PERF_CTL_MASK);
> wrmsr_on_cpu(policy->cpu, MSR_IA32_PERF_CTL, lo, hi);
Ditto.
These two examples prove my point, actually.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2016-01-13 19:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 1:11 [PATCH v2 0/2] Reduce IPI calls for remote msr access Jacob Pan
2016-01-13 1:11 ` [PATCH v2 1/2] x86/msr: add on cpu read/modify/write function Jacob Pan
2016-01-13 1:11 ` [PATCH v2 2/2] powercap/rapl: reduce ipi calls Jacob Pan
2016-01-13 9:47 ` Thomas Gleixner
2016-01-13 16:21 ` Jacob Pan
2016-01-13 16:36 ` Borislav Petkov
2016-01-13 17:51 ` Jacob Pan
2016-01-13 18:04 ` Borislav Petkov
2016-01-13 18:21 ` Jacob Pan
2016-01-13 19:16 ` Borislav Petkov [this message]
2016-01-13 20:10 ` Jacob Pan
2016-01-13 21:26 ` Borislav Petkov
2016-01-13 21:54 ` Srinivas Pandruvada
2016-01-13 22:02 ` Thomas Gleixner
2016-01-13 22:11 ` Jacob Pan
2016-01-13 22:23 ` H. Peter Anvin
2016-01-13 22:16 ` Borislav Petkov
2016-01-13 22:39 ` Srinivas Pandruvada
2016-01-13 22:20 ` Jacob Pan
2016-01-13 22:29 ` Borislav Petkov
2016-01-13 21:49 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160113191622.GP12897@pd.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.