From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
X86 Kernel <x86@kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH v2 2/2] powercap/rapl: reduce ipi calls
Date: Wed, 13 Jan 2016 09:51:24 -0800 [thread overview]
Message-ID: <20160113095124.186ff487@yairi> (raw)
In-Reply-To: <20160113163610.GH12897@pd.tnic>
On Wed, 13 Jan 2016 17:36:10 +0100
Borislav Petkov <bp@alien8.de> wrote:
> On Wed, Jan 13, 2016 at 08:21:13AM -0800, Jacob Pan wrote:
> > Thanks for bring this out. I didn't mean to ignore. I thought my
> > point was stated in the commit message there was no point of going
> > back and forth. Read-Modify-Write is quite common, not just for
> > RAPL could be used by future code. Sorry if I wasn't clear.
>
> But it also shows that it doesn't suffice for all your needs. So why
> add it?
>
> You can much better define your own functions which do all the MSR
> handling you require and call them with smp_call_function_*.
>
yeah, that is what I did in the original patch.
https://lkml.org/lkml/2015/12/7/1090
Then i was suggested to add a rmw msr api for the common good :), I
think it is a good idea since such operation is not limited to RAPL
driver. Other register access APIs such as regmap have more complete
selections.
Jacob
next prev parent reply other threads:[~2016-01-13 17:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 1:11 [PATCH v2 0/2] Reduce IPI calls for remote msr access Jacob Pan
2016-01-13 1:11 ` [PATCH v2 1/2] x86/msr: add on cpu read/modify/write function Jacob Pan
2016-01-13 1:11 ` [PATCH v2 2/2] powercap/rapl: reduce ipi calls Jacob Pan
2016-01-13 9:47 ` Thomas Gleixner
2016-01-13 16:21 ` Jacob Pan
2016-01-13 16:36 ` Borislav Petkov
2016-01-13 17:51 ` Jacob Pan [this message]
2016-01-13 18:04 ` Borislav Petkov
2016-01-13 18:21 ` Jacob Pan
2016-01-13 19:16 ` Borislav Petkov
2016-01-13 20:10 ` Jacob Pan
2016-01-13 21:26 ` Borislav Petkov
2016-01-13 21:54 ` Srinivas Pandruvada
2016-01-13 22:02 ` Thomas Gleixner
2016-01-13 22:11 ` Jacob Pan
2016-01-13 22:23 ` H. Peter Anvin
2016-01-13 22:16 ` Borislav Petkov
2016-01-13 22:39 ` Srinivas Pandruvada
2016-01-13 22:20 ` Jacob Pan
2016-01-13 22:29 ` Borislav Petkov
2016-01-13 21:49 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160113095124.186ff487@yairi \
--to=jacob.jun.pan@linux.intel.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.