From: "Pali Rohár" <pali.rohar@gmail.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>, "Andrew F. Davis" <afd@ti.com>,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org,
aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com,
patrikbachan@gmail.com, serge@hallyn.com, a.hajda@samsung.com
Subject: Re: /sys/class/power_supply/bq27200-0/capacity changed meaning between 4.1 and 4.4?
Date: Wed, 13 Jan 2016 11:32:41 +0100 [thread overview]
Message-ID: <20160113103241.GH11560@pali> (raw)
In-Reply-To: <20160113102613.GA28729@earth>
On Wednesday 13 January 2016 11:26:13 Sebastian Reichel wrote:
> On Wed, Jan 13, 2016 at 09:44:24AM +0100, Pali Rohár wrote:
> > On Tuesday 12 January 2016 22:53:52 Pavel Machek wrote:
> > > Hi!
> > >
> > > > >>If not, tell me, and I can do it, but it will involve a lot of swaring...
> > > > >
> > > > >I'll give it a look over.
> > > >
> > > > OK, I'm still looking for a test setup, but this was definitely a problem,
> > > > could you give this a try?:
> > >
> > > Well, search no more. I tested it and seems to work ok. There's one
> > > more blank line in the source, so I had to apply patch by hand.
> > >
> > > Tested-by: Pavel Machek <pavel@ucw.cz>
> > > Acked-by: Pavel Machek <pavel@ucw.cz>
> > > Reported-by: Pavel Machek <pavel@ucw.cz>
> > > Cc: stable@vger.kernel.org
> > >
> > > ? :-).
> > >
> > > And... thanks!
> > > Pavel
> >
> > There are more pending fixes for bq27xxx... Maybe your is duplicate?
>
> No, it's not a duplicate.
>
> > http://thread.gmane.org/gmane.linux.power-management.general/70090
> > http://thread.gmane.org/gmane.linux.power-management.general/69716/focus=69714
> > http://thread.gmane.org/gmane.linux.power-management.general/69716/focus=2110580
Hm... It looks like Pavel's patch is subset of this 3rd patch as it fix
function bq27xxx_battery_read_soc()
> > Sebastian, please take them and ideally send to stable@ for backporting.
>
> There is no need to send them to stable@, if they are properly
> tagged with a 'Fixes: <sha1> ("title")' tag, so please always
> include it in your commit messages, if possible :)
I have not sent those patches, but OK. In that email thread you can find
sha1 commit id which broke it.
--
Pali Rohár
pali.rohar@gmail.com
WARNING: multiple messages have this Message-ID (diff)
From: pali.rohar@gmail.com (Pali Rohár)
To: linux-arm-kernel@lists.infradead.org
Subject: /sys/class/power_supply/bq27200-0/capacity changed meaning between 4.1 and 4.4?
Date: Wed, 13 Jan 2016 11:32:41 +0100 [thread overview]
Message-ID: <20160113103241.GH11560@pali> (raw)
In-Reply-To: <20160113102613.GA28729@earth>
On Wednesday 13 January 2016 11:26:13 Sebastian Reichel wrote:
> On Wed, Jan 13, 2016 at 09:44:24AM +0100, Pali Roh?r wrote:
> > On Tuesday 12 January 2016 22:53:52 Pavel Machek wrote:
> > > Hi!
> > >
> > > > >>If not, tell me, and I can do it, but it will involve a lot of swaring...
> > > > >
> > > > >I'll give it a look over.
> > > >
> > > > OK, I'm still looking for a test setup, but this was definitely a problem,
> > > > could you give this a try?:
> > >
> > > Well, search no more. I tested it and seems to work ok. There's one
> > > more blank line in the source, so I had to apply patch by hand.
> > >
> > > Tested-by: Pavel Machek <pavel@ucw.cz>
> > > Acked-by: Pavel Machek <pavel@ucw.cz>
> > > Reported-by: Pavel Machek <pavel@ucw.cz>
> > > Cc: stable at vger.kernel.org
> > >
> > > ? :-).
> > >
> > > And... thanks!
> > > Pavel
> >
> > There are more pending fixes for bq27xxx... Maybe your is duplicate?
>
> No, it's not a duplicate.
>
> > http://thread.gmane.org/gmane.linux.power-management.general/70090
> > http://thread.gmane.org/gmane.linux.power-management.general/69716/focus=69714
> > http://thread.gmane.org/gmane.linux.power-management.general/69716/focus=2110580
Hm... It looks like Pavel's patch is subset of this 3rd patch as it fix
function bq27xxx_battery_read_soc()
> > Sebastian, please take them and ideally send to stable@ for backporting.
>
> There is no need to send them to stable@, if they are properly
> tagged with a 'Fixes: <sha1> ("title")' tag, so please always
> include it in your commit messages, if possible :)
I have not sent those patches, but OK. In that email thread you can find
sha1 commit id which broke it.
--
Pali Roh?r
pali.rohar at gmail.com
next prev parent reply other threads:[~2016-01-13 10:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 23:07 /sys/class/power_supply/bq27200-0/capacity changed meaning between 4.1 and 4.4? Pavel Machek
2016-01-09 23:07 ` Pavel Machek
2016-01-10 8:06 ` Pavel Machek
2016-01-10 8:06 ` Pavel Machek
2016-01-11 14:44 ` Andrew F. Davis
2016-01-11 14:44 ` Andrew F. Davis
2016-01-11 14:44 ` Andrew F. Davis
2016-01-11 14:25 ` Andrew F. Davis
2016-01-11 14:25 ` Andrew F. Davis
2016-01-11 14:25 ` Andrew F. Davis
2016-01-11 21:42 ` Pavel Machek
2016-01-11 21:42 ` Pavel Machek
2016-01-11 21:48 ` Andrew F. Davis
2016-01-11 21:48 ` Andrew F. Davis
2016-01-11 21:48 ` Andrew F. Davis
2016-01-12 15:22 ` Andrew F. Davis
2016-01-12 15:22 ` Andrew F. Davis
2016-01-12 15:22 ` Andrew F. Davis
2016-01-12 21:53 ` Pavel Machek
2016-01-12 21:53 ` Pavel Machek
2016-01-13 8:44 ` Pali Rohár
2016-01-13 8:44 ` Pali Rohár
2016-01-13 10:26 ` Sebastian Reichel
2016-01-13 10:26 ` Sebastian Reichel
2016-01-13 10:26 ` Sebastian Reichel
2016-01-13 10:32 ` Pali Rohár [this message]
2016-01-13 10:32 ` Pali Rohár
2016-01-13 11:01 ` Pavel Machek
2016-01-13 11:01 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160113103241.GH11560@pali \
--to=pali.rohar@gmail.com \
--cc=a.hajda@samsung.com \
--cc=aaro.koskinen@iki.fi \
--cc=afd@ti.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=patrikbachan@gmail.com \
--cc=pavel@ucw.cz \
--cc=serge@hallyn.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.