From: "Andrew F. Davis" <afd@ti.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: pali.rohar@gmail.com, sre@debian.org, sre@ring0.de,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org,
aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com,
patrikbachan@gmail.com, serge@hallyn.com, a.hajda@samsung.com
Subject: Re: /sys/class/power_supply/bq27200-0/capacity changed meaning between 4.1 and 4.4?
Date: Mon, 11 Jan 2016 15:48:52 -0600 [thread overview]
Message-ID: <56942344.9070609@ti.com> (raw)
In-Reply-To: <20160111214247.GA9735@amd>
On 01/11/2016 03:42 PM, Pavel Machek wrote:
> Hi!
>
>>> Did /sys/class/power_supply/bq27200-0/capacity change meaning between
>>> 4.1 and 4.4?
>
>> There was a resent overhaul of this driver and a lot of code is
>> vestigial as you have seen. I've been meaning to continue
>> cleaning it up, my next step would probably to bring up regmap
>
> Ok, 1wire is probably reasonable approach. But we have an regression
> between 4.1 and 4.4, and to debug it is probably by reading code.
>
> I can't prove you caused the regression, but you basically rewrote the
> driver, so it should be easier for you to spot the bug.
>
Makes sense.
> n900 has this variant:
>
> bq27200: bq27200@55 {
> compatible = "ti,bq27200";
> reg = <0x55>;
> };
>
Hmmm, not sure if I have this one on hand, I'll see if I can find an
n900 around here (they seem to be pretty popular around here for testing
(had a lot of TI parts)).
> Will you try?
>
> If not, tell me, and I can do it, but it will involve a lot of swaring...
>
I'll give it a look over.
> Thanks,
> Pavel
>
WARNING: multiple messages have this Message-ID (diff)
From: afd@ti.com (Andrew F. Davis)
To: linux-arm-kernel@lists.infradead.org
Subject: /sys/class/power_supply/bq27200-0/capacity changed meaning between 4.1 and 4.4?
Date: Mon, 11 Jan 2016 15:48:52 -0600 [thread overview]
Message-ID: <56942344.9070609@ti.com> (raw)
In-Reply-To: <20160111214247.GA9735@amd>
On 01/11/2016 03:42 PM, Pavel Machek wrote:
> Hi!
>
>>> Did /sys/class/power_supply/bq27200-0/capacity change meaning between
>>> 4.1 and 4.4?
>
>> There was a resent overhaul of this driver and a lot of code is
>> vestigial as you have seen. I've been meaning to continue
>> cleaning it up, my next step would probably to bring up regmap
>
> Ok, 1wire is probably reasonable approach. But we have an regression
> between 4.1 and 4.4, and to debug it is probably by reading code.
>
> I can't prove you caused the regression, but you basically rewrote the
> driver, so it should be easier for you to spot the bug.
>
Makes sense.
> n900 has this variant:
>
> bq27200: bq27200 at 55 {
> compatible = "ti,bq27200";
> reg = <0x55>;
> };
>
Hmmm, not sure if I have this one on hand, I'll see if I can find an
n900 around here (they seem to be pretty popular around here for testing
(had a lot of TI parts)).
> Will you try?
>
> If not, tell me, and I can do it, but it will involve a lot of swaring...
>
I'll give it a look over.
> Thanks,
> Pavel
>
WARNING: multiple messages have this Message-ID (diff)
From: "Andrew F. Davis" <afd@ti.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: <pali.rohar@gmail.com>, <sre@debian.org>, <sre@ring0.de>,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>, <tony@atomide.com>,
<khilman@kernel.org>, <aaro.koskinen@iki.fi>,
<ivo.g.dimitrov.75@gmail.com>, <patrikbachan@gmail.com>,
<serge@hallyn.com>, <a.hajda@samsung.com>
Subject: Re: /sys/class/power_supply/bq27200-0/capacity changed meaning between 4.1 and 4.4?
Date: Mon, 11 Jan 2016 15:48:52 -0600 [thread overview]
Message-ID: <56942344.9070609@ti.com> (raw)
In-Reply-To: <20160111214247.GA9735@amd>
On 01/11/2016 03:42 PM, Pavel Machek wrote:
> Hi!
>
>>> Did /sys/class/power_supply/bq27200-0/capacity change meaning between
>>> 4.1 and 4.4?
>
>> There was a resent overhaul of this driver and a lot of code is
>> vestigial as you have seen. I've been meaning to continue
>> cleaning it up, my next step would probably to bring up regmap
>
> Ok, 1wire is probably reasonable approach. But we have an regression
> between 4.1 and 4.4, and to debug it is probably by reading code.
>
> I can't prove you caused the regression, but you basically rewrote the
> driver, so it should be easier for you to spot the bug.
>
Makes sense.
> n900 has this variant:
>
> bq27200: bq27200@55 {
> compatible = "ti,bq27200";
> reg = <0x55>;
> };
>
Hmmm, not sure if I have this one on hand, I'll see if I can find an
n900 around here (they seem to be pretty popular around here for testing
(had a lot of TI parts)).
> Will you try?
>
> If not, tell me, and I can do it, but it will involve a lot of swaring...
>
I'll give it a look over.
> Thanks,
> Pavel
>
next prev parent reply other threads:[~2016-01-11 21:48 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 23:07 /sys/class/power_supply/bq27200-0/capacity changed meaning between 4.1 and 4.4? Pavel Machek
2016-01-09 23:07 ` Pavel Machek
2016-01-10 8:06 ` Pavel Machek
2016-01-10 8:06 ` Pavel Machek
2016-01-11 14:44 ` Andrew F. Davis
2016-01-11 14:44 ` Andrew F. Davis
2016-01-11 14:44 ` Andrew F. Davis
2016-01-11 14:25 ` Andrew F. Davis
2016-01-11 14:25 ` Andrew F. Davis
2016-01-11 14:25 ` Andrew F. Davis
2016-01-11 21:42 ` Pavel Machek
2016-01-11 21:42 ` Pavel Machek
2016-01-11 21:48 ` Andrew F. Davis [this message]
2016-01-11 21:48 ` Andrew F. Davis
2016-01-11 21:48 ` Andrew F. Davis
2016-01-12 15:22 ` Andrew F. Davis
2016-01-12 15:22 ` Andrew F. Davis
2016-01-12 15:22 ` Andrew F. Davis
2016-01-12 21:53 ` Pavel Machek
2016-01-12 21:53 ` Pavel Machek
2016-01-13 8:44 ` Pali Rohár
2016-01-13 8:44 ` Pali Rohár
2016-01-13 10:26 ` Sebastian Reichel
2016-01-13 10:26 ` Sebastian Reichel
2016-01-13 10:26 ` Sebastian Reichel
2016-01-13 10:32 ` Pali Rohár
2016-01-13 10:32 ` Pali Rohár
2016-01-13 11:01 ` Pavel Machek
2016-01-13 11:01 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56942344.9070609@ti.com \
--to=afd@ti.com \
--cc=a.hajda@samsung.com \
--cc=aaro.koskinen@iki.fi \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=patrikbachan@gmail.com \
--cc=pavel@ucw.cz \
--cc=serge@hallyn.com \
--cc=sre@debian.org \
--cc=sre@ring0.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.