All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Timur Tabi <timur@tabi.org>
Cc: Caleb Crome <caleb@crome.org>, Xiubo Li <Xiubo.Lee@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst settings device tree options
Date: Thu, 14 Jan 2016 18:33:25 -0800	[thread overview]
Message-ID: <20160115023325.GA29132@Asurada-Nvidia> (raw)
In-Reply-To: <56984BE7.2050303@tabi.org>

On Thu, Jan 14, 2016 at 07:31:19PM -0600, Timur Tabi wrote:
> Nicolin Chen wrote:
> >I think DT maintainers may not give a consent towards these two
> >properties as they are not to describe the hardware but to hack
> >software configurations. (And it seems you haven't CCed them.)
 
> I admit it's a grey area, but the hardware doesn't work if you use
> the wrong value, and it is a fixed value per device.  A p1022ds
> would use a different value than in in i.MX6, and once you pick a
> value, it's the same no matter which sample rate, buffer size, etc
> you choose.

Wish we could settle down a common solution for each case. If that
doesn't work for PPC, we may confine the modifications to i.MX only
by overriding those settings in the fsl_ssi_imx_probe() for safety.

  reply	other threads:[~2016-01-15  2:33 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-14 16:29 [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst settings device tree options Caleb Crome
     [not found] ` <1452788982-11583-1-git-send-email-caleb-EebDDntmC0DYtjvyW6yDsg@public.gmane.org>
2016-01-14 20:18   ` Nicolin Chen
2016-01-14 20:18     ` Nicolin Chen
2016-01-14 21:26     ` Caleb Crome
2016-01-14 21:26       ` Caleb Crome
2016-01-15  2:45       ` Nicolin Chen
2016-01-15  4:56         ` Caleb Crome
2016-01-15  4:56           ` Caleb Crome
2016-01-15 18:12           ` Nicolin Chen
2016-01-15  1:31     ` Timur Tabi
2016-01-15  2:33       ` Nicolin Chen [this message]
2016-01-15  3:25       ` Rob Herring
2016-01-15  3:25         ` Rob Herring
     [not found]       ` <56984BE7.2050303-N01EOCouUvQ@public.gmane.org>
2016-01-15 13:13         ` Mark Brown
2016-01-15 13:13           ` Mark Brown
     [not found]           ` <20160115131325.GW6588-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-01-15 13:46             ` Timur Tabi
2016-01-15 13:46               ` Timur Tabi
2016-01-15 17:03               ` Caleb Crome
2016-01-15 17:03                 ` Caleb Crome
2016-01-15 18:38                 ` Nicolin Chen
2016-01-15 18:49                   ` Caleb Crome
2016-01-15 18:57                     ` Nicolin Chen
2016-01-15 19:10                       ` Caleb Crome
2016-01-15 19:23                         ` Nicolin Chen
2016-01-15 19:23                           ` Nicolin Chen
2016-01-15 19:49                         ` Timur Tabi
     [not found]                         ` <CAG5mAdyUfSuCqA4_342MS2AyshvuyeiYsjQyRqifmqVhn4T2xA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-16 14:15                           ` Timur Tabi
2016-01-16 14:15                             ` Timur Tabi
2016-01-17 23:34                             ` Caleb Crome
2016-01-15 19:51                   ` Timur Tabi
2016-01-15 19:51                     ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160115023325.GA29132@Asurada-Nvidia \
    --to=nicoleotsuka@gmail.com \
    --cc=Xiubo.Lee@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=caleb@crome.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=timur@tabi.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.